From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Kanda <mark.kanda@oracle.com>
Subject: Re: [PATCH] KVM: nVMX: Eliminate vmcs02 pool
Date: Mon, 27 Nov 2017 11:43:14 -0600
Message-ID: <0dd4862d-f1dd-bd08-a91d-97060c7b5f42@oracle.com>
References: <e0e08f11f9d4a0c06e462a4a4217e996da058913.1511284598.git.mark.kanda@oracle.com>
 <da3c3271-3ece-db85-78c9-a3f7b4108c89@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: rkrcmar@redhat.com, ameya.more@oracle.com,
        Jim Mattson <jmattson@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from userp1040.oracle.com ([156.151.31.81]:43824 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752802AbdK0Rm0 (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 27 Nov 2017 12:42:26 -0500
In-Reply-To: <da3c3271-3ece-db85-78c9-a3f7b4108c89@redhat.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 11/23/2017 5:46 PM, Paolo Bonzini wrote:
> On 21/11/2017 18:22, Mark Kanda wrote:
>> -	nested_free_all_saved_vmcss(vmx);
>> +	free_loaded_vmcs(&vmx->nested.vmcs02);
> 
> Please add to free_loaded_vmcs a WARN that the passed vmcs is not
> vmx->loaded_vmcs.
> 

Sure.

However, I don't see a way to access vmx from the passed in vmcs, which 
would necessitate passing in vmx for the WARN (multiple callers) - I may 
be missing something..

I'm happy to do this, but it seems possibly excessive for the sole 
purpose of adding the WARN. Thoughts?

Thanks,

-Mark