From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30655C74A5B for ; Tue, 21 Mar 2023 15:53:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24E838450D; Tue, 21 Mar 2023 16:53:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="YTExar2+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 03C5480AE2; Tue, 21 Mar 2023 16:53:28 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20612.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::612]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EE4F780AE2 for ; Tue, 21 Mar 2023 16:53:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cV7YT6rlKMgnQU6fcZ/EoXn/sz9J277RQrI2jqSissFCu8aciDlVw/kRDyNcpyoKQZG+7lKL+mcKmvhT/c3z/evlAfbUm5UGMrEIlh0qPnCfP4nbEchcxj4jBGjT34H8tkSOoCbnzG9Al6JO1FG/8gRDalQqRl7z/DRjS2TcK1uh1ZQhovA7YAcN4xJ71i2I6rdS3Wm8Yn8izXr5vcnk4+z55D6OrFb/PLwNYPWemDOOTIGNFI9Xpj0NhMnvo+Oj8v3oQEIxmMdZE7LUm0RhbeUxPnHIWPIe4nubD9D4ArjwYGCGjg1EaX2CeU894pPnPRUKZaro0ECVpRJaRrhBYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ERzNy+SiahDaKYFOP9jNv+jVQGDuWoqiR50ORkuEx2U=; b=TMYtMoLPbO6dEZirozYjqS2MojiOhIUQhFhmKTbxm7QyiXEvogaIrtcUojxHG+tmO5gtaLt7DLITR9lZ76V9e9ZTb2nfSorQRb26dQHdm27r4aUkoRyqcmmBG3Cd2gaylmT9qEnCJ76ElktoW0s6Aey6NVR5j4o8JvUxV6fBsa6SDsaBunmieTuwhlxRlE1BOD0TXTBxueRAWqOzcCulPYalFS1bcENIxRywOMQySbQ9wCTc/3KzBHKg8V3SdhBFYOcfb6tIGhc4M8spc9kk85vUAVjislkqI4iO6s1QGNbRBDfqPMbRx2glzWcnPCbZhV1dK62LHj3g3svRtfcbXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ERzNy+SiahDaKYFOP9jNv+jVQGDuWoqiR50ORkuEx2U=; b=YTExar2+cv6AxV5Mm/CC2kMUROBhy/P4W2hJH+2C4QlA4rVbKJMLtz5hJCsWvaWrNikmK3hwV6HR/WDUVCE6r4lbpvl2WHRUBlcJP/GYd3ynZqfj55d63D++5/s6ujgx1p/KRiJEo0DUQVIkygpBihXllyaI57qkE/zTDrUXjJM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by DB3PR08MB9087.eurprd08.prod.outlook.com (2603:10a6:10:430::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 15:53:23 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::bb7b:6a6:db8c:e8e3]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::bb7b:6a6:db8c:e8e3%5]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 15:53:23 +0000 Message-ID: <0ddfb023-08a4-8469-f467-c871cfd596bb@weidmueller.com> Date: Tue, 21 Mar 2023 16:53:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] fs: fat: do not mangle short filenames To: Tom Rini Cc: u-boot@lists.denx.de, Stefan Herbrechtsmeier , Simon Glass References: <20230317120413.11066-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20230320170105.GA8135@bill-the-cat> <20230321153535.GS8135@bill-the-cat> From: Stefan Herbrechtsmeier In-Reply-To: <20230321153535.GS8135@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::13) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6969:EE_|DB3PR08MB9087:EE_ X-MS-Office365-Filtering-Correlation-Id: 61001912-db74-4b44-6291-08db2a2466b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YcofA01drAdGt5obaCcqv4PHwxpPX9hqmdO1ESuLwiBy+g6mBxktjhk4ST3TQQytjPhCxHivWETBIrdy7Nt/SkZbn9YJtxgeBrWI2W48TgRgZSnKwdGUGSDl011cS08KM1e++KfZdKgdGXz3gETkzLz4KTeVzGxSvvhCUZXRoE+TqCeW8wjjMYd0wIXEDZRJHdzv3+40gtLELHe9QQpRL/1kkfxJlx+2GUIa4ItxUpy6iO5xnvWunUVvs8dmsWmK1MZha8t+0scwhdUnMZ1jtJTKPsyGdko9XLfzT4Xsbdk27+orUKA8+3Zln4IN6Ol1myhgZXWPGe1pM+zdwydfqSx4B3aSlFOY8to85x15PU+wdJfKUeCBheIiZ9MQ6bviZsQWQbhxzyd8mW1b/J3mUz6X67qAFJeFieLbw1vzYQ7+Mfk1V3bZAWZru9bmMNUkxMPSLBKJ097xeMA/qrt0QB9KTnKkm+ZRWshIVGhxCjb+m5GUfIrl+m3TEZRwKeWV1MRqQA7oShcv2OcULHr1LJbXC8zx5kQMgHmbusZANF9pCI0UK1ZK8FF5gRRgblWjHXxNSil70SddSfq1d3PLJuZ4G/RNbCkBSgspa2tj4l/pVCjMwtAv91yTC+/QSyipTQKdm3cDZgFLFJjTDFKCVqNU7lIycFSmVVq8e52LiWCZxxSkqjA2iayg3zAAARsMoIfqfr8AcOM0i3kNrruTs6dEQ7JoyaV/IDO2K7wQB2VipcCgHWyMs452fisZfdOI58fTkp3n8FSTD+8rrR9Eow== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(366004)(396003)(376002)(346002)(39850400004)(451199018)(2616005)(186003)(6916009)(8676002)(66476007)(4326008)(41300700001)(66556008)(86362001)(31696002)(66946007)(2906002)(31686004)(6512007)(6506007)(26005)(38100700002)(38350700002)(54906003)(8936002)(52116002)(36756003)(83380400001)(316002)(5660300002)(6486002)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlhjMkNWVjZ5bG94YWQ3YzRhRmk0MXZZM09hZEc1dVFsNCtzZHNDYXBjbEFj?= =?utf-8?B?TnRIc1BpdDFkMndxNUluNUppSm8rTFlaMWlvcTlEREhWbzZOcUduNVhNcGRE?= =?utf-8?B?WlVydEpmc1lhMDB0bjMxbVhTUnlWNVpZUWNvY2xTR2xLWXZudWxFVHZHdWhv?= =?utf-8?B?dmZNTUpRang1Vjg1Sng1WmxIV1krckxKSUNHbDJZYnoyWm9jdXpjUWVydWo4?= =?utf-8?B?b2hMdDFOQXR6ODRFclZ1a09td3R0SDEwZWR0TEhzSHgrVHNYdkczMGpoWlZU?= =?utf-8?B?elhyMllDQTk5MGdnWmFDMTR5Wmp4emtpQXNYTnNKNFc2aThyMHpwb0NHNFU2?= =?utf-8?B?bXVRamxEQ3QwTk92TzVQNHEzcWhVTys1U3RQZjRxWjhkUWJRaER2eHpMV0Q4?= =?utf-8?B?cXBEUm1tVmo4My9RTjY0NGJDdFh2bEVsNkxOYnhVaUNJMFlkczVxSG9FK2l4?= =?utf-8?B?MDBmK1BHVTIyYUhQRTZYOXV1NFU3alZkQmN2Ym1UMFVheGk3YWNPWUMyUDlB?= =?utf-8?B?S2VmYkF0TExmTS91TnBnL3JrNFY4R2hWcFhhYzVRSVUrUlNneFJrMVlidzJz?= =?utf-8?B?MUdjVGF6d2J5Y21FTzFLYjNrMjJwZklXQjFKRUdHT2xBNG0rcHcrNnlNSGZt?= =?utf-8?B?cEdwVGRFZ05rQmxwaEVJWWlMRjNvZWk0V2Q0NU5sTHFiTFJyNjNzUDJpVW13?= =?utf-8?B?OTkveWZzTkZMOXg3ZnRFcVIwMDJ2ZEtrNmhxZCt6bDJJZmtJSkxmRHgrcldU?= =?utf-8?B?NjUyR0ZLSkwvWVRXY0JSWUdJMStpM2ZkWC9XS2psclEvdmlQdkc0SkwzaHF3?= =?utf-8?B?a09SL05WNUJzNjFmcllDYVpCQ2FXSEhMRW5GQ0FLblpINHRLK2NRR3R4SzBm?= =?utf-8?B?K2pWSzhaVWwxazZCTW1lVlh0T1BsTkowNi8wV2V6V0ljQ1phcHZhblVYa2Nq?= =?utf-8?B?UzNGS3JwZnE0ajZIOHBWK1JUQW5UWlBLT2NBcEpzWWxGTjdkSXljRlJBbDVJ?= =?utf-8?B?SlVLS1oxSXFFaHgvNmdXNGtuQlZEM1V1MTJFY3U2L0tHb3VTODJiNHdhdXlD?= =?utf-8?B?U2YxMXdxS0UxdFFYTkVtYVRTTnhwY1VuVk1WV00xTFNHRCtGazdmUzFDdXNP?= =?utf-8?B?aVNQbGtTakZ0TkNMc2RRV05TY3pEWkJyZUx2ZE4zOXMwTEFCWG5kUm9pdzQr?= =?utf-8?B?NnhhVDlvdEtZc3BFaWczS1UrZlhxRHVkR3JlR0orKzZ1OHZXZEdsMGp4dm16?= =?utf-8?B?Q0lReGpxcmtoWW55T1piNndLOGs5V0lxcy9LT2JvVzl4SWpQUVhFck5UeHNG?= =?utf-8?B?bk5XbVBvVU9LdWNsbXpGVzk4RjBoMjMxRUVPdmROcUFrQ1ZoSjVSRWI4alA1?= =?utf-8?B?YTdEZlVBOGtsQmJyd1JEUG5aRzJtcHAyN2NLMjdRNks1SVJSek1GTDlScWgw?= =?utf-8?B?azJ6eE5qTGdWYVdqLzZHU0xiN2xpMlVHb3VHUXJ2RkIxWXRpWTNTTitkUnhO?= =?utf-8?B?SE9BTW8rcmV6RExmMWxEOVJWZEc4azBRVVoxVk9ieHd3VkNxSEZoZFIwTjNZ?= =?utf-8?B?QWJBUnVHdG9pUXViSm93TG4yWHBFZ1IvUUFnRU5hZDZPZlIvSWp2VC9JOTRR?= =?utf-8?B?c3JTWjE5enR1RDVmQXU5ODFqUWtwNllvKzlCd1lsY2MyRkNzaDhlbTBlczRC?= =?utf-8?B?SGQyNjBldENwREhZaDJMdjBtRnRrNm1PRHlJdHBMMlBTNCs2T0lSNndBRDJP?= =?utf-8?B?MXpIT3hIemNDdERKSDZacHR0Y1N5ZFpYek4xdGlpajFDM1FSbW9Ga0JjYUJR?= =?utf-8?B?UDdkbS9RMzNqYTg5aldDRDZObVU0aVJmOGdCSXdtdDQxZzM3aWNPTGgweC80?= =?utf-8?B?RGtiejBUSzdrRVlpL3g4TlN1YXBJQnlTZmFxVUVlQUFCQnRLOHRMNTJlNzVB?= =?utf-8?B?Zk5LTVRhOG05a3BlVlZqOTVXbTFRdmZpZEdoMUN1SDNJckc1K0trUHpRTndi?= =?utf-8?B?Ym9zcFRqM0Q2ZGpSem5ncy93YjlMTnl1cEhrMS9FZHdPeWJCRXlmK09aMnR5?= =?utf-8?B?dHc4TzZrYkduZmoydTc2TTVlYWkreWZCQTJhK1p2R3lwREh6UCttckNlS3R3?= =?utf-8?B?OHNlQTY4SEZZSGxDcWI4TDVkRVlxbE9xSmlvTXluREUzNDZncC9XL3dabkZx?= =?utf-8?B?TEE9PQ==?= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61001912-db74-4b44-6291-08db2a2466b1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 15:53:23.4710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vuj1KYkzE0Bcrzm9bG/BQwKGC8gAyN8+kIKOt17OPMv9uZTPVQtkY0Z0T2ztOefWJBiI0dX8URODaSv2U9pOvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9087 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Am 21.03.2023 um 16:35 schrieb Tom Rini: > On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wrote: >> Am 20.03.2023 um 18:01 schrieb Tom Rini: >>> On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote: >>> >>>> From: Stefan Herbrechtsmeier >>>> >>>> Do not mangle lower or mixed case filenames which fit into the upper >>>> case 8.3 short filename. This ensures FAT standard compatible short >>>> filenames (SFN) to support systems without long filename (LFN) support >>>> like boot roms (ex. SFN BOOT.BIN instead of BOOT~1.BIN for LFN >>>> boot.bin). >>>> >>>> Signed-off-by: Stefan Herbrechtsmeier >>>> >>>> --- >>>> >>>> fs/fat/fat_write.c | 11 +++++++---- >>>> 1 file changed, 7 insertions(+), 4 deletions(-) >>> Can we update test/py/tests/test_fs/ somewhere to have a test for this >>> case? Thanks. >> What is the recommended approach to test internal behavior? The short name >> isn't avialable at the terminal because u-boot support VFAT. > Well, you triggered this problem with a filesystem that had contents > that were "just so" and then didn't work as expected, yes? No, I write a file to a file system and the boot rom do not find the file because the name was wrong (BOOT~1.BIN instead of BOOT.BIN). The mdir command shows the short and long file name. I will add a test_fat.py with a test. Regards   Stefan