From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42014C433E1 for ; Tue, 16 Jun 2020 12:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F02520734 for ; Tue, 16 Jun 2020 12:31:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="hFT1xUBQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728483AbgFPMbA (ORCPT ); Tue, 16 Jun 2020 08:31:00 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:48764 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgFPMa7 (ORCPT ); Tue, 16 Jun 2020 08:30:59 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05GCUmVc063733; Tue, 16 Jun 2020 07:30:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1592310648; bh=8Qx/5mQW/ObYotai4BueB40LH/bmL06FeT6kWL8joj4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=hFT1xUBQp1Ur1V5JkzJqVwfO1OXTUz2gJaefj2439LQtzY37HZTA8N8EZK6JZEPcj ZpOjvxyf3hMsunjCM/Pkf26TZoxTFxoaSQMrvzJJGXHyW67B9t4OFZSBl3pvls/cAr V7iu73M05z3xXo+bVMpYfH35A/oPUQj0WNdfinyI= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05GCUm6W018956; Tue, 16 Jun 2020 07:30:48 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 16 Jun 2020 07:30:47 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 16 Jun 2020 07:30:47 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05GCUjC9103134; Tue, 16 Jun 2020 07:30:46 -0500 Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display To: Adam Ford , Fabio Estevam CC: DRI mailing list , David Airlie , Adam Ford-BE , stable , linux-kernel , Thierry Reding , Sam Ravnborg References: <20200615131934.12440-1-aford173@gmail.com> From: Tomi Valkeinen Message-ID: <0df0bf28-dbf7-4d1e-06f0-d545df8dc2d5@ti.com> Date: Tue, 16 Jun 2020 15:30:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/06/2020 17:53, Adam Ford wrote: > On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam wrote: >> >> On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote: >>> >>> The LogicPD Type28 display used by several Logic PD products has not >>> worked since v5.5. >> >> Maybe you could tell which commit exactly and then put a Fixes tag? > > I honestly don't know. I reached out to the omap mailing list, > because I noted this issue. Tomi V from TI responded with a link that > he posted which fixes this for another display. > > https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html > > I tested that patch and it worked for a different LCD, so I did the > same thing to the Logic PD Type 28 display as well. > > My patch and commit message were modeled after his, and his commit > CC's stable with a note about being required for v5.5+ > > I added him to the CC list, so maybe he knows which hash needs to be > referenced from a fixes tag. I was hoping to not have to go back and > bisect if it's not required, but I will if necessary. No, I didn't check when exactly it broke. connector_type was added in v5.5, and my patch applies to v5.5, so I set that as stable version. But the WARN comes from panel bridge. Possibly 89958b7cd9555a5d82556cc9a1f4c62fffda6f96 is the one that adds requirement to have connector_type. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1988DC433DF for ; Tue, 16 Jun 2020 12:30:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC34720734 for ; Tue, 16 Jun 2020 12:30:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="hFT1xUBQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC34720734 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31BBA6E8B5; Tue, 16 Jun 2020 12:30:54 +0000 (UTC) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4784C6E8B5 for ; Tue, 16 Jun 2020 12:30:53 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05GCUmVc063733; Tue, 16 Jun 2020 07:30:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1592310648; bh=8Qx/5mQW/ObYotai4BueB40LH/bmL06FeT6kWL8joj4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=hFT1xUBQp1Ur1V5JkzJqVwfO1OXTUz2gJaefj2439LQtzY37HZTA8N8EZK6JZEPcj ZpOjvxyf3hMsunjCM/Pkf26TZoxTFxoaSQMrvzJJGXHyW67B9t4OFZSBl3pvls/cAr V7iu73M05z3xXo+bVMpYfH35A/oPUQj0WNdfinyI= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05GCUm6W018956; Tue, 16 Jun 2020 07:30:48 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 16 Jun 2020 07:30:47 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 16 Jun 2020 07:30:47 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05GCUjC9103134; Tue, 16 Jun 2020 07:30:46 -0500 Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display To: Adam Ford , Fabio Estevam References: <20200615131934.12440-1-aford173@gmail.com> From: Tomi Valkeinen Message-ID: <0df0bf28-dbf7-4d1e-06f0-d545df8dc2d5@ti.com> Date: Tue, 16 Jun 2020 15:30:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Adam Ford-BE , stable , linux-kernel , Thierry Reding , DRI mailing list , Sam Ravnborg Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 15/06/2020 17:53, Adam Ford wrote: > On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam wrote: >> >> On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote: >>> >>> The LogicPD Type28 display used by several Logic PD products has not >>> worked since v5.5. >> >> Maybe you could tell which commit exactly and then put a Fixes tag? > > I honestly don't know. I reached out to the omap mailing list, > because I noted this issue. Tomi V from TI responded with a link that > he posted which fixes this for another display. > > https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html > > I tested that patch and it worked for a different LCD, so I did the > same thing to the Logic PD Type 28 display as well. > > My patch and commit message were modeled after his, and his commit > CC's stable with a note about being required for v5.5+ > > I added him to the CC list, so maybe he knows which hash needs to be > referenced from a fixes tag. I was hoping to not have to go back and > bisect if it's not required, but I will if necessary. No, I didn't check when exactly it broke. connector_type was added in v5.5, and my patch applies to v5.5, so I set that as stable version. But the WARN comes from panel bridge. Possibly 89958b7cd9555a5d82556cc9a1f4c62fffda6f96 is the one that adds requirement to have connector_type. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel