From: Usama Arif <usama.arif@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH 2/2] board: armltd: Add support for Total Compute platform
Date: Wed, 12 Aug 2020 15:12:41 +0100 [thread overview]
Message-ID: <0dfac560-c863-c3be-b3fc-f69c497fc690@arm.com> (raw)
In-Reply-To: <20200812124046.GF20605@bill-the-cat>
On 12/08/2020 13:40, Tom Rini wrote:
> On Tue, Aug 11, 2020 at 03:46:04PM +0100, Usama Arif wrote:
>
>> Total Compute is based on ARM architecture and has
>> the following features enabled in u-boot:
>> - PL011 UART
>> - PL180 MMC
>> - NOR Flash
>> - FIT image with Signature
>> - AVB
>>
>> Signed-off-by: Usama Arif <usama.arif@arm.com>
> [snip]
>> diff --git a/board/armltd/total_compute/MAINTAINERS b/board/armltd/total_compute/MAINTAINERS
>> new file mode 100644
>> index 0000000000..7c653d469a
>> --- /dev/null
>> +++ b/board/armltd/total_compute/MAINTAINERS
>> @@ -0,0 +1,6 @@
>> +TOTAL_COMPUTE BOARD
>> +M: Usama Arif <usama.arif@arm.com>
>> +S: Maintained
>> +F: board/armltd/total_compute/
>> +F: include/configs/total_compute.h
>> +F: configs/total_compute_defconfig
>
> Please list the dtb files as well here.
>
>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>> + "load_addr=0xa0000000\0" \
>> + "kernel_addr_r=0x80080000\0" \
>> + "initrd_addr_r=0x88000000\0" \
>> + "fdt_addr_r=0x83000000\0" \
>> + "fdt_high=0xffffffffffffffff\0" \
>> + "initrd_high=0xffffffffffffffff\0"
>> +
>
> Disabling fdt/initrd relocation is wrong. Please set bootm_size as
> needed if fdt/initrd need to be relocated to within a window of memory
> rather than all available. Thanks!
>
Hi,
Thanks for the review.
I have submitted a v2 version of the patch with
arch/arm/dts/total_compute.dts addded to
board/armltd/total_compute/MAINTAINERS and a bootm_size of 512 MB.
Thanks,
Usama
next prev parent reply other threads:[~2020-08-12 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 14:46 [PATCH 1/2] avb: Make AVB independent of fastboot Usama Arif
2020-08-11 14:46 ` [PATCH 2/2] board: armltd: Add support for Total Compute platform Usama Arif
2020-08-12 12:40 ` Tom Rini
2020-08-12 14:12 ` Usama Arif [this message]
2020-08-12 14:45 ` [PATCH 1/2] avb: Make AVB independent of fastboot Tom Rini
2020-08-12 16:22 ` Igor Opaniuk
2020-08-25 12:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dfac560-c863-c3be-b3fc-f69c497fc690@arm.com \
--to=usama.arif@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.