From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 18 Mar 2018 22:49:57 +0100
Subject: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI
In-Reply-To: <20180318212145.ooob54c7awuk5lqq@flea>
References: <20180314093934.2lxjqhpiahugjwsc@flea>
 <20180318152006.5303-1-xypron.glpk@gmx.de>
 <20180318212145.ooob54c7awuk5lqq@flea>
Message-ID: <0dfeb2f0-3977-4836-2b07-056faac2d4e4@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/18/2018 10:21 PM, Maxime Ripard wrote:
> Hi,
> 
> On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote:
>> doc/driver-model/MIGRATION.txt requires to move block drivers to the
>> the driver model by v2018.05
>>
>> So make the switch for the SUNXI block drivers.
>>
>> Select BLK, DM_MMC, and DM_SCSI.
>>
>> DM_USB dpends on USB but there is no necessity to make it depend on
>> DISTRO_DEFAULTS.
> 
> That should be a separate patch.
> 
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>  arch/arm/Kconfig | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 2c52ff025a..b608f01beb 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -715,13 +715,16 @@ config ARCH_SUNXI
>>  	select BINMAN
>>  	select CMD_GPIO
>>  	select CMD_MMC if MMC
>> -	select CMD_USB if DISTRO_DEFAULTS
>> +	select CMD_USB if USB
>>  	select DM
>> +	select BLK
> 
> You assume here that you always have a block device, which might not
> be the case (for example if you only have a NAND chip on your board).
I ran a full Travis test for Sunxi boards and could not see any compile
error only a time out for one group of boards.

BLK is used by #ifdefs in code handling block devices. It has no effect
if the block device code is not built.

> 
>>  	select DM_ETH

Here you already select DM_ETH without requiring network. It simply has
not effect if there is not network driver built.

>>  	select DM_GPIO
>>  	select DM_KEYBOARD
>> +	select DM_MMC
> 
> Ditto.

DM_MMC only depends on DM not on MMC see drivers/mmc/Kconfig
If you don't build MMC code it has no effect.

> 
>> +	select DM_SCSI
> 
> 
> Ditto, with SATA.

If you don't build SCSI or ATA code the flag has no effect.

Regards

Heinrich