From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] kernel-shark-qt: Define Data collections
Date: Mon, 6 Aug 2018 19:08:13 +0300 [thread overview]
Message-ID: <0e0742a9-c594-f2e6-f7c1-7a82b00dd50d@gmail.com> (raw)
In-Reply-To: <20180803222731.4e47e97f@vmware.local.home>
Hi Steven,
On 4.08.2018 05:27, Steven Rostedt wrote:
>> +static struct kshark_entry_collection *
>> +kshark_data_collection_alloc(struct kshark_context *kshark_ctx,
>> + struct kshark_entry **data,
>> + size_t first,
>> + size_t n_rows,
>> + matching_condition_func cond,
>> + int val,
>> + size_t margin)
> What exactly is margin used for?
>
The margin allows the user to inflate each of the interval, by appending
additional data which do not satisfy the matching condition. This data
is added to each interval at the beginning and at the end of the data
which satisfies the condition, as well as at the beginning and at the
end of data-set. The margin data can be useful in the case when the user
wants to be able to see what is happening before and after the
appearance of his data of interest.
Thanks!
Yordan
next prev parent reply other threads:[~2018-08-06 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 14:29 [PATCH v3 0/6] Add visualization model for the Qt-based KernelShark Yordan Karadzhov (VMware)
2018-08-03 14:29 ` [PATCH v3 1/6] kernel-shark-qt: Add generic instruments for searching inside the trace data Yordan Karadzhov (VMware)
2018-08-03 14:29 ` [PATCH v3 2/6] kernel-shark-qt: Introduce the visualization model used by the Qt-based KS Yordan Karadzhov (VMware)
2018-08-03 18:43 ` Steven Rostedt
2018-08-03 21:48 ` Steven Rostedt
2018-08-06 14:24 ` Yordan Karadzhov (VMware)
2018-08-03 14:29 ` [PATCH v3 3/6] kernel-shark-qt: Add an example showing how to manipulate the Vis. model Yordan Karadzhov (VMware)
2018-08-03 14:29 ` [PATCH v3 4/6] kernel-shark-qt: Define Data collections Yordan Karadzhov (VMware)
2018-08-04 2:27 ` Steven Rostedt
2018-08-06 16:08 ` Yordan Karadzhov (VMware) [this message]
2018-08-03 14:29 ` [PATCH v3 5/6] kernel-shark-qt: Make the Vis. model use " Yordan Karadzhov (VMware)
2018-08-03 14:29 ` [PATCH v3 6/6] kernel-shark-qt: Changed the KernelShark version identifier Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e0742a9-c594-f2e6-f7c1-7a82b00dd50d@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.