From: "René Scharfe" <l.s.r@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Emily Shaffer <emilyshaffer@google.com>,
Jeff King <peff@peff.net>,
Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v2 8/8] hook-list.h: add a generated list of hooks, like config-list.h
Date: Mon, 27 Sep 2021 20:00:49 +0200 [thread overview]
Message-ID: <0e07cee4-079a-af12-880f-d4a99300df28@web.de> (raw)
In-Reply-To: <xmqqfstqq80j.fsf@gitster.g>
Am 27.09.21 um 18:48 schrieb Junio C Hamano:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> +sed -n \
>> + -e '/^~~~~*$/ {x; s/^.*$/ "&",/; p;}' \
>> + -e 'x' \
>> + <Documentation/githooks.txt |
>> + LC_ALL=C sort
>
> Thanks. It is not wrong per-se, but if you are willing to do a
> multi-line script for readability, wouldn't a much more readable
> "single long and multi-line string" approach, i.e.
>
> sed -ne '
> /^~~~~*$/ {
> x
> s/^.*$/ "&",/
> p
> }
> x
> ' Documentation/githooks.txt |
> LC_ALL=C sort
>
> work better?
>
It is more readable, but according to OpenBSD's sed(1) manpage it would
also be non-portable (https://man.openbsd.org/sed#STANDARDS). That note
was added in 2006 (https://github.com/openbsd/src/commit/24ce9718),
though, so perhaps it needs an update.
FWIW, generate-cmdlist.sh uses such a multi-line sed script in its
function get_synopsis.
René
next prev parent reply other threads:[~2021-09-27 18:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 10:29 [PATCH 0/8] Makefile: generate a hook-list.h, prep for config-based-hooks Ævar Arnfjörð Bjarmason
2021-09-23 10:29 ` [PATCH 1/8] Makefile: mark "check" target as .PHONY Ævar Arnfjörð Bjarmason
2021-09-23 10:29 ` [PATCH 2/8] Makefile: stop hardcoding {command,config}-list.h Ævar Arnfjörð Bjarmason
2021-09-23 10:29 ` [PATCH 3/8] Makefile: don't perform "mv $@+ $@" dance for $(GENERATED_H) Ævar Arnfjörð Bjarmason
2021-09-23 10:29 ` [PATCH 4/8] Makefile: remove an out-of-date comment Ævar Arnfjörð Bjarmason
2021-09-23 10:30 ` [PATCH 5/8] hook.[ch]: move find_hook() from run-command.c to hook.c Ævar Arnfjörð Bjarmason
2021-09-23 10:30 ` [PATCH 6/8] hook.c: add a hook_exists() wrapper and use it in bugreport.c Ævar Arnfjörð Bjarmason
2021-09-23 10:30 ` [PATCH 7/8] hook.c users: use "hook_exists()" instead of "find_hook()" Ævar Arnfjörð Bjarmason
2021-09-23 10:30 ` [PATCH 8/8] hook-list.h: add a generated list of hooks, like config-list.h Ævar Arnfjörð Bjarmason
2021-09-24 10:19 ` Phillip Wood
2021-09-24 15:51 ` Junio C Hamano
2021-09-24 16:39 ` René Scharfe
2021-09-24 19:30 ` Ævar Arnfjörð Bjarmason
2021-09-24 19:56 ` René Scharfe
2021-09-24 20:09 ` Ævar Arnfjörð Bjarmason
2021-09-27 9:24 ` Phillip Wood
2021-09-27 10:36 ` Ævar Arnfjörð Bjarmason
2021-11-15 22:04 ` Mike Hommey
2021-11-15 22:26 ` Ævar Arnfjörð Bjarmason
2021-11-15 22:40 ` Mike Hommey
2021-11-15 22:49 ` Ævar Arnfjörð Bjarmason
2021-11-15 23:00 ` Mike Hommey
2021-11-16 12:01 ` Ævar Arnfjörð Bjarmason
2021-11-17 8:39 ` Junio C Hamano
2021-09-26 19:03 ` [PATCH v2 0/8] Makefile: generate a hook-list.h, prep for config-based-hooks Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 1/8] Makefile: mark "check" target as .PHONY Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 2/8] Makefile: stop hardcoding {command,config}-list.h Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 3/8] Makefile: don't perform "mv $@+ $@" dance for $(GENERATED_H) Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 4/8] Makefile: remove an out-of-date comment Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 5/8] hook.[ch]: move find_hook() from run-command.c to hook.c Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 6/8] hook.c: add a hook_exists() wrapper and use it in bugreport.c Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 7/8] hook.c users: use "hook_exists()" instead of "find_hook()" Ævar Arnfjörð Bjarmason
2021-09-26 19:03 ` [PATCH v2 8/8] hook-list.h: add a generated list of hooks, like config-list.h Ævar Arnfjörð Bjarmason
2021-09-27 16:48 ` Junio C Hamano
2021-09-27 18:00 ` René Scharfe [this message]
2021-09-27 20:23 ` Junio C Hamano
2021-09-27 9:30 ` [PATCH v2 0/8] Makefile: generate a hook-list.h, prep for config-based-hooks Phillip Wood
2021-09-27 10:38 ` Ævar Arnfjörð Bjarmason
2021-09-27 18:01 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e07cee4-079a-af12-880f-d4a99300df28@web.de \
--to=l.s.r@web.de \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.