From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bK7MV-00044l-LC
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 13:08:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bK7MT-0006Mw-Kr
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 13:08:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bK7MT-0006Ml-El
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 13:08:45 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2801F81F07
	for <qemu-devel@nongnu.org>; Mon,  4 Jul 2016 17:08:45 +0000 (UTC)
References: <20160704153823.16879-1-marcandre.lureau@redhat.com>
	<20160704163139.GM3763@redhat.com>
	<c9b53fb3-d7da-11d8-6af3-0ef163140584@redhat.com>
	<20160704170715.GO3763@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <0e0b3d90-24c2-519f-7b08-2b1174b35dc9@redhat.com>
Date: Mon, 4 Jul 2016 19:08:41 +0200
MIME-Version: 1.0
In-Reply-To: <20160704170715.GO3763@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] char: do not use atexit cleanup handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>



On 04/07/2016 19:07, Daniel P. Berrange wrote:
> > At this point you have stopped all CPUs and block devices.  There is =
not
> > much else that is going on in QEMU at all, at this point.  The soluti=
on
> > would be to stop those threads.
>
> What about graphics threads ? In particular I'd be thinking of spice
> which uses threads and chardevs.

I think it should be quiesced after pause_all_vcpus returns.  Marc-Andr=C3=
=A9
should know, but it's better to check with Gerd.

(FWIW, it's not so easy to shut down the threads because for example
some threads might belong to non-hotunpluggable devices).

Paolo