From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE99EC433F5 for ; Fri, 17 Dec 2021 13:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232807AbhLQNaN (ORCPT ); Fri, 17 Dec 2021 08:30:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhLQNaK (ORCPT ); Fri, 17 Dec 2021 08:30:10 -0500 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82B95C061574 for ; Fri, 17 Dec 2021 05:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vDy/h/0IhDpG31/AHmcO9oajllR8KeNpEmxogpr82bE=; b=zP3lDawS9GQKm7r2TbZtiC/xvn QuC2H7RI0Nn9Tzfqeaa6b4Sfz5r333CB0bPLcqj4yowfp2IbEabWUezuybyeiHXzTgmc5KfA714ET bA9zH0VExtR8i+e1PWACv/lyqsVTGhVXalfOFPghNeBS2bgwiE+G7Q4iQfV8c5UWuFDJdpRI9xLIZ M3KTvgcjiaqbc5QrFEnBZfWD85DgqAD79SF3CGcoOhomNUkDKwcVswyAKKzszaQg1pFU8ucAyz+WJ 0K6v2r4JV4JHSa6+D/KuqsYK7En0l3+THQgMRpxP963wuHkOLP2p7ldZEqkshywZQportfoz5z2N+ TsL6O9Vg==; Received: from webng-gw.kapsi.fi ([91.232.154.200] helo=roundcube.kapsi.fi) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1myDJE-00011F-Ux; Fri, 17 Dec 2021 15:30:04 +0200 MIME-Version: 1.0 Date: Fri, 17 Dec 2021 15:30:02 +0200 From: Jyri Sarha To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen Subject: Re: [PATCH v2 36/37] drm/tilcdc: Add support for the nomodeset kernel parameter In-Reply-To: <20211217003752.3946210-37-javierm@redhat.com> References: <20211217003752.3946210-1-javierm@redhat.com> <20211217003752.3946210-37-javierm@redhat.com> Message-ID: <0e12f51baaf76b9863b4ab11fdb86af6@iki.fi> X-Sender: jyri.sarha@iki.fi Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 91.232.154.200 X-SA-Exim-Mail-From: jyri.sarha@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-12-17 2:37, Javier Martinez Canillas wrote: > According to disable Documentation/admin-guide/kernel-parameters.txt, > this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated > rendering > and only the system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this > driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas Acked-by: Jyri Sarha > --- > > (no changes since v1) > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index cc567c87057d..eee3c447fbac 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -604,6 +604,9 @@ static struct platform_driver > tilcdc_platform_driver = { > > static int __init tilcdc_drm_init(void) > { > + if (drm_firmware_drivers_only()) > + return -ENODEV; > + > DBG("init"); > tilcdc_panel_init(); > return platform_driver_register(&tilcdc_platform_driver); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A78BEC433EF for ; Fri, 17 Dec 2021 13:30:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5EE910FB4F; Fri, 17 Dec 2021 13:30:14 +0000 (UTC) Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 995D310FB5E for ; Fri, 17 Dec 2021 13:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vDy/h/0IhDpG31/AHmcO9oajllR8KeNpEmxogpr82bE=; b=zP3lDawS9GQKm7r2TbZtiC/xvn QuC2H7RI0Nn9Tzfqeaa6b4Sfz5r333CB0bPLcqj4yowfp2IbEabWUezuybyeiHXzTgmc5KfA714ET bA9zH0VExtR8i+e1PWACv/lyqsVTGhVXalfOFPghNeBS2bgwiE+G7Q4iQfV8c5UWuFDJdpRI9xLIZ M3KTvgcjiaqbc5QrFEnBZfWD85DgqAD79SF3CGcoOhomNUkDKwcVswyAKKzszaQg1pFU8ucAyz+WJ 0K6v2r4JV4JHSa6+D/KuqsYK7En0l3+THQgMRpxP963wuHkOLP2p7ldZEqkshywZQportfoz5z2N+ TsL6O9Vg==; Received: from webng-gw.kapsi.fi ([91.232.154.200] helo=roundcube.kapsi.fi) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1myDJE-00011F-Ux; Fri, 17 Dec 2021 15:30:04 +0200 MIME-Version: 1.0 Date: Fri, 17 Dec 2021 15:30:02 +0200 From: Jyri Sarha To: Javier Martinez Canillas Subject: Re: [PATCH v2 36/37] drm/tilcdc: Add support for the nomodeset kernel parameter In-Reply-To: <20211217003752.3946210-37-javierm@redhat.com> References: <20211217003752.3946210-1-javierm@redhat.com> <20211217003752.3946210-37-javierm@redhat.com> Message-ID: <0e12f51baaf76b9863b4ab11fdb86af6@iki.fi> X-Sender: jyri.sarha@iki.fi Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 91.232.154.200 X-SA-Exim-Mail-From: jyri.sarha@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-12-17 2:37, Javier Martinez Canillas wrote: > According to disable Documentation/admin-guide/kernel-parameters.txt, > this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated > rendering > and only the system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this > driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas Acked-by: Jyri Sarha > --- > > (no changes since v1) > > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index cc567c87057d..eee3c447fbac 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -604,6 +604,9 @@ static struct platform_driver > tilcdc_platform_driver = { > > static int __init tilcdc_drm_init(void) > { > + if (drm_firmware_drivers_only()) > + return -ENODEV; > + > DBG("init"); > tilcdc_panel_init(); > return platform_driver_register(&tilcdc_platform_driver);