From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Paul Blakey <paulb@nvidia.com>,
dev@openvswitch.org, netdev@vger.kernel.org,
Cong Wang <xiyou.wangcong@gmail.com>,
Pravin B Shelar <pshelar@ovn.org>,
davem@davemloft.net, Jiri Pirko <jiri@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Oz Shlomo <ozsh@nvidia.com>,
Vlad Buslov <vladbu@nvidia.com>, Roi Dayan <roid@nvidia.com>
Subject: Re: [PATCH net-next v2 1/1] net/sched: Enable tc skb ext allocation on chain miss only when needed
Date: Tue, 1 Feb 2022 18:18:29 -0500 [thread overview]
Message-ID: <0e202f7c-0558-6050-54c9-e1e28b1bfaa3@mojatatu.com> (raw)
In-Reply-To: <20220201175220.7680-1-paulb@nvidia.com>
On 2022-02-01 12:52, Paul Blakey wrote:
> Tc skb extension is used to send miss info from tc to ovs datapath
> module, and is currently always allocated even if it will not
> be used by ovs datapath (as it depends on a requested feature).
>
> Export the static key which is used by openvswitch module to
> guard this code path as well, so it will be skipped if ovs
> datapath doesn't need it. Enable this code path once
> ovs datapath needs it.
Why the name tc_skb_ext_tc_ovs_XXX? This is a generic feature
which could be used for other purposes within tc and outside
of ovs. Suggestion to rename to tc_skb_ext_tc_XXX
cheers,
jamal
prev parent reply other threads:[~2022-02-01 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 17:52 [PATCH net-next v2 1/1] net/sched: Enable tc skb ext allocation on chain miss only when needed Paul Blakey
2022-02-01 23:18 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e202f7c-0558-6050-54c9-e1e28b1bfaa3@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=paulb@nvidia.com \
--cc=pshelar@ovn.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.