From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fsimonce@redhat.com>) id 1S0bNr-0004sN-BE
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:19:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fsimonce@redhat.com>) id 1S0bNg-0000dY-Ey
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:19:05 -0500
Received: from mx3-phx2.redhat.com ([209.132.183.24]:46629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fsimonce@redhat.com>) id 1S0bNg-0000dK-6m
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 11:18:56 -0500
Date: Thu, 23 Feb 2012 11:18:54 -0500 (EST)
From: Federico Simoncelli <fsimonce@redhat.com>
Message-ID: <0e51b1bc-c21a-4868-aac1-4ccf6ce0c662@zmail16.collab.prod.int.phx2.redhat.com>
In-Reply-To: <CAJSP0QWqXYsE3dUm2k_OqQaXoZMd2LggTA3saBABxuW61ajtFA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org

----- Original Message -----
> From: "Stefan Hajnoczi" <stefanha@gmail.com>
> To: "Federico Simoncelli" <fsimonce@redhat.com>
> Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mtosatti@redhat.com
> Sent: Thursday, February 23, 2012 5:14:09 PM
> Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
> 
> On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli
> <fsimonce@redhat.com> wrote:
> > From: Marcelo Tosatti <mtosatti@redhat.com>
> >
> > Mirrored writes are used by live block copy.
> 
> I think the right approach is to create a single blkmirror driver
> that
> also includes blkverify functionality.  The code is basically the
> same
> except blkverify also compares reads - just use a flag to
> enable/disable that behavior.
> 
> Feel free to rename the blkverify driver to blkmirror if you wish.
> 
> By the way, this code does not build against qemu.git/master.  It
> uses
> interfaces which have been dropped.

Yes you also need:

[PATCH 2/3] Update the blkmirror block driver

Which was sent separately to facilitate the review for people who
already reviewed this.

-- 
Federico