From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 2/2] xen/spinlocks: fix placement of preempt_[dis|en]able()
Date: Fri, 13 Mar 2020 09:55:08 +0100 [thread overview]
Message-ID: <0e56d8d5-a66f-1990-faf2-488f1f07ae93@suse.com> (raw)
In-Reply-To: <20200313080517.28728-3-jgross@suse.com>
On 13.03.2020 09:05, Juergen Gross wrote:
> @@ -199,10 +199,10 @@ unsigned long _spin_lock_irqsave(spinlock_t *lock)
> void _spin_unlock(spinlock_t *lock)
> {
> arch_lock_release_barrier();
> - preempt_enable();
> LOCK_PROFILE_REL;
> rel_lock(&lock->debug);
> add_sized(&lock->tickets.head, 1);
> + preempt_enable();
> arch_lock_signal();
> }
arch_lock_signal() is a barrier on Arm, hence just like for patch 1
I wonder whether the insertion wouldn't better come after it.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-13 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 8:05 [Xen-devel] [PATCH 0/2] xen/locks: fix preempt disabling in lock handling Juergen Gross
2020-03-13 8:05 ` [Xen-devel] [PATCH 1/2] xen/rwlocks: call preempt_disable() when taking a rwlock Juergen Gross
2020-03-13 8:48 ` Jan Beulich
2020-03-13 10:02 ` Julien Grall
2020-03-13 10:02 ` Julien Grall
2020-03-13 10:15 ` Jürgen Groß
2020-03-13 10:31 ` Jan Beulich
2020-03-13 10:40 ` Julien Grall
2020-03-13 11:23 ` Jürgen Groß
2020-03-13 11:39 ` Julien Grall
2020-03-13 12:05 ` Jürgen Groß
2020-03-13 8:05 ` [Xen-devel] [PATCH 2/2] xen/spinlocks: fix placement of preempt_[dis|en]able() Juergen Gross
2020-03-13 8:55 ` Jan Beulich [this message]
2020-03-13 9:00 ` Jürgen Groß
2020-03-13 9:44 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e56d8d5-a66f-1990-faf2-488f1f07ae93@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.