From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEF6CA9EC2 for ; Mon, 28 Oct 2019 11:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E840E214D9 for ; Mon, 28 Oct 2019 11:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388529AbfJ1Liq (ORCPT ); Mon, 28 Oct 2019 07:38:46 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:40042 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbfJ1Liq (ORCPT ); Mon, 28 Oct 2019 07:38:46 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.2) (envelope-from ) id 1iP3Lz-0002Q7-6E; Mon, 28 Oct 2019 12:38:31 +0100 Message-ID: <0e6c13812faa01026b55d64c1af500eda048b759.camel@sipsolutions.net> Subject: Re: pull-request: mac80211-next 2019-07-31 From: Johannes Berg To: Arnd Bergmann Cc: David Miller , Networking , linux-wireless , John Crispin Date: Mon, 28 Oct 2019 12:38:29 +0100 In-Reply-To: (sfid-20191028_120835_987215_F3E3F93B) References: <20190731155057.23035-1-johannes@sipsolutions.net> <2f64367daad256b1f1999797786763fa8091faa1.camel@sipsolutions.net> (sfid-20191028_120835_987215_F3E3F93B) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2019-10-28 at 12:08 +0100, Johannes Berg wrote: > On Mon, 2019-10-28 at 11:53 +0100, Arnd Bergmann wrote: > > > Why do you say 32-bit btw, it should be *bigger* on 64-bit, but I didn't > > > see this ... hmm. > > > > That is correct. For historic reasons, both the total amount of stack space > > per thread and the warning limit on 64 bit are twice the amount that we > > have on 32-bit kernels, so even though the problem is more serious on > > 64-bit architectures, we do not see a warning about it because we remain > > well under the warning limit. > > Hmm, but I have: > > CONFIG_FRAME_WARN=1024 > > in my compilation But the compiler decides not to inline it, for whatever reason. Only if I mark it as __always_inline, does it actually inline it. But it does seem to merge the storage, if I inline only assoc_success() I get 888 bytes (after the fix), if I inline also ieee80211_rx_mgmt_assoc_resp() then I get 904 bytes. johannes