From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1E30C433EF for ; Wed, 6 Apr 2022 10:51:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 15B7410E5E9; Wed, 6 Apr 2022 10:51:41 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B4D410E5E9 for ; Wed, 6 Apr 2022 10:51:39 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 5357A1F40EEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649242298; bh=au3kCGpBvELGj1O6aCEDgSZw3PDmNnTwCgo2ZapgbJY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k8lcVf8I9OjzL+Yob0GKMFrCpB3OMWOSdFSJ1vEdCc/3LPY7XhF7g1KGHrHyO7+Je akVMl7CsoT5V5aCZINzeQhUH3RmtO9hQyQdMsksPUFuULZiaZVd7i/CI08Yx0999Qc uKMhT0MPfHPsCxFNq3wbodLtSinV4mCnKSe+cwWmSz1Bi9RAIMl5ZoguOabgGmDeoM W2tiM8+ihWlLanFyMB1oKFA3yGBon14UGi/jwC7d12ikEczIYrXo8dHHsAA2tPDWtP zpSLlIDK0j0/ObDa8X5bXKRqjWkuXUbN+HivTzFDsR7F2AgbuzmpX2TksYqkyRS0Na bv7dX0vBwdH1Q== Message-ID: <0e6d110d-0637-2be8-cab0-9d936668fa7b@collabora.com> Date: Wed, 6 Apr 2022 12:51:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192 Content-Language: en-US To: Rex-BC Chen , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-4-rex-bc.chen@mediatek.com> <2449070b-d7e1-122f-abe6-4148855a9aba@collabora.com> <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "airlied@linux.ie" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsyk=?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 06/04/22 12:48, Rex-BC Chen ha scritto: > On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: >> Il 06/04/22 11:46, Rex-BC Chen ha scritto: >>> The driver data for MT8192 is the same with MT8183. Therefore, we >>> correct it. >>> >>> Signed-off-by: Rex-BC Chen >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> >> ...though, from what I know, you should also move MT8195 down there! > > Hello Angelo, > > Thanks for your review. > But for MT8195, disp_aal is using the same compatible with MT8173. > > From the MT8195 project DTS is using: > > aal0: disp_aal@1c005000 { > compatible = "mediatek,mt8195-disp-aal", > "mediatek,mt8173-disp-aal"; > reg = <0 0x1c005000 0 0x1000>; > interrupts = ; > power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; > clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>; > mediatek,gce-client-reg = > <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; > }; > > BRs, > Rex > I'm sorry Rex, I've just realized - I was confusing this one with the 8195 gamma binding instead! Cheers, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4039C433FE for ; Wed, 6 Apr 2022 10:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y63ta8epEMK0xlL0bsxScicdwLkB/9k/Jsi/k5Ox9vc=; b=JGwqGMpd3KP1Zg hiqUannhzoQa2hvfRiTjtNpc6cXTdSwsL3MearH7PHy4tqLrS11UF5xHPjUhsOVEXpDJ5NcLMcy5/ mVZVg6rj8ho3EP3sNx9q3K/IZAOl14PtOrqExiq1N5cmg9/C/PH7ZYkDzVQW4dRUd2TGzt4yY9boO TdAe2gp9wiCqDiAzi0R8eM32w8ytRA0ZWPLRoBe5u47hkRU08Vjajg7E+hUYs66uY3SwZTkYRXr7q 598yDmixr7H0ciTw+twb7joInCbPjfAT8C+pDJM6OfEm1lw+Zdgb2pj02LI+WRhIhyiVcMYGpMhAy 6eocMZTn9CqkomJ5oHyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc3Iy-005Zlb-Hc; Wed, 06 Apr 2022 10:54:28 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc3GF-005YCM-Oi; Wed, 06 Apr 2022 10:51:41 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 5357A1F40EEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649242298; bh=au3kCGpBvELGj1O6aCEDgSZw3PDmNnTwCgo2ZapgbJY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k8lcVf8I9OjzL+Yob0GKMFrCpB3OMWOSdFSJ1vEdCc/3LPY7XhF7g1KGHrHyO7+Je akVMl7CsoT5V5aCZINzeQhUH3RmtO9hQyQdMsksPUFuULZiaZVd7i/CI08Yx0999Qc uKMhT0MPfHPsCxFNq3wbodLtSinV4mCnKSe+cwWmSz1Bi9RAIMl5ZoguOabgGmDeoM W2tiM8+ihWlLanFyMB1oKFA3yGBon14UGi/jwC7d12ikEczIYrXo8dHHsAA2tPDWtP zpSLlIDK0j0/ObDa8X5bXKRqjWkuXUbN+HivTzFDsR7F2AgbuzmpX2TksYqkyRS0Na bv7dX0vBwdH1Q== Message-ID: <0e6d110d-0637-2be8-cab0-9d936668fa7b@collabora.com> Date: Wed, 6 Apr 2022 12:51:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192 Content-Language: en-US To: Rex-BC Chen , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" Cc: "matthias.bgg@gmail.com" , "p.zabel@pengutronix.de" , "airlied@linux.ie" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsyk=?= , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-4-rex-bc.chen@mediatek.com> <2449070b-d7e1-122f-abe6-4148855a9aba@collabora.com> <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_035140_037217_E8922390 X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 06/04/22 12:48, Rex-BC Chen ha scritto: > On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: >> Il 06/04/22 11:46, Rex-BC Chen ha scritto: >>> The driver data for MT8192 is the same with MT8183. Therefore, we >>> correct it. >>> >>> Signed-off-by: Rex-BC Chen >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> >> ...though, from what I know, you should also move MT8195 down there! > > Hello Angelo, > > Thanks for your review. > But for MT8195, disp_aal is using the same compatible with MT8173. > > From the MT8195 project DTS is using: > > aal0: disp_aal@1c005000 { > compatible = "mediatek,mt8195-disp-aal", > "mediatek,mt8173-disp-aal"; > reg = <0 0x1c005000 0 0x1000>; > interrupts = ; > power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; > clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>; > mediatek,gce-client-reg = > <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; > }; > > BRs, > Rex > I'm sorry Rex, I've just realized - I was confusing this one with the 8195 gamma binding instead! Cheers, Angelo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C5DDC433F5 for ; Wed, 6 Apr 2022 10:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=woWrPibAaFj7N5mXrd6talBjWX5gpbR3KdztxQBJvNQ=; b=P9QdQdw4KUhVXA YUiR8VDZ0R/qyAzWMs5yjLwIPIAAkzw6YoyHWQovGK2dXKexm2qR37QuYFce30P8NIrRXTezjw2bi 4uv5u9sdW9qDiqVlTQ5R0DJmvzCxC5NXGKrU61faVkamVVj3gHDDLaYj+PQm69gpGDL0tEYOgKiZ3 3XWmrK0YRyTGVrwZa/7ktoUC2ly3l1P/HwpiFXNzNfu6pNFfyqYqA4mzpa9i7GKrbIYsWzxSjlL+K 3HLqWG8Yu0xelRIek7tJFVltYvqa+37DsvFITbV1tjNyiXBV0n/780PSi3Sc9HXRmcl3DGm6Wr7s6 Xq335T0mvAOd2SCgkx2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc3IV-005ZUF-3l; Wed, 06 Apr 2022 10:53:59 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc3GF-005YCM-Oi; Wed, 06 Apr 2022 10:51:41 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 5357A1F40EEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649242298; bh=au3kCGpBvELGj1O6aCEDgSZw3PDmNnTwCgo2ZapgbJY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k8lcVf8I9OjzL+Yob0GKMFrCpB3OMWOSdFSJ1vEdCc/3LPY7XhF7g1KGHrHyO7+Je akVMl7CsoT5V5aCZINzeQhUH3RmtO9hQyQdMsksPUFuULZiaZVd7i/CI08Yx0999Qc uKMhT0MPfHPsCxFNq3wbodLtSinV4mCnKSe+cwWmSz1Bi9RAIMl5ZoguOabgGmDeoM W2tiM8+ihWlLanFyMB1oKFA3yGBon14UGi/jwC7d12ikEczIYrXo8dHHsAA2tPDWtP zpSLlIDK0j0/ObDa8X5bXKRqjWkuXUbN+HivTzFDsR7F2AgbuzmpX2TksYqkyRS0Na bv7dX0vBwdH1Q== Message-ID: <0e6d110d-0637-2be8-cab0-9d936668fa7b@collabora.com> Date: Wed, 6 Apr 2022 12:51:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192 Content-Language: en-US To: Rex-BC Chen , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" Cc: "matthias.bgg@gmail.com" , "p.zabel@pengutronix.de" , "airlied@linux.ie" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsyk=?= , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-4-rex-bc.chen@mediatek.com> <2449070b-d7e1-122f-abe6-4148855a9aba@collabora.com> <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_035140_037217_E8922390 X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 06/04/22 12:48, Rex-BC Chen ha scritto: > On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: >> Il 06/04/22 11:46, Rex-BC Chen ha scritto: >>> The driver data for MT8192 is the same with MT8183. Therefore, we >>> correct it. >>> >>> Signed-off-by: Rex-BC Chen >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> >> ...though, from what I know, you should also move MT8195 down there! > > Hello Angelo, > > Thanks for your review. > But for MT8195, disp_aal is using the same compatible with MT8173. > > From the MT8195 project DTS is using: > > aal0: disp_aal@1c005000 { > compatible = "mediatek,mt8195-disp-aal", > "mediatek,mt8173-disp-aal"; > reg = <0 0x1c005000 0 0x1000>; > interrupts = ; > power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; > clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>; > mediatek,gce-client-reg = > <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; > }; > > BRs, > Rex > I'm sorry Rex, I've just realized - I was confusing this one with the 8195 gamma binding instead! Cheers, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA2AC433F5 for ; Wed, 6 Apr 2022 13:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233428AbiDFNo0 (ORCPT ); Wed, 6 Apr 2022 09:44:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233598AbiDFNoP (ORCPT ); Wed, 6 Apr 2022 09:44:15 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65F9E6B07F6; Wed, 6 Apr 2022 03:51:40 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 5357A1F40EEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649242298; bh=au3kCGpBvELGj1O6aCEDgSZw3PDmNnTwCgo2ZapgbJY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k8lcVf8I9OjzL+Yob0GKMFrCpB3OMWOSdFSJ1vEdCc/3LPY7XhF7g1KGHrHyO7+Je akVMl7CsoT5V5aCZINzeQhUH3RmtO9hQyQdMsksPUFuULZiaZVd7i/CI08Yx0999Qc uKMhT0MPfHPsCxFNq3wbodLtSinV4mCnKSe+cwWmSz1Bi9RAIMl5ZoguOabgGmDeoM W2tiM8+ihWlLanFyMB1oKFA3yGBon14UGi/jwC7d12ikEczIYrXo8dHHsAA2tPDWtP zpSLlIDK0j0/ObDa8X5bXKRqjWkuXUbN+HivTzFDsR7F2AgbuzmpX2TksYqkyRS0Na bv7dX0vBwdH1Q== Message-ID: <0e6d110d-0637-2be8-cab0-9d936668fa7b@collabora.com> Date: Wed, 6 Apr 2022 12:51:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 3/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8192 Content-Language: en-US To: Rex-BC Chen , "chunkuang.hu@kernel.org" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" Cc: "matthias.bgg@gmail.com" , "p.zabel@pengutronix.de" , "airlied@linux.ie" , =?UTF-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsyk=?= , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Project_Global_Chrome_Upstream_Group References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-4-rex-bc.chen@mediatek.com> <2449070b-d7e1-122f-abe6-4148855a9aba@collabora.com> <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <4ed2dc24d600fa73b91bb411391c98a5bf4f8d8b.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/04/22 12:48, Rex-BC Chen ha scritto: > On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: >> Il 06/04/22 11:46, Rex-BC Chen ha scritto: >>> The driver data for MT8192 is the same with MT8183. Therefore, we >>> correct it. >>> >>> Signed-off-by: Rex-BC Chen >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> >> ...though, from what I know, you should also move MT8195 down there! > > Hello Angelo, > > Thanks for your review. > But for MT8195, disp_aal is using the same compatible with MT8173. > > From the MT8195 project DTS is using: > > aal0: disp_aal@1c005000 { > compatible = "mediatek,mt8195-disp-aal", > "mediatek,mt8173-disp-aal"; > reg = <0 0x1c005000 0 0x1000>; > interrupts = ; > power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; > clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>; > mediatek,gce-client-reg = > <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; > }; > > BRs, > Rex > I'm sorry Rex, I've just realized - I was confusing this one with the 8195 gamma binding instead! Cheers, Angelo