From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id C98C8E00AA6; Tue, 12 Jan 2016 03:28:42 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,UC_GIBBERISH_OBFU autolearn=no version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [195.74.38.228 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message * 1.0 UC_GIBBERISH_OBFU Multiple instances of "word VERYLONGGIBBERISH * word" Received: from bin-vsp-out-01.atm.binero.net (bin-mail-out-05.binero.net [195.74.38.228]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id A477FE00A27 for ; Tue, 12 Jan 2016 03:28:38 -0800 (PST) X-Halon-ID: b4494b60-b91f-11e5-aee3-005056917a89 Authorized-sender: petter@technux.se Received: from webmail.binero.se (unknown [195.74.38.9]) by bin-vsp-out-01.atm.binero.net (Halon Mail Gateway) with ESMTPA; Tue, 12 Jan 2016 12:29:12 +0100 (CET) MIME-Version: 1.0 Date: Tue, 12 Jan 2016 12:28:33 +0100 From: =?UTF-8?Q?Petter_Mab=C3=A4cker?= To: Khem Raj , Andrei Gherzan Organization: Technux Mail-Reply-To: In-Reply-To: References: <1452530987-994-1-git-send-email-petter@technux.se> <1452530987-994-5-git-send-email-petter@technux.se> <7564A308-E4D5-4B05-B03A-95A2B37A5F59@gmail.com> <20160111203227.GA10203@resin> <6e08071c20fb36e6744479e96267006c@technux.se> Message-ID: <0e6fb4e5bfd3260422ebc9c2016430bb@technux.se> X-Sender: petter@technux.se User-Agent: Binero Webmail/0.8.4 Cc: yocto@yoctoproject.org Subject: Re: [meta-raspberrypi][PATCH 4/5] pitft: Add basic support for PiTFT X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: petter@technux.se List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 11:28:42 -0000 Content-Type: multipart/alternative; boundary="=_9ba902eadfec638e75b999f541b220cc" --=_9ba902eadfec638e75b999f541b220cc Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 2016-01-12 09:45 skrev Khem Raj: > On Mon, Jan 11, 2016 at 10:51 PM, Petter Mabäcker wrote: > >> 2016-01-11 21:32 skrev Andrei Gherzan: On Mon, Jan 11, 2016 at 09:55:43AM -0800, Khem Raj wrote: On Jan 11, 2016, at 8:49 AM, Petter Mabäcker wrote: Add basic support for PiTFT display by using device-trees. In order get it working below configurations must be active in local.conf: MACHINEOVERRIDES .= ":pitft" Using MACHINE_FEATURES will be more appropriate term. Effects are same. Indeed. I support MACHINE_FEATURE usage here. I agree that the term MACHINE_FEATURES is better. However since MACHINE_FEATURES isn't included in the OVERRIDES variable I will not be able to use the task pre/appends that was the reason I used MACHINEOVERRIDES in the first place. The reason I want to use overrides in this case is since I think it makes the code easier to read and understand for the user (in this particular case at least). I can of course change to just using variables (like in many other optional features in meta-raspberrypi) or change to MACHINE_FEATURES. But I'm not sure how I can solve for example the below part in a effective and nice way: > > it really doesnt need to have override, you can enquire > MACHINE_FEATURES in python or shell. Yes, I'm aware of that I can use it that way. It was just my personal opinion that the code looks better with overrides in this particular case. On the other hand I can agree that the end-user will be more comfortable with using MACHINE_FEATURES instead of MACHINEOVERRIDES. Also since both you and Andrei push for MACHINE_FEATURES I will bend for your will =) Start using MACHINE_FEATURES from local.conf when using meta-raspberrypi will require a minor change i rpi-base.inc as well, since it otherwise will override MACHINE_FEATURES added in local.conf. I will send up a fix for that in v2 of this series as well. Thanks for your feedback. BR Petter >> xserver-xf86-config_0.1.bbappend FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" SRC_URI_append_rpi = " file://xorg.conf.d/10-evdev.conf [1] " SRC_URI_append_pitft = " file://xorg.conf.d/99-pitft.conf [2] " <---------------- My change.... do_install_append_rpi () { install -d ${D}/${sysconfdir}/X11/xorg.conf.d/ install -m 0644 ${WORKDIR}/xorg.conf.d/* ${D}/${sysconfdir}/X11/xorg.conf.d/ } FILES_${PN}_rpi += "${sysconfdir}/X11/xorg.conf ${sysconfdir}/X11/xorg.conf.d/*" ------------------- end ----------------------- But if you have any good suggestions about how to solve this, please enlighten me =) BR Petter -- Andrei Gherzan Links: ------ [1] file://xorg.conf.d/10-evdev.conf [2] file://xorg.conf.d/99-pitft.conf --=_9ba902eadfec638e75b999f541b220cc Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

2016-01-12 09:45 skrev Khem Raj:

On Mon, Jan 11, 2016 at 10:51 PM, Petter Mabäcker <petter@technux.se> wrote:
2016-01-11 21:32 skrev Andrei Gherzan= : On Mon, Jan 11, 2016 at 09:55:43AM -0800, Khem Raj wrote: On Jan 11, 2016= , at 8:49 AM, Petter Mabäcker <petter@technux.se> wrote: Add basic support for PiTFT display by us= ing device-trees. In order get it working below configurations must be acti= ve in local.conf: MACHINEOVERRIDES .=3D ":pitft” Using MACHINE_FEATUR= ES will be more appropriate term. Effects are same. Indeed. I support MACHI= NE_FEATURE usage here. I agree that the term MACHINE_FEATURES is better. Ho= wever since MACHINE_FEATURES isn't included in the OVERRIDES variable I wil= l not be able to use the task pre/appends that was the reason I used MACHIN= EOVERRIDES in the first place. The reason I want to use overrides in this c= ase is since I think it makes the code easier to read and understand for th= e user (in this particular case at least). I can of course change to just u= sing variables (like in many other optional features in meta-raspberrypi) o= r change to MACHINE_FEATURES. But I'm not sure how I can solve for example = the below part in a effective and nice way:
it really doesnt need to have override, you can enquire
MACHINE_FEATURES in python or shell.

Yes, I'm aware of that I can use it that way. It was just my personal op= inion that the code looks better with overrides in this particular case. On= the other hand I can agree that the end-user will be more comfortable with= using MACHINE_FEATURES instead of MACHINEOVERRIDES. Also since both you an= d Andrei push for MACHINE_FEATURES I will bend for your will =3D)

Start using MACHINE_FEATURES from local.conf when using meta-raspberrypi= will require a minor change i rpi-base.inc as well, since it otherwise wil= l override MACHINE_FEATURES added in local.conf. I will send up a fix for t= hat in v2 of this series as well.

Thanks for your feedback.

BR Petter

xserver-xf86-config_0.1.bbappend FILE= SEXTRAPATHS_prepend :=3D "${THISDIR}/${PN}:" SRC_URI_append_rpi =3D " file://xorg.conf.d/10-evdev.conf " SRC_URI_append_pitft =3D " file://xorg.conf.d/99-pitft.conf " <---------------- My change...= =2E do_install_append_rpi () { install -d ${D}/${sysconfdir}/X11/xorg.conf= =2Ed/ install -m 0644 ${WORKDIR}/xorg.conf.d/* ${D}/${sysconfdir}/X11/xorg= =2Econf.d/ } FILES_${PN}_rpi +=3D "${sysconfdir}/X11/xorg.conf ${sysconfdir= }/X11/xorg.conf.d/*" ------------------- end ----------------------- But if= you have any good suggestions about how to solve this, please enlighten me= =3D) BR Petter -- Andrei Gherzan
--=_9ba902eadfec638e75b999f541b220cc--