From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB6DC433EF for ; Fri, 13 May 2022 06:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377582AbiEMG6E (ORCPT ); Fri, 13 May 2022 02:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377575AbiEMG55 (ORCPT ); Fri, 13 May 2022 02:57:57 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3324668FBE for ; Thu, 12 May 2022 23:57:56 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso6408582wma.0 for ; Thu, 12 May 2022 23:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hASHPxv83GRvBq/XPbZdnxvQhLbD/eQRxLrZ3SHe3bA=; b=MxmcUOjEGFiLSngN/s+THREtdHFypFyRomxXgORGuf0OBSoSVonN4PCD4g7HVyqhrs aUMhRTId2H4bGCNg3lxU7geHZwdf3zQhDaEk9gGuJ+kwmjP4rylWr3uHxYCy6j9Srs3b YIOsXtxuWYHiTthFqmj2O7fVJK4diCiepDOKDd2ZPqK6qRCuHkwuV38Wt8Nzl3pqnSUp baiss945RrZk/SvxyAamevYckSxYsUaBTu7/qGTF9yCtqr5wMLgRBK3e/SbwtmWcDanw nAmbV/BasVDgoSft8nk4Wisg1DiWST27z3CsjvO8kbdpqoUuU2ABCWzbPfuq5Sxr27MO pwlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hASHPxv83GRvBq/XPbZdnxvQhLbD/eQRxLrZ3SHe3bA=; b=C3qx/NrHzmSsPwzi629kZcHQPPdT6RJq47NC/QbnAnDYt1rNOQcqubqcl2unORFmp5 qqwozzFZKc6zZE5cNkbZed6axJmbShtt7QbwxDL5LZS0YhySwxeb5o6Pi8kqLZksR7nX It+ij/xvL3P+hdNUA1yP4kcf7ISfiSVJV5nNZl6Z9M3PClzTx3ee/S3JocVafT413DMv 7prc25Jtw7/zyNy019rlhAtIu7cMy23ynzPHyMQUjtJ9WkGEi16imZh5MXaXaROMkGri sylxrNIYtLvqBnd2Wv6f/Qdt/2WhWq/Y9UesTMRfsb69H5nQbldG8+C/gzxQsGeLWLTy aOow== X-Gm-Message-State: AOAM530SYxrQAMbqui/s/TjiXtWEdzDRRuYu+voFhqIjsyONhS1thms7 JG3FCTRXbqcX7UO3T8NpSi4pnQ== X-Google-Smtp-Source: ABdhPJyGGZfF70Iywd0l6jNDT8xauodRFr/j9UDsyWKsA2dt9sva3CTS66dFHS1xmiPJjzdkhpf4GQ== X-Received: by 2002:a05:600c:6021:b0:394:56be:18e with SMTP id az33-20020a05600c602100b0039456be018emr3038733wmb.86.1652425074641; Thu, 12 May 2022 23:57:54 -0700 (PDT) Received: from [192.168.0.167] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id e15-20020adfa74f000000b0020c5253d8e5sm1301475wrd.49.2022.05.12.23.57.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 23:57:54 -0700 (PDT) Message-ID: <0e72e176-d7b0-ed10-08f3-ba7d4729a931@linaro.org> Date: Fri, 13 May 2022 08:57:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Content-Language: en-US To: Jacky Huang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ychuang570808@gmail.com Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com, will@kernel.org, soc@kernel.org, cfli0@nuvoton.com References: <20220510032558.10304-1-ychuang3@nuvoton.com> <20220510032558.10304-4-ychuang3@nuvoton.com> <03ac0a67-bd1f-12ca-74f7-8d5b05857ea7@linaro.org> <46a55b01-ee9f-604f-72c9-916bc2f02a09@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: <46a55b01-ee9f-604f-72c9-916bc2f02a09@nuvoton.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/05/2022 08:48, Jacky Huang wrote: >>> + >>> + hxt_24m: hxt_24mhz { >> No underscores in node name. Generic node names, so "clock-X" or >> "clock-some-suffix" > > OK, I will modify it as >  hxt-24m: hxt-24mhz No, it is not a generic node name. Please read my reply again. > >>> + compatible = "fixed-clock"; >>> + #clock-cells = <0>; >>> + clock-frequency = <24000000>; >> This does not look like property of SoC. Where is this clock defined? In >> the SoC or on the board? > > It's an external crystal on the board. > I add this node, because it's the clock source of clock controller. > It always present on all ma35d1 boards. > >     clk: clock-controller@40460200 { >         compatible = "nuvoton,ma35d1-clk"; >         reg = <0x0 0x40460200 0x0 0x100>; >         #clock-cells = <1>; >         clocks = <&hxt_24m>; >         clock-names = "HXT_24MHz"; > ... > >>> + clock-output-names = "HXT_24MHz"; >>> + }; >>> + >>> + timer { >>> + compatible = "arm,armv8-timer"; >>> + interrupts = >> + IRQ_TYPE_LEVEL_LOW)>, >>> + >> + IRQ_TYPE_LEVEL_LOW)>, >>> + >> + IRQ_TYPE_LEVEL_LOW)>, >>> + >> + IRQ_TYPE_LEVEL_LOW)>; >>> + clock-frequency = <12000000>; >>> + }; >>> + >>> + sys: system-controller@40460000 { >>> + compatible = "nuvoton,ma35d1-sys", "syscon", "simple-mfd"; >> Why is this a simple-mfd if there are no children here? What do you want >> to instantiate here? > > It's not a device, but a set of registers for system level control. > I want to provide a register base mapping for other devices to access > system control registers. This does not explain why you need simple-mfd. simple-mfd is not for providing a register base mapping for other devices. > >> Where is the nuvoton,ma35d1-sys compatible documented? > > OK, I will add the compatible document in next version. > > >>> + reg = <0x0 0x40460000 0x0 0x400>; >>> + }; >>> + >>> + reset: reset-controller { >>> + compatible = "nuvoton,ma35d1-reset"; >> Also not documented. > > I will also add the document for it. All of these should fail on checkpatch which points that you either did not run it or ignored the result. Please run checkpatch on all your submissions to Linux kernel and be sure that there is no warning or error. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF4CEC433F5 for ; Fri, 13 May 2022 06:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/b3BASvDNGMAJPrcZhsmejLoGVUX5udIIk89pXAuC6U=; b=qYDlbwP1N7CiAF oQrf/+T6BoBzS4N/AQPBnwx6BSCjZzd+ldptVDdx3scOIMaHtgfqy0OoOGZM4mmiFl56A4YGGq9iG MMkiMCg210snS4gbeTHxn1nO+B4FtWRHwPbiIYfm+wMBSRlBm5+gCllMEgwhSJTD72hy8sZBu9bId U0pmJ0c0fafcEq1QTHoP/Gy91RSsn0jYqRsh0xQ1a3p8pxUmbdY3ZXJ0qJXmPK8Ru8oDdz7QD9mBP XFapnIxUDujItuiyNRxGHH4/s9xWGPnF7CwjORc3RipcPzCOVrhbE622fpKgb53TUZ9Ogg4Swz1eN lycQkU1QmzfZqwaxAiWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npPFO-00Ektz-Mo; Fri, 13 May 2022 06:57:58 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npPFL-00Ekss-TX for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 06:57:57 +0000 Received: by mail-wm1-x334.google.com with SMTP id o12-20020a1c4d0c000000b00393fbe2973dso6390367wmh.2 for ; Thu, 12 May 2022 23:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hASHPxv83GRvBq/XPbZdnxvQhLbD/eQRxLrZ3SHe3bA=; b=MxmcUOjEGFiLSngN/s+THREtdHFypFyRomxXgORGuf0OBSoSVonN4PCD4g7HVyqhrs aUMhRTId2H4bGCNg3lxU7geHZwdf3zQhDaEk9gGuJ+kwmjP4rylWr3uHxYCy6j9Srs3b YIOsXtxuWYHiTthFqmj2O7fVJK4diCiepDOKDd2ZPqK6qRCuHkwuV38Wt8Nzl3pqnSUp baiss945RrZk/SvxyAamevYckSxYsUaBTu7/qGTF9yCtqr5wMLgRBK3e/SbwtmWcDanw nAmbV/BasVDgoSft8nk4Wisg1DiWST27z3CsjvO8kbdpqoUuU2ABCWzbPfuq5Sxr27MO pwlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hASHPxv83GRvBq/XPbZdnxvQhLbD/eQRxLrZ3SHe3bA=; b=atVZhj1rnxZ7Bq06xaWBsZUpjze+u0L6BghKdb+aVs9qE4J8JxZnxTQNh/is1SG+5K 75xs4H5AKJGt1nytDwbTO8TQ85Zr9PopiZf9HDcQy+MYaOM+L5K9MvmXGMr6CgxZoVie knyLDXCdNFXLZwvaZdS2xVVltau/dnvihVH9IEIdR7EYh9hIGlPti5GWKiZaVxMGkyFy DrS24lTSjco3JMzs+E+bQ1ZucEK5cgG89nNEM29xAO1/jQ58ARMM4fL0IWzoEG6/c9RE o9VKswrdrWyfK7SpD0FCsQgAVVYNpsAuJAGkMGn3IqrSNh8sXOzrxCjLHM9gUSyHBENA AIPA== X-Gm-Message-State: AOAM530+dVK8i/fJ8ToH05iE2JP7LWBRiT32eUN9kVU9VS9COh6L5oXN dw7gFKBrFTdzf0aHpLL0QfQkBA== X-Google-Smtp-Source: ABdhPJyGGZfF70Iywd0l6jNDT8xauodRFr/j9UDsyWKsA2dt9sva3CTS66dFHS1xmiPJjzdkhpf4GQ== X-Received: by 2002:a05:600c:6021:b0:394:56be:18e with SMTP id az33-20020a05600c602100b0039456be018emr3038733wmb.86.1652425074641; Thu, 12 May 2022 23:57:54 -0700 (PDT) Received: from [192.168.0.167] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id e15-20020adfa74f000000b0020c5253d8e5sm1301475wrd.49.2022.05.12.23.57.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 23:57:54 -0700 (PDT) Message-ID: <0e72e176-d7b0-ed10-08f3-ba7d4729a931@linaro.org> Date: Fri, 13 May 2022 08:57:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Content-Language: en-US To: Jacky Huang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ychuang570808@gmail.com Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com, will@kernel.org, soc@kernel.org, cfli0@nuvoton.com References: <20220510032558.10304-1-ychuang3@nuvoton.com> <20220510032558.10304-4-ychuang3@nuvoton.com> <03ac0a67-bd1f-12ca-74f7-8d5b05857ea7@linaro.org> <46a55b01-ee9f-604f-72c9-916bc2f02a09@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: <46a55b01-ee9f-604f-72c9-916bc2f02a09@nuvoton.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220512_235756_005351_863183F1 X-CRM114-Status: GOOD ( 22.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTMvMDUvMjAyMiAwODo0OCwgSmFja3kgSHVhbmcgd3JvdGU6Cj4+PiArCj4+PiArCWh4dF8y NG06IGh4dF8yNG1oeiB7Cj4+IE5vIHVuZGVyc2NvcmVzIGluIG5vZGUgbmFtZS4gR2VuZXJpYyBu b2RlIG5hbWVzLCBzbyAiY2xvY2stWCIgb3IKPj4gImNsb2NrLXNvbWUtc3VmZml4Igo+IAo+IE9L LCBJIHdpbGwgbW9kaWZ5IGl0IGFzCj4gIMKgaHh0LTI0bTogaHh0LTI0bWh6CgpObywgaXQgaXMg bm90IGEgZ2VuZXJpYyBub2RlIG5hbWUuIFBsZWFzZSByZWFkIG15IHJlcGx5IGFnYWluLgoKPiAK Pj4+ICsJCWNvbXBhdGlibGUgPSAiZml4ZWQtY2xvY2siOwo+Pj4gKwkJI2Nsb2NrLWNlbGxzID0g PDA+Owo+Pj4gKwkJY2xvY2stZnJlcXVlbmN5ID0gPDI0MDAwMDAwPjsKPj4gVGhpcyBkb2VzIG5v dCBsb29rIGxpa2UgcHJvcGVydHkgb2YgU29DLiBXaGVyZSBpcyB0aGlzIGNsb2NrIGRlZmluZWQ/ IEluCj4+IHRoZSBTb0Mgb3Igb24gdGhlIGJvYXJkPwo+IAo+IEl0J3MgYW4gZXh0ZXJuYWwgY3J5 c3RhbCBvbiB0aGUgYm9hcmQuCj4gSSBhZGQgdGhpcyBub2RlLCBiZWNhdXNlIGl0J3MgdGhlIGNs b2NrIHNvdXJjZSBvZiBjbG9jayBjb250cm9sbGVyLgo+IEl0IGFsd2F5cyBwcmVzZW50IG9uIGFs bCBtYTM1ZDEgYm9hcmRzLgo+IAo+ICDCoMKgwqAgY2xrOiBjbG9jay1jb250cm9sbGVyQDQwNDYw MjAwIHsKPiAgwqDCoCDCoMKgwqDCoCBjb21wYXRpYmxlID0gIm51dm90b24sbWEzNWQxLWNsayI7 Cj4gIMKgwqAgwqDCoMKgwqAgcmVnID0gPDB4MCAweDQwNDYwMjAwIDB4MCAweDEwMD47Cj4gIMKg wqAgwqDCoMKgwqAgI2Nsb2NrLWNlbGxzID0gPDE+Owo+ICDCoMKgIMKgwqDCoMKgIGNsb2NrcyA9 IDwmaHh0XzI0bT47Cj4gIMKgwqAgwqDCoMKgwqAgY2xvY2stbmFtZXMgPSAiSFhUXzI0TUh6IjsK PiAuLi4KPiAKPj4+ICsJCWNsb2NrLW91dHB1dC1uYW1lcyA9ICJIWFRfMjRNSHoiOwo+Pj4gKwl9 Owo+Pj4gKwo+Pj4gKwl0aW1lciB7Cj4+PiArCQljb21wYXRpYmxlID0gImFybSxhcm12OC10aW1l ciI7Cj4+PiArCQlpbnRlcnJ1cHRzID0gPEdJQ19QUEkgMTMgKEdJQ19DUFVfTUFTS19TSU1QTEUo NCkgfAo+Pj4gKwkJCQkJICBJUlFfVFlQRV9MRVZFTF9MT1cpPiwKPj4+ICsJCQkgICAgIDxHSUNf UFBJIDE0IChHSUNfQ1BVX01BU0tfU0lNUExFKDQpIHwKPj4+ICsJCQkJCSAgSVJRX1RZUEVfTEVW RUxfTE9XKT4sCj4+PiArCQkJICAgICA8R0lDX1BQSSAxMSAoR0lDX0NQVV9NQVNLX1NJTVBMRSg0 KSB8Cj4+PiArCQkJCQkgIElSUV9UWVBFX0xFVkVMX0xPVyk+LAo+Pj4gKwkJCSAgICAgPEdJQ19Q UEkgMTAgKEdJQ19DUFVfTUFTS19TSU1QTEUoNCkgfAo+Pj4gKwkJCQkJICBJUlFfVFlQRV9MRVZF TF9MT1cpPjsKPj4+ICsJCWNsb2NrLWZyZXF1ZW5jeSA9IDwxMjAwMDAwMD47Cj4+PiArCX07Cj4+ PiArCj4+PiArCXN5czogc3lzdGVtLWNvbnRyb2xsZXJANDA0NjAwMDAgewo+Pj4gKwkJY29tcGF0 aWJsZSA9ICJudXZvdG9uLG1hMzVkMS1zeXMiLCAic3lzY29uIiwgInNpbXBsZS1tZmQiOwo+PiBX aHkgaXMgdGhpcyBhIHNpbXBsZS1tZmQgaWYgdGhlcmUgYXJlIG5vIGNoaWxkcmVuIGhlcmU/IFdo YXQgZG8geW91IHdhbnQKPj4gdG8gaW5zdGFudGlhdGUgaGVyZT8KPiAKPiBJdCdzIG5vdCBhIGRl dmljZSwgYnV0IGEgc2V0IG9mIHJlZ2lzdGVycyBmb3Igc3lzdGVtIGxldmVsIGNvbnRyb2wuCj4g SSB3YW50IHRvIHByb3ZpZGUgYSByZWdpc3RlciBiYXNlIG1hcHBpbmcgZm9yIG90aGVyIGRldmlj ZXMgdG8gYWNjZXNzIAo+IHN5c3RlbSBjb250cm9sIHJlZ2lzdGVycy4KClRoaXMgZG9lcyBub3Qg ZXhwbGFpbiB3aHkgeW91IG5lZWQgc2ltcGxlLW1mZC4gc2ltcGxlLW1mZCBpcyBub3QgZm9yCnBy b3ZpZGluZyBhIHJlZ2lzdGVyIGJhc2UgbWFwcGluZyBmb3Igb3RoZXIgZGV2aWNlcy4KCj4gCj4+ IFdoZXJlIGlzIHRoZSBudXZvdG9uLG1hMzVkMS1zeXMgY29tcGF0aWJsZSBkb2N1bWVudGVkPwo+ IAo+IE9LLCBJIHdpbGwgYWRkIHRoZSBjb21wYXRpYmxlIGRvY3VtZW50IGluIG5leHQgdmVyc2lv bi4KPiAKPiAKPj4+ICsJCXJlZyA9IDwweDAgMHg0MDQ2MDAwMCAweDAgMHg0MDA+Owo+Pj4gKwl9 Owo+Pj4gKwo+Pj4gKwlyZXNldDogcmVzZXQtY29udHJvbGxlciB7Cj4+PiArCQljb21wYXRpYmxl ID0gIm51dm90b24sbWEzNWQxLXJlc2V0IjsKPj4gQWxzbyBub3QgZG9jdW1lbnRlZC4KPiAKPiBJ IHdpbGwgYWxzbyBhZGQgdGhlIGRvY3VtZW50IGZvciBpdC4KCkFsbCBvZiB0aGVzZSBzaG91bGQg ZmFpbCBvbiBjaGVja3BhdGNoIHdoaWNoIHBvaW50cyB0aGF0IHlvdSBlaXRoZXIgZGlkCm5vdCBy dW4gaXQgb3IgaWdub3JlZCB0aGUgcmVzdWx0LgoKUGxlYXNlIHJ1biBjaGVja3BhdGNoIG9uIGFs bCB5b3VyIHN1Ym1pc3Npb25zIHRvIExpbnV4IGtlcm5lbCBhbmQgYmUKc3VyZSB0aGF0IHRoZXJl IGlzIG5vIHdhcm5pbmcgb3IgZXJyb3IuCgoKCkJlc3QgcmVnYXJkcywKS3J6eXN6dG9mCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==