From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89A23C6FD1F for ; Tue, 14 Mar 2023 03:23:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 915CB858FF; Tue, 14 Mar 2023 04:23:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A096385ECB; Tue, 14 Mar 2023 04:22:58 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CB755858FF for ; Tue, 14 Mar 2023 04:22:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 79B2B3C01A6; Tue, 14 Mar 2023 11:22:42 +0800 (CST) Message-ID: <0e7efee9-917a-6f78-c751-151608843be6@rock-chips.com> Date: Tue, 14 Mar 2023 11:22:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 06/12] rockchip: rk3588-rock-5b: Fix sdmmc boot Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich , Eugen Hristev Cc: Jagan Teki , u-boot@lists.denx.de References: <20230314003755.512696-1-jonas@kwiboo.se> <20230314003755.512696-7-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230314003755.512696-7-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGhlNTVZCT01ITUMfGE5CHUJVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSEpMVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OBQ6Lzo*Sz0OFy0zHhwqGRM5 ORgaCQlVSlVKTUxDTE1PSk1ISUlDVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFIT0hNNwY+ X-HM-Tid: 0a86de243eed2eb0kusn79b2b3c01a6 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/14 08:38, Jonas Karlman wrote: > Running U-Boot from a SD-card on ROCK 5 Model B fails to load atf using > DMA and prints debug_uart messages. > > > > > > U-Boot SPL 2023.04-rc3 (Mar 12 2023 - 00:30:16 +0000) > Trying to boot from MMC1 > ## Checking hash(es) for config config-1 ... OK > ## Checking hash(es) for Image atf-1 ... sha256 error! > Bad hash value for 'hash' hash node in 'atf-1' image node > mmc_load_image_raw_sector: mmc block read error > SPL: failed to boot from all boot devices > ### ERROR ### Please RESET the board ### > > Use fifo-mode to disable DMA in SPL, add same-as-spl to boot-order and > remove DEBUG_UART_ANNOUNCE option to fix this. > > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 3 ++- > configs/rock5b-rk3588_defconfig | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > index 2386edf90deb..36d557b4934d 100644 > --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > @@ -11,12 +11,13 @@ > }; > > chosen { > - u-boot,spl-boot-order = &sdmmc; > + u-boot,spl-boot-order = "same-as-spl", &sdmmc; > }; > }; > > &sdmmc { > bus-width = <4>; > u-boot,dm-spl; > + u-boot,spl-fifo-mode; > status = "okay"; > }; > diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig > index 66199387195a..3fcc6a26bb51 100644 > --- a/configs/rock5b-rk3588_defconfig > +++ b/configs/rock5b-rk3588_defconfig > @@ -66,6 +66,5 @@ CONFIG_PWM_ROCKCHIP=y > CONFIG_SPL_RAM=y > CONFIG_BAUDRATE=1500000 > CONFIG_DEBUG_UART_SHIFT=2 > -CONFIG_DEBUG_UART_ANNOUNCE=y > CONFIG_SYSRESET=y > CONFIG_ERRNO_STR=y