From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3561AC43461 for ; Wed, 7 Apr 2021 13:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB8F660FD7 for ; Wed, 7 Apr 2021 13:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344081AbhDGNKS (ORCPT ); Wed, 7 Apr 2021 09:10:18 -0400 Received: from mail-co1nam11on2117.outbound.protection.outlook.com ([40.107.220.117]:35681 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235385AbhDGNKP (ORCPT ); Wed, 7 Apr 2021 09:10:15 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sk3oi2qzDX8EhIq9+X9ys8xATAD98o/1a2J8xS104OOaztdy9fqF7byxtwC3VLzYA2gi0ka2goSJ7ZZon8dHW74ZhcaAAk0QLsO8zRkn0vUnEnmBv+7kZJl50nKXM0204+0R92CHq1tDmP3UIdZ2axAAHoMw2miDOMyMEtjI482L0nwCXCNw/tJu9JAd3ITBqUuB4ufuUfJPU0vgS9AcfF471NRXh5N8JMaRIiMHfbc8hO88wAbdAK0pDO2etsq7UWuO5L1GZudNB4LGS692EgJdfIXaZq43cFfWm8VGCqWpn1iS5fUiIe3HItPvfybb0JSDt0/BFdVHXqEQYLK3uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3a29ZpwxhPwXlxpNgVldcV+Rpnd8BsEHALPFTBp58Bw=; b=SL2ZGeqr7dXlJijfrf0cUiOMXYGawpAbYfQt7XwxHJHSoS/obHFCLwt1T8qmy/Fc1ACklBtr+YXz8tElBmHwFbMVzeNna3ByFO2AC2uMP4Ai/NNanDJtmja7GmoDT1Q5g93c++/dGsRZNA4wP7vUxaz0l+zstkVztNt71uNQPZ6pYbz5OwLhSx04zO08ohFkrDh4w/vZOS3NjvZuPOhJpobiUld42ObMwWHHeWv/N1uHwLRD0eDLqARi67qjW6aN58vl6JZKYcAOUYfTHTmbloRJzwj1ii7i5dbYC4hteuSdkNI6c2vTQEbzxi8Y13BIzNyze0l35/App5EAFECfKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3a29ZpwxhPwXlxpNgVldcV+Rpnd8BsEHALPFTBp58Bw=; b=WUJuUm6tuAu4+VisFIptbnZMfjWAu/htZ3+zntik/U2uhwT18NXYfMcSILwdMhymT2y7X/WG8OVIL8K8XcUlZaDdPx+DCsMs9Da5FRuNd+GL+ZPOWIuhfHVdKfCOmMIwf3t5eq1og6a/FBC4Gc/ggy9dJjpeT7IEsvA417bF0NI= Authentication-Results: os.amperecomputing.com; dkim=none (message not signed) header.d=none;os.amperecomputing.com; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by MWHPR01MB2734.prod.exchangelabs.com (2603:10b6:300:f6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Wed, 7 Apr 2021 13:10:02 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503%5]) with mapi id 15.20.4020.016; Wed, 7 Apr 2021 13:10:01 +0000 Subject: Re: [PATCH v2 0/3] Add Aspeed SSIF BMC driver To: minyard@acm.org Cc: Rob Herring , Joel Stanley , Andrew Jeffery , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" References: <20210330141029.20412-1-quan@os.amperecomputing.com> <20210402142124.GV507977@minyard.net> From: Quan Nguyen Message-ID: <0e7fceff-4a01-5cb0-72eb-8b47d598f1c3@os.amperecomputing.com> Date: Wed, 7 Apr 2021 20:09:50 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <20210402142124.GV507977@minyard.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HK2P15301CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::18) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.38.33.17] (118.69.219.201) by HK2P15301CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.3 via Frontend Transport; Wed, 7 Apr 2021 13:09:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28630cce-ceb8-4ac2-f653-08d8f9c67380 X-MS-TrafficTypeDiagnostic: MWHPR01MB2734: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ETv8uoc6Dkbc7a2RBZXF5b4N2k+daHxi7QQaIIPTS9Avr+JkxHInO9D3RLbKi35tDMaEqZn6IeHxLDx8Qa0L7eFq7vxEGK+GiNTAtcHakXiO2ssMmZ+heEmICwGJjfSjrq6luuRc1EddOusCeIQAEpUEhLQoqmjFbeeRlhfgNEJJe8MiyulZPaEyD23ObhnWolXJ7ckVCYIP75e3E0gWzBBofjkcDtpATyn4LdeDCFANt4Ax2zcQBcmX/Vo6EkcFdrOEEBm1G1J2WaTc+rt0/J2ZFR5GARe3oJT1XaFHI5YzdR/JcGZdfRkFflMcf8aUK7qbyERwPo0P2dj+x47mUzz22Re5pl8YeiIwFBODIvLs1xwVMtn+hXKYOYBV0ORSMlZfKlCxVCno6/GsE3GtNt+mTjdiw2JZGx65O/Yt3yMDu04jUt7QBzjzedBBM+qVEPQV4zn+3MRd0kY6UxVXU1xw14gOz9/tYxxERB5jB8TuLMBMKNgyJQpUdlAUQN1iyX2tmoGyk3gul+u1exy73fHc0156p2ekbZQdoH66e0BHzDF1OnmOgFy2mOSdBdcMY+G9blJGzNK70VDAqvHw3iRsVDeP7Sh80EkO70eMfonIQSpabl8eN85qd+0O/IBRW6i2S4ctqdRV9E3c1hIi6FdQRWIkZrVgovKfiPHTVRUbqnC2pwRoBxrjN+XYXq3QmYKwbXwUdKUYsFBjABfKYyJDtqFuF5F4vqJWR8PPOP0/oiV6vj8ua13NuQ12giKEzEErMLU8a0u+Sh7VJbC71nBpQCFEgjhHmX0Mhq4mDO8YG1cUQju1rgidLhMTBriK1sjCpiUC8Otu9oGaNsQ3ew== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR0102MB3482.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39840400004)(136003)(396003)(376002)(366004)(53546011)(31696002)(5660300002)(83380400001)(16526019)(186003)(6916009)(2906002)(16576012)(66556008)(8676002)(54906003)(66476007)(66946007)(38350700001)(6486002)(38100700001)(8936002)(7416002)(26005)(6666004)(966005)(4326008)(107886003)(52116002)(2616005)(956004)(316002)(86362001)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L21jd052WDV4NTE1Zm04a1FsOTIxTkVnTDVqY0xhQUpEYjhlU0NoOFVCZEJw?= =?utf-8?B?US9Qa0NnS0t4a20wM25iRGdyVHk4RjZ0bW45bW1CK3IxUUtnMWlDMmZpRzQy?= =?utf-8?B?dlp5ZXdXcFRDMEhsOGgrbU5HNEE2QzByY0l2QUE3Rll0TnhtTTdqcEYreHNq?= =?utf-8?B?Z2ZHYnFYNWp4K0pacDN2K2poMFc2SWFGdEVlNUJKcjdOQXhQeW9Oak9RMk1j?= =?utf-8?B?REtQL0llakFMU3hEUDdlRmxCVEZpL0Y3UWRhbVBxaXk3czJhY1Q4elkxY1Fv?= =?utf-8?B?WnBSc2NwdkhWc0FZd0RYVjVMSTBUbE9MU1BDZ2l0OVFsOVJibkdIVnBHYXU5?= =?utf-8?B?U05zQ1NBV2xCUGtmUlVwSy9RVFFMLzdNOUpaYkFGYjVURjkxOGp4UkxhU1Bq?= =?utf-8?B?RUEzTU5PZ1FVa3ZJK3E0d1lDeUFmcldSSXc3OUg0U2VOdVNXOExyM2NkZTIz?= =?utf-8?B?L1pIYlVGTmczNnluSzYrZk8yWGxJUklFOWtOUU9Pb0dZUG9yMkVTcStGZmwx?= =?utf-8?B?bEkrcFVFZzliazV2WDBPajVLV0FpUmhFWS8xc1ptaDFpdFVkOUZtY1JPSDRI?= =?utf-8?B?MDZ1S3Zock1vNytvQkRvR1dXVXFLWTRkM1pTaE9LeWtNb3lWUUZGVE9JNlFZ?= =?utf-8?B?VXBBdGhDYjNBYXhqMUZzQnFmZXRrbVkvU29sb3pUU3RtaVBQWFp3dS83VUJF?= =?utf-8?B?U1RIQjZJaURFSjFBVkdjMzdNYmZwNlJMQnVjWDFqTlRXanZZSVh2Z0hxc1BR?= =?utf-8?B?Q09yQ2ZjSXUzVWdpVmRPQ0l6Y1dubzllTWVhWW9mVHV1RVJ4Y1oxV3pybTNW?= =?utf-8?B?dE5DWkJyaEo2YjBpc1F3T1ptU0RxSVA4MkkxSWpnU0poSHdEaVh4Qm9nbmVa?= =?utf-8?B?SytmKzJEQ2QzMWNSNHcxSDA0Z0hVS0RPZmxhT1NhblVEbzhTTG1WalFmbDBp?= =?utf-8?B?QzVvZFIvWmNKQVZFR0NKUTdLblJqZ2RCcDgvK3c3Z0pDSWIwWnVJSnVRYVJz?= =?utf-8?B?SUNiZUNRdk80N3JOOVgwTDV1T1RUNjNyWFNURnIyRTdLZnpxNlNkclUyTGJh?= =?utf-8?B?K3psSTVOeFpaN3NhdEJET2FZY3VDT2x6QkxXeHp3a3JyWmtPZ29iYzBVRXRM?= =?utf-8?B?SDRMN3VSYS9KWXFxcmFKMXBIRDZ4QlZ2VVRXS0xlNlRxUTQ2RFBQeFlLSGxo?= =?utf-8?B?UUwzWDF2ZFdWWm9PUURIUXB0dmkwU0FOaXA5V2VEZG9NYTZLeGZxdEhpRWJq?= =?utf-8?B?QjE2WTF4L0NYclVUSXdMb3hUNnVOWWIwT00vbGN2cittMkFmbndENldHN1RE?= =?utf-8?B?QmdUNjJzak15Qmhmenl6NEJBc2xXS3V5NFJuZUV4aWloazVyRlFvTzAyUFFZ?= =?utf-8?B?WDM0Q2hxeVZSL1JTcXZTaXhrVE5qbDhhNmJYczV1Vm1LYWhMelBIamF5SnAz?= =?utf-8?B?eXFwZ3lyOFJRZ0o5ZUp3UExkSEZkbnlUYm1SNHdlYUxYT0VYdjUzWEpDZnVU?= =?utf-8?B?bU13cSszSlA4dWpqV04vbTVaS2ppRm1xZFhkcEJYY0lxTU42TmNiUmltQjRp?= =?utf-8?B?bGhUSjdqSjNrYlVQREFlNXdWSUJQSXV3VlRMeUZnRFd2Z1k3VHpEeCtXWTRx?= =?utf-8?B?OXVlSFNpVGljUUhlR3VZZ2ZpT3I3WGJoa3NZRmVGQ1VDYWhXbnoydDJXM2o4?= =?utf-8?B?aUxzYWRoSzlOU2x1Q21XYTFRWTJXTkE0aWFZZWNKOStkNm1udkNTQzhHNVhU?= =?utf-8?Q?GP12p8n/zESfaNVRUqk4twG91IxytSGRqsiKmyG?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28630cce-ceb8-4ac2-f653-08d8f9c67380 X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2021 13:10:01.3735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Smz3mGe5/PgE/Tbhmfp7KovILLQx3GiGymFDRx4aGKKh0NnPuVGrtK+Ik7/UXfYYyWYpw9Zsxm2NK03auY8+XWhiHfo7SzajzQd872qGXO8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2734 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Corey, Thank you for reviewing I'll put my respond inline below. -Quan On 02/04/2021 21:21, Corey Minyard wrote: > On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote: >> This series add support for the Aspeed specific SSIF BMC driver which >> is to perform in-band IPMI communication with the host in management >> (BMC) side. > > I don't have any specific feedback for this, but I'm wondering if it's > really necessary. > > Why can't the BMC just open the I2C device and use it? Is there any > functionality that this provides that cannot be accomplished from > userland access to the I2C device? I don't see any. > > If it tied into some existing framework to give abstract access to a BMC > slave side interface, I'd be ok with this. But I don't see that. > The SSIF at the BMC side acts as an I2C slave and we think that the kernel driver is unavoidable to handle the I2c slave events (https://www.kernel.org/doc/html/latest/i2c/slave-interface.html) And to make it works with existing OpenBMC IPMI stack, a userspace part, ssifbridge, is needed (https://github.com/openbmc/ssifbridge). This ssifbridge is to connect this driver with the OpenBMC IPMI stack so the IPMI stack can communicate via SSIF channel in similar way that was implemented with BT and KCS (ie: btbridge/kcsbridge and its corespondent kernel drivers (https://github.com/openbmc/btbridge and https://github.com/openbmc/kcsbridge)) > Unless there is a big need to have this in the kernel, I'm against > including this and would suggest you do all this work in userland. > Perhaps write a library. Sorry, but I'm trying to do my part to reduce > unnecessary things in the kernel. > > Thanks, > > -corey > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCB5C433ED for ; Wed, 7 Apr 2021 13:10:43 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 958C561284 for ; Wed, 7 Apr 2021 13:10:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 958C561284 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FFlBT1Dl1z3bnf for ; Wed, 7 Apr 2021 23:10:41 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.a=rsa-sha256 header.s=selector2 header.b=WUJuUm6t; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=os.amperecomputing.com (client-ip=40.107.220.92; helo=nam11-co1-obe.outbound.protection.outlook.com; envelope-from=quan@os.amperecomputing.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.a=rsa-sha256 header.s=selector2 header.b=WUJuUm6t; dkim-atps=neutral Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2092.outbound.protection.outlook.com [40.107.220.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FFl9v5FQ9z302t; Wed, 7 Apr 2021 23:10:10 +1000 (AEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sk3oi2qzDX8EhIq9+X9ys8xATAD98o/1a2J8xS104OOaztdy9fqF7byxtwC3VLzYA2gi0ka2goSJ7ZZon8dHW74ZhcaAAk0QLsO8zRkn0vUnEnmBv+7kZJl50nKXM0204+0R92CHq1tDmP3UIdZ2axAAHoMw2miDOMyMEtjI482L0nwCXCNw/tJu9JAd3ITBqUuB4ufuUfJPU0vgS9AcfF471NRXh5N8JMaRIiMHfbc8hO88wAbdAK0pDO2etsq7UWuO5L1GZudNB4LGS692EgJdfIXaZq43cFfWm8VGCqWpn1iS5fUiIe3HItPvfybb0JSDt0/BFdVHXqEQYLK3uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3a29ZpwxhPwXlxpNgVldcV+Rpnd8BsEHALPFTBp58Bw=; b=SL2ZGeqr7dXlJijfrf0cUiOMXYGawpAbYfQt7XwxHJHSoS/obHFCLwt1T8qmy/Fc1ACklBtr+YXz8tElBmHwFbMVzeNna3ByFO2AC2uMP4Ai/NNanDJtmja7GmoDT1Q5g93c++/dGsRZNA4wP7vUxaz0l+zstkVztNt71uNQPZ6pYbz5OwLhSx04zO08ohFkrDh4w/vZOS3NjvZuPOhJpobiUld42ObMwWHHeWv/N1uHwLRD0eDLqARi67qjW6aN58vl6JZKYcAOUYfTHTmbloRJzwj1ii7i5dbYC4hteuSdkNI6c2vTQEbzxi8Y13BIzNyze0l35/App5EAFECfKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3a29ZpwxhPwXlxpNgVldcV+Rpnd8BsEHALPFTBp58Bw=; b=WUJuUm6tuAu4+VisFIptbnZMfjWAu/htZ3+zntik/U2uhwT18NXYfMcSILwdMhymT2y7X/WG8OVIL8K8XcUlZaDdPx+DCsMs9Da5FRuNd+GL+ZPOWIuhfHVdKfCOmMIwf3t5eq1og6a/FBC4Gc/ggy9dJjpeT7IEsvA417bF0NI= Authentication-Results: os.amperecomputing.com; dkim=none (message not signed) header.d=none; os.amperecomputing.com; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by MWHPR01MB2734.prod.exchangelabs.com (2603:10b6:300:f6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Wed, 7 Apr 2021 13:10:02 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503%5]) with mapi id 15.20.4020.016; Wed, 7 Apr 2021 13:10:01 +0000 Subject: Re: [PATCH v2 0/3] Add Aspeed SSIF BMC driver To: minyard@acm.org References: <20210330141029.20412-1-quan@os.amperecomputing.com> <20210402142124.GV507977@minyard.net> From: Quan Nguyen Message-ID: <0e7fceff-4a01-5cb0-72eb-8b47d598f1c3@os.amperecomputing.com> Date: Wed, 7 Apr 2021 20:09:50 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <20210402142124.GV507977@minyard.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HK2P15301CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::18) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.38.33.17] (118.69.219.201) by HK2P15301CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.3 via Frontend Transport; Wed, 7 Apr 2021 13:09:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28630cce-ceb8-4ac2-f653-08d8f9c67380 X-MS-TrafficTypeDiagnostic: MWHPR01MB2734: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ETv8uoc6Dkbc7a2RBZXF5b4N2k+daHxi7QQaIIPTS9Avr+JkxHInO9D3RLbKi35tDMaEqZn6IeHxLDx8Qa0L7eFq7vxEGK+GiNTAtcHakXiO2ssMmZ+heEmICwGJjfSjrq6luuRc1EddOusCeIQAEpUEhLQoqmjFbeeRlhfgNEJJe8MiyulZPaEyD23ObhnWolXJ7ckVCYIP75e3E0gWzBBofjkcDtpATyn4LdeDCFANt4Ax2zcQBcmX/Vo6EkcFdrOEEBm1G1J2WaTc+rt0/J2ZFR5GARe3oJT1XaFHI5YzdR/JcGZdfRkFflMcf8aUK7qbyERwPo0P2dj+x47mUzz22Re5pl8YeiIwFBODIvLs1xwVMtn+hXKYOYBV0ORSMlZfKlCxVCno6/GsE3GtNt+mTjdiw2JZGx65O/Yt3yMDu04jUt7QBzjzedBBM+qVEPQV4zn+3MRd0kY6UxVXU1xw14gOz9/tYxxERB5jB8TuLMBMKNgyJQpUdlAUQN1iyX2tmoGyk3gul+u1exy73fHc0156p2ekbZQdoH66e0BHzDF1OnmOgFy2mOSdBdcMY+G9blJGzNK70VDAqvHw3iRsVDeP7Sh80EkO70eMfonIQSpabl8eN85qd+0O/IBRW6i2S4ctqdRV9E3c1hIi6FdQRWIkZrVgovKfiPHTVRUbqnC2pwRoBxrjN+XYXq3QmYKwbXwUdKUYsFBjABfKYyJDtqFuF5F4vqJWR8PPOP0/oiV6vj8ua13NuQ12giKEzEErMLU8a0u+Sh7VJbC71nBpQCFEgjhHmX0Mhq4mDO8YG1cUQju1rgidLhMTBriK1sjCpiUC8Otu9oGaNsQ3ew== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR0102MB3482.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39840400004)(136003)(396003)(376002)(366004)(53546011)(31696002)(5660300002)(83380400001)(16526019)(186003)(6916009)(2906002)(16576012)(66556008)(8676002)(54906003)(66476007)(66946007)(38350700001)(6486002)(38100700001)(8936002)(7416002)(26005)(6666004)(966005)(4326008)(107886003)(52116002)(2616005)(956004)(316002)(86362001)(31686004)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L21jd052WDV4NTE1Zm04a1FsOTIxTkVnTDVqY0xhQUpEYjhlU0NoOFVCZEJw?= =?utf-8?B?US9Qa0NnS0t4a20wM25iRGdyVHk4RjZ0bW45bW1CK3IxUUtnMWlDMmZpRzQy?= =?utf-8?B?dlp5ZXdXcFRDMEhsOGgrbU5HNEE2QzByY0l2QUE3Rll0TnhtTTdqcEYreHNq?= =?utf-8?B?Z2ZHYnFYNWp4K0pacDN2K2poMFc2SWFGdEVlNUJKcjdOQXhQeW9Oak9RMk1j?= =?utf-8?B?REtQL0llakFMU3hEUDdlRmxCVEZpL0Y3UWRhbVBxaXk3czJhY1Q4elkxY1Fv?= =?utf-8?B?WnBSc2NwdkhWc0FZd0RYVjVMSTBUbE9MU1BDZ2l0OVFsOVJibkdIVnBHYXU5?= =?utf-8?B?U05zQ1NBV2xCUGtmUlVwSy9RVFFMLzdNOUpaYkFGYjVURjkxOGp4UkxhU1Bq?= =?utf-8?B?RUEzTU5PZ1FVa3ZJK3E0d1lDeUFmcldSSXc3OUg0U2VOdVNXOExyM2NkZTIz?= =?utf-8?B?L1pIYlVGTmczNnluSzYrZk8yWGxJUklFOWtOUU9Pb0dZUG9yMkVTcStGZmwx?= =?utf-8?B?bEkrcFVFZzliazV2WDBPajVLV0FpUmhFWS8xc1ptaDFpdFVkOUZtY1JPSDRI?= =?utf-8?B?MDZ1S3Zock1vNytvQkRvR1dXVXFLWTRkM1pTaE9LeWtNb3lWUUZGVE9JNlFZ?= =?utf-8?B?VXBBdGhDYjNBYXhqMUZzQnFmZXRrbVkvU29sb3pUU3RtaVBQWFp3dS83VUJF?= =?utf-8?B?U1RIQjZJaURFSjFBVkdjMzdNYmZwNlJMQnVjWDFqTlRXanZZSVh2Z0hxc1BR?= =?utf-8?B?Q09yQ2ZjSXUzVWdpVmRPQ0l6Y1dubzllTWVhWW9mVHV1RVJ4Y1oxV3pybTNW?= =?utf-8?B?dE5DWkJyaEo2YjBpc1F3T1ptU0RxSVA4MkkxSWpnU0poSHdEaVh4Qm9nbmVa?= =?utf-8?B?SytmKzJEQ2QzMWNSNHcxSDA0Z0hVS0RPZmxhT1NhblVEbzhTTG1WalFmbDBp?= =?utf-8?B?QzVvZFIvWmNKQVZFR0NKUTdLblJqZ2RCcDgvK3c3Z0pDSWIwWnVJSnVRYVJz?= =?utf-8?B?SUNiZUNRdk80N3JOOVgwTDV1T1RUNjNyWFNURnIyRTdLZnpxNlNkclUyTGJh?= =?utf-8?B?K3psSTVOeFpaN3NhdEJET2FZY3VDT2x6QkxXeHp3a3JyWmtPZ29iYzBVRXRM?= =?utf-8?B?SDRMN3VSYS9KWXFxcmFKMXBIRDZ4QlZ2VVRXS0xlNlRxUTQ2RFBQeFlLSGxo?= =?utf-8?B?UUwzWDF2ZFdWWm9PUURIUXB0dmkwU0FOaXA5V2VEZG9NYTZLeGZxdEhpRWJq?= =?utf-8?B?QjE2WTF4L0NYclVUSXdMb3hUNnVOWWIwT00vbGN2cittMkFmbndENldHN1RE?= =?utf-8?B?QmdUNjJzak15Qmhmenl6NEJBc2xXS3V5NFJuZUV4aWloazVyRlFvTzAyUFFZ?= =?utf-8?B?WDM0Q2hxeVZSL1JTcXZTaXhrVE5qbDhhNmJYczV1Vm1LYWhMelBIamF5SnAz?= =?utf-8?B?eXFwZ3lyOFJRZ0o5ZUp3UExkSEZkbnlUYm1SNHdlYUxYT0VYdjUzWEpDZnVU?= =?utf-8?B?bU13cSszSlA4dWpqV04vbTVaS2ppRm1xZFhkcEJYY0lxTU42TmNiUmltQjRp?= =?utf-8?B?bGhUSjdqSjNrYlVQREFlNXdWSUJQSXV3VlRMeUZnRFd2Z1k3VHpEeCtXWTRx?= =?utf-8?B?OXVlSFNpVGljUUhlR3VZZ2ZpT3I3WGJoa3NZRmVGQ1VDYWhXbnoydDJXM2o4?= =?utf-8?B?aUxzYWRoSzlOU2x1Q21XYTFRWTJXTkE0aWFZZWNKOStkNm1udkNTQzhHNVhU?= =?utf-8?Q?GP12p8n/zESfaNVRUqk4twG91IxytSGRqsiKmyG?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28630cce-ceb8-4ac2-f653-08d8f9c67380 X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2021 13:10:01.3735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Smz3mGe5/PgE/Tbhmfp7KovILLQx3GiGymFDRx4aGKKh0NnPuVGrtK+Ik7/UXfYYyWYpw9Zsxm2NK03auY8+XWhiHfo7SzajzQd872qGXO8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2734 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , openbmc@lists.ozlabs.org, "Thang Q . Nguyen" , linux-kernel@vger.kernel.org, Phong Vo , Wolfram Sang , Rob Herring , Philipp Zabel , openipmi-developer@lists.sourceforge.net, Open Source Submission , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Corey, Thank you for reviewing I'll put my respond inline below. -Quan On 02/04/2021 21:21, Corey Minyard wrote: > On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote: >> This series add support for the Aspeed specific SSIF BMC driver which >> is to perform in-band IPMI communication with the host in management >> (BMC) side. > > I don't have any specific feedback for this, but I'm wondering if it's > really necessary. > > Why can't the BMC just open the I2C device and use it? Is there any > functionality that this provides that cannot be accomplished from > userland access to the I2C device? I don't see any. > > If it tied into some existing framework to give abstract access to a BMC > slave side interface, I'd be ok with this. But I don't see that. > The SSIF at the BMC side acts as an I2C slave and we think that the kernel driver is unavoidable to handle the I2c slave events (https://www.kernel.org/doc/html/latest/i2c/slave-interface.html) And to make it works with existing OpenBMC IPMI stack, a userspace part, ssifbridge, is needed (https://github.com/openbmc/ssifbridge). This ssifbridge is to connect this driver with the OpenBMC IPMI stack so the IPMI stack can communicate via SSIF channel in similar way that was implemented with BT and KCS (ie: btbridge/kcsbridge and its corespondent kernel drivers (https://github.com/openbmc/btbridge and https://github.com/openbmc/kcsbridge)) > Unless there is a big need to have this in the kernel, I'm against > including this and would suggest you do all this work in userland. > Perhaps write a library. Sorry, but I'm trying to do my part to reduce > unnecessary things in the kernel. > > Thanks, > > -corey > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2CAC433ED for ; Wed, 7 Apr 2021 13:12:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3FA361353 for ; Wed, 7 Apr 2021 13:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3FA361353 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ycxcAWl2Y44Ngkp/ZOf4i0jF6ZMo3T6KQRjwe4nJogE=; b=rEbbKzXlbeC6f8UpM6kCqBsKm twoMzzj0xiLq+cSfUtNlDsAf+1ZUMwDlBDVkqwSX2X7Ays+k2DC3HNPjDaiNOKTDZ76wXJ7QQYr/T kXXCsecrOovsy90ChOaVZ6fpAk+Nl0+BvpUjviogaQu0qNzesHkO/G3jAX8TMMa1GnwdnL2dyEPdP y1OdH7Ca2FnMXrwYq2Q47YhgrrKKhvktkpQXnnqRIp+yNJiLXTzNHcqXv1BpKOs6oAgyll9JFDSBz 2Qwx7LlGnDRASmFjHw08AvbZb4USh6cmd3cxtCsDSlsKetFo84ST9FVKQuZ2vCtt2MtD1V2ZpqQPG 6vMSx6tZw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU7wq-0050lc-1I; Wed, 07 Apr 2021 13:10:24 +0000 Received: from mail-co1nam11on2093.outbound.protection.outlook.com ([40.107.220.93] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lU7wf-0050jz-PO for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 13:10:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sk3oi2qzDX8EhIq9+X9ys8xATAD98o/1a2J8xS104OOaztdy9fqF7byxtwC3VLzYA2gi0ka2goSJ7ZZon8dHW74ZhcaAAk0QLsO8zRkn0vUnEnmBv+7kZJl50nKXM0204+0R92CHq1tDmP3UIdZ2axAAHoMw2miDOMyMEtjI482L0nwCXCNw/tJu9JAd3ITBqUuB4ufuUfJPU0vgS9AcfF471NRXh5N8JMaRIiMHfbc8hO88wAbdAK0pDO2etsq7UWuO5L1GZudNB4LGS692EgJdfIXaZq43cFfWm8VGCqWpn1iS5fUiIe3HItPvfybb0JSDt0/BFdVHXqEQYLK3uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3a29ZpwxhPwXlxpNgVldcV+Rpnd8BsEHALPFTBp58Bw=; b=SL2ZGeqr7dXlJijfrf0cUiOMXYGawpAbYfQt7XwxHJHSoS/obHFCLwt1T8qmy/Fc1ACklBtr+YXz8tElBmHwFbMVzeNna3ByFO2AC2uMP4Ai/NNanDJtmja7GmoDT1Q5g93c++/dGsRZNA4wP7vUxaz0l+zstkVztNt71uNQPZ6pYbz5OwLhSx04zO08ohFkrDh4w/vZOS3NjvZuPOhJpobiUld42ObMwWHHeWv/N1uHwLRD0eDLqARi67qjW6aN58vl6JZKYcAOUYfTHTmbloRJzwj1ii7i5dbYC4hteuSdkNI6c2vTQEbzxi8Y13BIzNyze0l35/App5EAFECfKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3a29ZpwxhPwXlxpNgVldcV+Rpnd8BsEHALPFTBp58Bw=; b=WUJuUm6tuAu4+VisFIptbnZMfjWAu/htZ3+zntik/U2uhwT18NXYfMcSILwdMhymT2y7X/WG8OVIL8K8XcUlZaDdPx+DCsMs9Da5FRuNd+GL+ZPOWIuhfHVdKfCOmMIwf3t5eq1og6a/FBC4Gc/ggy9dJjpeT7IEsvA417bF0NI= Authentication-Results: os.amperecomputing.com; dkim=none (message not signed) header.d=none; os.amperecomputing.com; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by MWHPR01MB2734.prod.exchangelabs.com (2603:10b6:300:f6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Wed, 7 Apr 2021 13:10:02 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503%5]) with mapi id 15.20.4020.016; Wed, 7 Apr 2021 13:10:01 +0000 Subject: Re: [PATCH v2 0/3] Add Aspeed SSIF BMC driver To: minyard@acm.org Cc: Rob Herring , Joel Stanley , Andrew Jeffery , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" References: <20210330141029.20412-1-quan@os.amperecomputing.com> <20210402142124.GV507977@minyard.net> From: Quan Nguyen Message-ID: <0e7fceff-4a01-5cb0-72eb-8b47d598f1c3@os.amperecomputing.com> Date: Wed, 7 Apr 2021 20:09:50 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: <20210402142124.GV507977@minyard.net> Content-Language: en-US X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HK2P15301CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::18) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.38.33.17] (118.69.219.201) by HK2P15301CA0008.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.3 via Frontend Transport; Wed, 7 Apr 2021 13:09:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28630cce-ceb8-4ac2-f653-08d8f9c67380 X-MS-TrafficTypeDiagnostic: MWHPR01MB2734: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ETv8uoc6Dkbc7a2RBZXF5b4N2k+daHxi7QQaIIPTS9Avr+JkxHInO9D3RLbKi35tDMaEqZn6IeHxLDx8Qa0L7eFq7vxEGK+GiNTAtcHakXiO2ssMmZ+heEmICwGJjfSjrq6luuRc1EddOusCeIQAEpUEhLQoqmjFbeeRlhfgNEJJe8MiyulZPaEyD23ObhnWolXJ7ckVCYIP75e3E0gWzBBofjkcDtpATyn4LdeDCFANt4Ax2zcQBcmX/Vo6EkcFdrOEEBm1G1J2WaTc+rt0/J2ZFR5GARe3oJT1XaFHI5YzdR/JcGZdfRkFflMcf8aUK7qbyERwPo0P2dj+x47mUzz22Re5pl8YeiIwFBODIvLs1xwVMtn+hXKYOYBV0ORSMlZfKlCxVCno6/GsE3GtNt+mTjdiw2JZGx65O/Yt3yMDu04jUt7QBzjzedBBM+qVEPQV4zn+3MRd0kY6UxVXU1xw14gOz9/tYxxERB5jB8TuLMBMKNgyJQpUdlAUQN1iyX2tmoGyk3gul+u1exy73fHc0156p2ekbZQdoH66e0BHzDF1OnmOgFy2mOSdBdcMY+G9blJGzNK70VDAqvHw3iRsVDeP7Sh80EkO70eMfonIQSpabl8eN85qd+0O/IBRW6i2S4ctqdRV9E3c1hIi6FdQRWIkZrVgovKfiPHTVRUbqnC2pwRoBxrjN+XYXq3QmYKwbXwUdKUYsFBjABfKYyJDtqFuF5F4vqJWR8PPOP0/oiV6vj8ua13NuQ12giKEzEErMLU8a0u+Sh7VJbC71nBpQCFEgjhHmX0Mhq4mDO8YG1cUQju1rgidLhMTBriK1sjCpiUC8Otu9oGaNsQ3ew== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR0102MB3482.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39840400004)(136003)(396003)(376002)(366004)(53546011)(31696002)(5660300002)(83380400001)(16526019)(186003)(6916009)(2906002)(16576012)(66556008)(8676002)(54906003)(66476007)(66946007)(38350700001)(6486002)(38100700001)(8936002)(7416002)(26005)(6666004)(966005)(4326008)(107886003)(52116002)(2616005)(956004)(316002)(86362001)(31686004)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L21jd052WDV4NTE1Zm04a1FsOTIxTkVnTDVqY0xhQUpEYjhlU0NoOFVCZEJw?= =?utf-8?B?US9Qa0NnS0t4a20wM25iRGdyVHk4RjZ0bW45bW1CK3IxUUtnMWlDMmZpRzQy?= =?utf-8?B?dlp5ZXdXcFRDMEhsOGgrbU5HNEE2QzByY0l2QUE3Rll0TnhtTTdqcEYreHNq?= =?utf-8?B?Z2ZHYnFYNWp4K0pacDN2K2poMFc2SWFGdEVlNUJKcjdOQXhQeW9Oak9RMk1j?= =?utf-8?B?REtQL0llakFMU3hEUDdlRmxCVEZpL0Y3UWRhbVBxaXk3czJhY1Q4elkxY1Fv?= =?utf-8?B?WnBSc2NwdkhWc0FZd0RYVjVMSTBUbE9MU1BDZ2l0OVFsOVJibkdIVnBHYXU5?= =?utf-8?B?U05zQ1NBV2xCUGtmUlVwSy9RVFFMLzdNOUpaYkFGYjVURjkxOGp4UkxhU1Bq?= =?utf-8?B?RUEzTU5PZ1FVa3ZJK3E0d1lDeUFmcldSSXc3OUg0U2VOdVNXOExyM2NkZTIz?= =?utf-8?B?L1pIYlVGTmczNnluSzYrZk8yWGxJUklFOWtOUU9Pb0dZUG9yMkVTcStGZmwx?= =?utf-8?B?bEkrcFVFZzliazV2WDBPajVLV0FpUmhFWS8xc1ptaDFpdFVkOUZtY1JPSDRI?= =?utf-8?B?MDZ1S3Zock1vNytvQkRvR1dXVXFLWTRkM1pTaE9LeWtNb3lWUUZGVE9JNlFZ?= =?utf-8?B?VXBBdGhDYjNBYXhqMUZzQnFmZXRrbVkvU29sb3pUU3RtaVBQWFp3dS83VUJF?= =?utf-8?B?U1RIQjZJaURFSjFBVkdjMzdNYmZwNlJMQnVjWDFqTlRXanZZSVh2Z0hxc1BR?= =?utf-8?B?Q09yQ2ZjSXUzVWdpVmRPQ0l6Y1dubzllTWVhWW9mVHV1RVJ4Y1oxV3pybTNW?= =?utf-8?B?dE5DWkJyaEo2YjBpc1F3T1ptU0RxSVA4MkkxSWpnU0poSHdEaVh4Qm9nbmVa?= =?utf-8?B?SytmKzJEQ2QzMWNSNHcxSDA0Z0hVS0RPZmxhT1NhblVEbzhTTG1WalFmbDBp?= =?utf-8?B?QzVvZFIvWmNKQVZFR0NKUTdLblJqZ2RCcDgvK3c3Z0pDSWIwWnVJSnVRYVJz?= =?utf-8?B?SUNiZUNRdk80N3JOOVgwTDV1T1RUNjNyWFNURnIyRTdLZnpxNlNkclUyTGJh?= =?utf-8?B?K3psSTVOeFpaN3NhdEJET2FZY3VDT2x6QkxXeHp3a3JyWmtPZ29iYzBVRXRM?= =?utf-8?B?SDRMN3VSYS9KWXFxcmFKMXBIRDZ4QlZ2VVRXS0xlNlRxUTQ2RFBQeFlLSGxo?= =?utf-8?B?UUwzWDF2ZFdWWm9PUURIUXB0dmkwU0FOaXA5V2VEZG9NYTZLeGZxdEhpRWJq?= =?utf-8?B?QjE2WTF4L0NYclVUSXdMb3hUNnVOWWIwT00vbGN2cittMkFmbndENldHN1RE?= =?utf-8?B?QmdUNjJzak15Qmhmenl6NEJBc2xXS3V5NFJuZUV4aWloazVyRlFvTzAyUFFZ?= =?utf-8?B?WDM0Q2hxeVZSL1JTcXZTaXhrVE5qbDhhNmJYczV1Vm1LYWhMelBIamF5SnAz?= =?utf-8?B?eXFwZ3lyOFJRZ0o5ZUp3UExkSEZkbnlUYm1SNHdlYUxYT0VYdjUzWEpDZnVU?= =?utf-8?B?bU13cSszSlA4dWpqV04vbTVaS2ppRm1xZFhkcEJYY0lxTU42TmNiUmltQjRp?= =?utf-8?B?bGhUSjdqSjNrYlVQREFlNXdWSUJQSXV3VlRMeUZnRFd2Z1k3VHpEeCtXWTRx?= =?utf-8?B?OXVlSFNpVGljUUhlR3VZZ2ZpT3I3WGJoa3NZRmVGQ1VDYWhXbnoydDJXM2o4?= =?utf-8?B?aUxzYWRoSzlOU2x1Q21XYTFRWTJXTkE0aWFZZWNKOStkNm1udkNTQzhHNVhU?= =?utf-8?Q?GP12p8n/zESfaNVRUqk4twG91IxytSGRqsiKmyG?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28630cce-ceb8-4ac2-f653-08d8f9c67380 X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2021 13:10:01.3735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Smz3mGe5/PgE/Tbhmfp7KovILLQx3GiGymFDRx4aGKKh0NnPuVGrtK+Ik7/UXfYYyWYpw9Zsxm2NK03auY8+XWhiHfo7SzajzQd872qGXO8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR01MB2734 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_141015_381637_149173FB X-CRM114-Status: GOOD ( 24.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Corey, Thank you for reviewing I'll put my respond inline below. -Quan On 02/04/2021 21:21, Corey Minyard wrote: > On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote: >> This series add support for the Aspeed specific SSIF BMC driver which >> is to perform in-band IPMI communication with the host in management >> (BMC) side. > > I don't have any specific feedback for this, but I'm wondering if it's > really necessary. > > Why can't the BMC just open the I2C device and use it? Is there any > functionality that this provides that cannot be accomplished from > userland access to the I2C device? I don't see any. > > If it tied into some existing framework to give abstract access to a BMC > slave side interface, I'd be ok with this. But I don't see that. > The SSIF at the BMC side acts as an I2C slave and we think that the kernel driver is unavoidable to handle the I2c slave events (https://www.kernel.org/doc/html/latest/i2c/slave-interface.html) And to make it works with existing OpenBMC IPMI stack, a userspace part, ssifbridge, is needed (https://github.com/openbmc/ssifbridge). This ssifbridge is to connect this driver with the OpenBMC IPMI stack so the IPMI stack can communicate via SSIF channel in similar way that was implemented with BT and KCS (ie: btbridge/kcsbridge and its corespondent kernel drivers (https://github.com/openbmc/btbridge and https://github.com/openbmc/kcsbridge)) > Unless there is a big need to have this in the kernel, I'm against > including this and would suggest you do all this work in userland. > Perhaps write a library. Sorry, but I'm trying to do my part to reduce > unnecessary things in the kernel. > > Thanks, > > -corey > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel