All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: qiangqing.zhang@nxp.com, kernel@pengutronix.de,
	linux-can@vger.kernel.org
Subject: Re: [PATCH 20/20] can: flexcan: add lx2160ar1 support
Date: Wed, 23 Sep 2020 10:02:52 +0200	[thread overview]
Message-ID: <0e90e8234d38830749ad8de380837eb2@walle.cc> (raw)
In-Reply-To: <5b3c07ab-ca8c-d43d-f4e0-7155d358648d@pengutronix.de>

Am 2020-09-23 09:54, schrieb Marc Kleine-Budde:
> On 9/23/20 9:45 AM, Michael Walle wrote:
>> Hi Joakim, Hi Marc,
>> 
>> Am 2020-09-22 16:44, schrieb Marc Kleine-Budde:
>>> From: Joakim Zhang <qiangqing.zhang@nxp.com>
>>> 
>>> The Flexcan on lx2160ar1 supports CAN FD protocol.
>>> 
>>> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
>>> Link:
>>> https://lore.kernel.org/r/20190712075926.7357-9-qiangqing.zhang@nxp.com
>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>>> ---
>>>  drivers/net/can/flexcan.c | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>> 
>>> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
>>> index 5f778c961a0c..e86925134009 100644
>>> --- a/drivers/net/can/flexcan.c
>>> +++ b/drivers/net/can/flexcan.c
>>> @@ -216,6 +216,7 @@
>>>   *   MX8QM FlexCAN3  03.00.23.00    yes       yes        no       no
>>>      yes          yes
>>>   *   VF610 FlexCAN3  ?               no       yes        no      yes
>>>      yes?          no
>>>   * LS1021A FlexCAN2  03.00.04.00     no       yes        no       no
>>>      yes           no
>>> + * LX2160A FlexCAN3  03.00.23.00     no       yes        no       no
>>>      yes          yes
>> 
>> I'd really like to see LS1028A support. At the moment, I'm having the
>> following additional patch for the ls1028a device tree.
>> 
>> can0: can@2180000 {
>>      compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
>                                               ^^^^^^^^^^^^^^^^^^^^^
>>      reg = <0x0 0x2180000 0x0 0x10000>;
>>      interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
>>                    clocks = <&sysclk>, <&clockgen 4 1>;
>>                    clock-names = "ipg", "per";
>>                    status = "disabled";
>> };
>> 
>> Do we need to add a dedicated compatible entry for the LS1028A
>> the driver?
> 
> At the end of the series, there are the following compatibles:
> 
>> static const struct of_device_id flexcan_of_match[] = {
>> 	{ .compatible = "fsl,imx8qm-flexcan", .data = 
>> &fsl_imx8qm_devtype_data, },
>> 	{ .compatible = "fsl,imx6q-flexcan", .data = &fsl_imx6q_devtype_data, 
>> },
>> 	{ .compatible = "fsl,imx28-flexcan", .data = &fsl_imx28_devtype_data, 
>> },
>> 	{ .compatible = "fsl,imx53-flexcan", .data = &fsl_imx25_devtype_data, 
>> },
>> 	{ .compatible = "fsl,imx35-flexcan", .data = &fsl_imx25_devtype_data, 
>> },
>> 	{ .compatible = "fsl,imx25-flexcan", .data = &fsl_imx25_devtype_data, 
>> },
>> 	{ .compatible = "fsl,p1010-flexcan", .data = &fsl_p1010_devtype_data, 
>> },
>> 	{ .compatible = "fsl,vf610-flexcan", .data = &fsl_vf610_devtype_data, 
>> },
>> 	{ .compatible = "fsl,ls1021ar2-flexcan", .data = 
>> &fsl_ls1021a_r2_devtype_data, },
>> 	{ .compatible = "fsl,lx2160ar1-flexcan", .data = 
>> &fsl_lx2160a_r1_devtype_data, },
>                          ^^^^^^^^^^^^^^^^^^^^^
>> 	{ /* sentinel */ },
>> };
> 
> The compatible of your can device matches the one listed in
> the driver. So there's no need for the "fsl,ls1028ar1-flexcan"
> in the driver.
> 
> If it turns out, that the "fsl,ls1028ar1-flexcan" needs
> different handling than the "fsl,lx2160ar1-flexcan", we would
> add it with different quirks to the driver.

That was what I was asking. Ie. if Joakim already knows any and
if it makes sense to have some added right now.

And maybe you/he want to see the LS1028A added to the table in
the header of the file. I've had a look at the vendor manual but
couldn't even find the IP version. Seems to me that only Joakim
is able to fill out that row ;)

-michael

  reply	other threads:[~2020-09-23  8:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 14:44 [RFC]: flexcan FD support - can-next 2020-09-22 Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 01/20] can: flexcan: sort include files alphabetically Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 02/20] can: flexcan: flexcan_exit_stop_mode(): remove stray empty line Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 03/20] can: flexcan: more register names Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 04/20] can: flexcan: struct flexcan_regs: document registers not affected by soft reset Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 05/20] can: flexcan: quirks: get rid of long lines Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 06/20] can: flexcan: Ack wakeup interrupt separately Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 07/20] can: flexcan: flexcan_probe(): make regulator xceiver optional Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 08/20] can: flexcan: Add check for transceiver maximum bitrate limitation Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 09/20] can: flexcan: add correctable errors correction when HW supports ECC Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 10/20] can: flexcan: flexcan_chip_stop(): add error handling and propagate error value Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 11/20] can: flexcan: disable clocks during stop mode Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 12/20] can: flexcan: add LPSR mode support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 13/20] can: flexcan: flexcan_set_bittiming(): move setup of CAN-2.0 bitiming into separate function Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 14/20] can: flexcan: use struct canfd_frame for CAN classic frame Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 15/20] can: flexcan: add CAN-FD mode support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 16/20] can: flexcan: add ISO CAN FD feature support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 17/20] can: flexcan: add CAN FD BRS support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 18/20] can: flexcan: add Transceiver Delay Compensation support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 19/20] can: flexcan: add imx8qm support Marc Kleine-Budde
2020-09-22 14:44 ` [PATCH 20/20] can: flexcan: add lx2160ar1 support Marc Kleine-Budde
2020-09-23  7:45   ` Michael Walle
2020-09-23  7:54     ` Marc Kleine-Budde
2020-09-23  8:02       ` Michael Walle [this message]
2020-09-23  8:10         ` Marc Kleine-Budde
2020-09-23  8:31           ` Joakim Zhang
2020-09-23  8:58             ` Marc Kleine-Budde
2020-09-23  9:38               ` Michael Walle
2020-09-23  9:50               ` Joakim Zhang
2020-09-23  8:53 pull-request: can-next 2020-09-23 Marc Kleine-Budde
2020-09-23  8:54 ` [PATCH 20/20] can: flexcan: add lx2160ar1 support Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e90e8234d38830749ad8de380837eb2@walle.cc \
    --to=michael@walle.cc \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=qiangqing.zhang@nxp.com \
    --subject='Re: [PATCH 20/20] can: flexcan: add lx2160ar1 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.