From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09A2C433E1 for ; Thu, 20 Aug 2020 23:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADE7A20748 for ; Thu, 20 Aug 2020 23:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgHTX0i (ORCPT ); Thu, 20 Aug 2020 19:26:38 -0400 Received: from mga11.intel.com ([192.55.52.93]:38455 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728498AbgHTX0h (ORCPT ); Thu, 20 Aug 2020 19:26:37 -0400 IronPort-SDR: NvRIFNIpo3jGD8iw2mXPYOAWx7JBEwY6CI67vcX3ujVI9NrDJCn769lovDmafHNZtISfdfOGmG EUacAGIMsIqg== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="153030831" X-IronPort-AV: E=Sophos;i="5.76,334,1592895600"; d="scan'208";a="153030831" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 16:26:37 -0700 IronPort-SDR: 9Ky8mvGz0EN6h1i76ZR7v1lvNDl6DrRr3zpNs9V+NYGDw4SEgSPFiy5VWkb1qrPkhvjvx+kJ6N Hj1MJ1KtOSww== X-IronPort-AV: E=Sophos;i="5.76,334,1592895600"; d="scan'208";a="472830363" Received: from unknown (HELO dwf-u18040) ([10.232.115.15]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 16:26:36 -0700 Message-ID: <0e911fce1c5c6f7dc01263ecdc280e76a0ea202f.camel@linux.intel.com> Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append From: David Fugate Reply-To: david.fugate@linux.intel.com To: Keith Busch Cc: Jens Axboe , Christoph Hellwig , Kanchan Joshi , "Damien.LeMoal@wdc.com" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "johannes.thumshirn@wdc.com" , Nitesh Shetty , SelvaKumar S , Javier Gonzalez , david.fugate@intel.com Date: Thu, 20 Aug 2020 17:26:35 -0600 In-Reply-To: <20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com> References: <20200818052936.10995-1-joshi.k@samsung.com> <20200818052936.10995-3-joshi.k@samsung.com> <20200818071249.GB2544@lst.de> <9fa64efe-8477-5d33-20ed-9619a9fe8d70@kernel.dk> <20200819221054.GB26818@dhcp-10-100-145-180.wdl.wdc.com> <20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-08-20 at 12:45 +0900, Keith Busch wrote: > For the record, the suggestion provided, which you agreed to look > into, > most broadly enables your hardware on Linux and was entirely to your > benefit. Not quite as dramatic as a political conspiracy. > > You later responded with a technical argument against that > suggestion; > however, your reason didn't add up, and that's where you left the > thread. The suggestion to the rejected patch was passed onto the related FW team, and the "technical argument" was our FW team's response to the suggestion which I relayed to the list. At this point, there's no closure on whether the device will get NOIOB. My point in bringing up this example was a one-line, highly- maintainable patch which improves the performance of Linux should not have been immediatedly NAK'ed as it was. If you believe it should have, we'll agree to disagree. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D63C433DF for ; Thu, 20 Aug 2020 23:26:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CE3E20748 for ; Thu, 20 Aug 2020 23:26:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q/gD53Pr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CE3E20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:Reply-To:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8UDm7698tOEDUaIDXfJoqXm4t3pfhS6UCj7ybCIOKZ4=; b=Q/gD53Prq4etzziuCV6TjlMkhN bUDvCfVQfFQI05gGw+L45hPYiYPBTzrkZTR1tbW/CjO0qqhSrvNh/2WgdZCvocTdyRztIzw+sVXom B0RiD3fls7JecoVJIABq0JQIc++BQe7xtdhBMmEgj+1BTKy1aWvj3vIvZkgeYuTX7bR5UtNelz6yL h8rWugmBsmR8QCuibhPUbv6W9ubTADyHm1oasUfnSnl7YRwY+oLUTtzgq0VCwbOi2eMYYCSaEzfC1 VAdqCBzO7qQi1JX++yWzIJQREr1xRl+e+mYfDqJiwcMUygAXIl71fdu682ElQT842+khQhV5geNKO /udH43LQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8txE-0002Z5-Ew; Thu, 20 Aug 2020 23:26:44 +0000 Received: from mga06.intel.com ([134.134.136.31]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8txB-0002YS-2l for linux-nvme@lists.infradead.org; Thu, 20 Aug 2020 23:26:42 +0000 IronPort-SDR: LOGbB0YLCHraJ69YSSHrzEy6waR5DctCFE+EsZiXH4to2oqdlyVdKEtaSMe/Uvm3LlyXWb4Gxf ZCOl3EwYrVdA== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="216962892" X-IronPort-AV: E=Sophos;i="5.76,334,1592895600"; d="scan'208";a="216962892" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 16:26:37 -0700 IronPort-SDR: 9Ky8mvGz0EN6h1i76ZR7v1lvNDl6DrRr3zpNs9V+NYGDw4SEgSPFiy5VWkb1qrPkhvjvx+kJ6N Hj1MJ1KtOSww== X-IronPort-AV: E=Sophos;i="5.76,334,1592895600"; d="scan'208";a="472830363" Received: from unknown (HELO dwf-u18040) ([10.232.115.15]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 16:26:36 -0700 Message-ID: <0e911fce1c5c6f7dc01263ecdc280e76a0ea202f.camel@linux.intel.com> Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append From: David Fugate To: Keith Busch Date: Thu, 20 Aug 2020 17:26:35 -0600 In-Reply-To: <20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com> References: <20200818052936.10995-1-joshi.k@samsung.com> <20200818052936.10995-3-joshi.k@samsung.com> <20200818071249.GB2544@lst.de> <9fa64efe-8477-5d33-20ed-9619a9fe8d70@kernel.dk> <20200819221054.GB26818@dhcp-10-100-145-180.wdl.wdc.com> <20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com> Organization: Intel X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200820_192641_262490_8CA14050 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: david.fugate@linux.intel.com Cc: Jens Axboe , "Damien.LeMoal@wdc.com" , SelvaKumar S , "sagi@grimberg.me" , Kanchan Joshi , "johannes.thumshirn@wdc.com" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Nitesh Shetty , david.fugate@intel.com, Javier Gonzalez , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, 2020-08-20 at 12:45 +0900, Keith Busch wrote: > For the record, the suggestion provided, which you agreed to look > into, > most broadly enables your hardware on Linux and was entirely to your > benefit. Not quite as dramatic as a political conspiracy. > > You later responded with a technical argument against that > suggestion; > however, your reason didn't add up, and that's where you left the > thread. The suggestion to the rejected patch was passed onto the related FW team, and the "technical argument" was our FW team's response to the suggestion which I relayed to the list. At this point, there's no closure on whether the device will get NOIOB. My point in bringing up this example was a one-line, highly- maintainable patch which improves the performance of Linux should not have been immediatedly NAK'ed as it was. If you believe it should have, we'll agree to disagree. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme