From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrice CHOTARD Date: Thu, 2 Aug 2018 12:14:04 +0000 Subject: [U-Boot] [PATCH] ram: stm32_sdram: Adds stm32f746-disco fix for HardFault at booting In-Reply-To: <3d9e7657-61df-4287-f663-5f81ed97a46a@st.com> References: <20180801110827.1442-1-post@markolsson.se> <01020164f52d0cd2-bca1d59b-80c9-49ea-b297-2bec8b9dc777-000000@eu-west-1.amazonses.com> <3d9e7657-61df-4287-f663-5f81ed97a46a@st.com> Message-ID: <0e9c3fd6-2fe8-1fe6-a4e0-bf413c9faa6d@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi again Mark ;-) I dig into this issue and i think a better fix must be done directly into the board/st/stm32f746-disco/stm32f746-disco.c. At the same occasion, some cleaning can be done using last fdtdec_xxx() API. I will submit a patch for that which fix the issue you saw. Thanks Patrice On 08/02/2018 12:39 PM, Patrice CHOTARD wrote: > Hi Mark > > +Vikas > > On 08/01/2018 01:08 PM, Mark Olsson wrote: >> - changes ram start address to 0xC0000000 > > In the commit header, indicate that this patch is a fix > > Indicates also in the commit message that this patch fixes a regression > by adding the commit which brings this regression : > > Commit 1473b12ad0b3 ("lib: fdtdec: Update ram_base to store ram start > adddress") blablabla > > >> >> Signed-off-by: Mark Olsson >> Cc: Vipin Kumar > > For information, don't forget to add maintainers in To: by using > get_maintainer script as following: > > ./scripts/get_maintainer.pl -f include/configs/stm32f746-disco.h > Vikas Manocha (maintainer:STM32F746 DISCOVERY BOARD) > u-boot at lists.denx.de (open list) > >> --- >> include/configs/stm32f746-disco.h | 2 ++ >> 1 file changed, 2 insertions(+) >> mode change 100644 => 100755 include/configs/stm32f746-disco.h >> >> diff --git a/include/configs/stm32f746-disco.h b/include/configs/stm32f746-disco.h >> old mode 100644 >> new mode 100755 >> index 567e7f2a00..238d4e939f >> --- a/include/configs/stm32f746-disco.h >> +++ b/include/configs/stm32f746-disco.h >> @@ -21,6 +21,8 @@ >> * Configuration of the external SDRAM memory >> */ >> #define CONFIG_NR_DRAM_BANKS 1 >> +#define CONFIG_SYS_RAM_BASE 0xC0000000 >> +#define CONFIG_SYS_SDRAM_BASE CONFIG_SYS_RAM_BASE >> >> #define CONFIG_SYS_MAX_FLASH_SECT 8 >> #define CONFIG_SYS_MAX_FLASH_BANKS 1 >> > > > Thanks for your patch. > > Patrice > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > https://lists.denx.de/listinfo/u-boot >