From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E772C4727C for ; Wed, 30 Sep 2020 16:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C770520888 for ; Wed, 30 Sep 2020 16:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731214AbgI3QKP (ORCPT ); Wed, 30 Sep 2020 12:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727681AbgI3QKO (ORCPT ); Wed, 30 Sep 2020 12:10:14 -0400 Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41402C061755 for ; Wed, 30 Sep 2020 09:10:14 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C1h6s0gDHz1rwDm; Wed, 30 Sep 2020 18:10:13 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C1h6r6flRz1sM9L; Wed, 30 Sep 2020 18:10:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id OdE_t_nmycK2; Wed, 30 Sep 2020 18:10:11 +0200 (CEST) X-Auth-Info: lqBrlfKTtG9CMheJ5tZcLFHMALKD/4tLxgLxKsJE9n0= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 Sep 2020 18:10:11 +0200 (CEST) Subject: Re: [PATCH 03/11] soc: imx: gpcv2: split power up and power down sequence control To: Lucas Stach , Shawn Guo , Rob Herring Cc: NXP Linux Team , Fabio Estevam , Frieder Schrempf , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-4-l.stach@pengutronix.de> From: Marek Vasut Message-ID: <0ea7824e-cf21-2180-1fa1-6b691d85faca@denx.de> Date: Wed, 30 Sep 2020 18:10:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930155006.535712-4-l.stach@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/30/20 5:49 PM, Lucas Stach wrote: [...] > @@ -149,69 +148,111 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, > } > > /* Enable reset clocks for all devices in the domain */ > + for (i = 0; i < domain->num_clks; i++) { > + ret = clk_prepare_enable(domain->clk[i]); > + if (ret) { > + dev_err(domain->dev, "failed to enable clock %d\n", i); > + goto out_clk_disable; > + } > + } Can we use clk_bulk functions here ? [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E52C4727C for ; Wed, 30 Sep 2020 16:11:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1B78206F7 for ; Wed, 30 Sep 2020 16:11:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z/E+nMxI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1B78206F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2HFtmVf8CqJRAAb5/cZEzrvF44HvCm3YWSKMPa1zna0=; b=Z/E+nMxIQ5WncOxOdBx6thJ1H BBtlfUXSEDSgyHVD/JJEPe0IVNfRhx3cnx94nwNL4qvZLvDuuIesSwa0TyhHmngAyVgFkgPE3CAII P4iG2mO8lcZ9eY3ZI93wDh9cSjskyP5BUhq0bPUPOdbOlJ2VRtIDJ7QNY9IDJaWkIg+d16DgCJKbO bGFvUxjetDUrwSSl6Gdxw1ekDR83oko6W4GOUP+UvJNTp9m3zxSMoa3fgnpehtrQ8tVeXOesdEEBQ NJe938vCWdu+2CsUwvvWtVLiwcaf45EgJI0zDBCHdaony1W+SMeeIKAbPTK+ieV/KMpC8LIBCaQ/n lrvSrmOMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNegK-0007d3-9k; Wed, 30 Sep 2020 16:10:16 +0000 Received: from mail-out.m-online.net ([212.18.0.10]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNegI-0007cA-2d for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 16:10:14 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C1h6s0gDHz1rwDm; Wed, 30 Sep 2020 18:10:13 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C1h6r6flRz1sM9L; Wed, 30 Sep 2020 18:10:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id OdE_t_nmycK2; Wed, 30 Sep 2020 18:10:11 +0200 (CEST) X-Auth-Info: lqBrlfKTtG9CMheJ5tZcLFHMALKD/4tLxgLxKsJE9n0= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 Sep 2020 18:10:11 +0200 (CEST) Subject: Re: [PATCH 03/11] soc: imx: gpcv2: split power up and power down sequence control To: Lucas Stach , Shawn Guo , Rob Herring References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-4-l.stach@pengutronix.de> From: Marek Vasut Message-ID: <0ea7824e-cf21-2180-1fa1-6b691d85faca@denx.de> Date: Wed, 30 Sep 2020 18:10:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930155006.535712-4-l.stach@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_121014_235298_D09B07A6 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Frieder Schrempf , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/20 5:49 PM, Lucas Stach wrote: [...] > @@ -149,69 +148,111 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct generic_pm_domain *genpd, > } > > /* Enable reset clocks for all devices in the domain */ > + for (i = 0; i < domain->num_clks; i++) { > + ret = clk_prepare_enable(domain->clk[i]); > + if (ret) { > + dev_err(domain->dev, "failed to enable clock %d\n", i); > + goto out_clk_disable; > + } > + } Can we use clk_bulk functions here ? [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel