From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6136DC43331 for ; Thu, 7 Nov 2019 22:07:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0F12120869 for ; Thu, 7 Nov 2019 22:07:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="czSKze3j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F12120869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB8CE6B0005; Thu, 7 Nov 2019 17:07:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C69196B0006; Thu, 7 Nov 2019 17:07:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5A7D6B0007; Thu, 7 Nov 2019 17:07:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 9DDC86B0005 for ; Thu, 7 Nov 2019 17:07:38 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 5399F1EF0 for ; Thu, 7 Nov 2019 22:07:38 +0000 (UTC) X-FDA: 76130868996.03.paper17_427c140457c45 X-HE-Tag: paper17_427c140457c45 X-Filterd-Recvd-Size: 7556 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 22:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573164455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gIBG5GMIReYQpS3U1ws59fK/jF+FBXDJRRxLPPFv3ms=; b=czSKze3jDZExFyu7+VF1A9unedZ4AmaM/FPc7XsPpG7zpUhRww3+lN5jSHXIvCScCf4z4u gwPF39FeBkI2RKry2V4WpFv0NRvkqXRUlMI40qBBM/Bm3VUxZK/CAcALetlnsdxnASB3jA RwSvFXiHaE7RJEKKj+DplhmJsQOpdfw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-U5XuV8_tOUWYRd6dFnpBtA-1; Thu, 07 Nov 2019 17:07:34 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4A64477; Thu, 7 Nov 2019 22:07:28 +0000 (UTC) Received: from [10.36.116.80] (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1309E600D3; Thu, 7 Nov 2019 22:07:10 +0000 (UTC) Subject: Re: [PATCH v1 04/10] vfio/type1: Prepare is_invalid_reserved_pfn() for PG_reserved changes To: David Hildenbrand , Dan Williams Cc: Linux Kernel Mailing List , Linux MM , Michal Hocko , Andrew Morton , kvm-ppc@vger.kernel.org, linuxppc-dev , KVM list , linux-hyperv@vger.kernel.org, devel@driverdev.osuosl.org, xen-devel , X86 ML , Alexander Duyck , Alexander Duyck , Alex Williamson , Allison Randal , Andy Lutomirski , "Aneesh Kumar K.V" , Anshuman Khandual , Anthony Yznaga , Benjamin Herrenschmidt , Borislav Petkov , Boris Ostrovsky , Christophe Leroy , Cornelia Huck , Dave Hansen , Haiyang Zhang , "H. Peter Anvin" , Ingo Molnar , "Isaac J. Manjarres" , Jim Mattson , Joerg Roedel , Johannes Weiner , Juergen Gross , KarimAllah Ahmed , Kees Cook , "K. Y. Srinivasan" , "Matthew Wilcox (Oracle)" , Matt Sickler , Mel Gorman , Michael Ellerman , Michal Hocko , Mike Rapoport , Mike Rapoport , Nicholas Piggin , Oscar Salvador , Paolo Bonzini , Paul Mackerras , Paul Mackerras , Pavel Tatashin , Pavel Tatashin , Peter Zijlstra , Qian Cai , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Sasha Levin , Sean Christopherson , Stefano Stabellini , Stephen Hemminger , Thomas Gleixner , Vitaly Kuznetsov , Vlastimil Babka , Wanpeng Li , YueHaibing References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <0eb001e0-bb26-59bb-c514-d2f8a86a7eab@redhat.com> Date: Thu, 7 Nov 2019 23:07:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: U5XuV8_tOUWYRd6dFnpBtA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.11.19 19:22, David Hildenbrand wrote: >=20 >=20 >> Am 07.11.2019 um 16:40 schrieb Dan Williams : >> >> =EF=BB=BFOn Thu, Oct 24, 2019 at 5:12 AM David Hildenbrand wrote: >>> >>> Right now, ZONE_DEVICE memory is always set PG_reserved. We want to >>> change that. >>> >>> KVM has this weird use case that you can map anything from /dev/mem >>> into the guest. pfn_valid() is not a reliable check whether the memmap >>> was initialized and can be touched. pfn_to_online_page() makes sure >>> that we have an initialized memmap (and don't have ZONE_DEVICE memory). >>> >>> Rewrite is_invalid_reserved_pfn() similar to kvm_is_reserved_pfn() to m= ake >>> sure the function produces the same result once we stop setting ZONE_DE= VICE >>> pages PG_reserved. >>> >>> Cc: Alex Williamson >>> Cc: Cornelia Huck >>> Signed-off-by: David Hildenbrand >>> --- >>> drivers/vfio/vfio_iommu_type1.c | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_= type1.c >>> index 2ada8e6cdb88..f8ce8c408ba8 100644 >>> --- a/drivers/vfio/vfio_iommu_type1.c >>> +++ b/drivers/vfio/vfio_iommu_type1.c >>> @@ -299,9 +299,15 @@ static int vfio_lock_acct(struct vfio_dma *dma, lo= ng npage, bool async) >>> */ >>> static bool is_invalid_reserved_pfn(unsigned long pfn) >>> { >>> - if (pfn_valid(pfn)) >>> - return PageReserved(pfn_to_page(pfn)); >>> + struct page *page =3D pfn_to_online_page(pfn); >> >> Ugh, I just realized this is not a safe conversion until >> pfn_to_online_page() is moved over to subsection granularity. As it >> stands it will return true for any ZONE_DEVICE pages that share a >> section with boot memory. >=20 > That should not happen right now and I commented back when you introduced= subsection support that I don=E2=80=99t want to have ZONE_DEVICE mixed wit= h online pages in a section. Having memory block devices that partially spa= n ZONE_DEVICE would be ... really weird. With something like pfn_active() -= as discussed - we could at least make this check work - but I am not sure = if we really want to go down that path. In the worst case, some MB of RAM a= re lost ... I guess this needs more thought. >=20 I just realized the "boot memory" part. Is that a real thing? IOW, can=20 we have ZONE_DEVICE falling into a memory block (with holes)? I somewhat=20 have doubts that this would work ... --=20 Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B43C5DF60 for ; Thu, 7 Nov 2019 22:07:41 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60B9E214D8 for ; Thu, 7 Nov 2019 22:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="czSKze3j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60B9E214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2057E86429; Thu, 7 Nov 2019 22:07:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LDPgZ9sAD9Sr; Thu, 7 Nov 2019 22:07:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 3FCA786420; Thu, 7 Nov 2019 22:07:40 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 33EF71BF3B0 for ; Thu, 7 Nov 2019 22:07:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2787886420 for ; Thu, 7 Nov 2019 22:07:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q334FiTKdWum for ; Thu, 7 Nov 2019 22:07:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by whitealder.osuosl.org (Postfix) with ESMTPS id B395A862E1 for ; Thu, 7 Nov 2019 22:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573164455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gIBG5GMIReYQpS3U1ws59fK/jF+FBXDJRRxLPPFv3ms=; b=czSKze3jDZExFyu7+VF1A9unedZ4AmaM/FPc7XsPpG7zpUhRww3+lN5jSHXIvCScCf4z4u gwPF39FeBkI2RKry2V4WpFv0NRvkqXRUlMI40qBBM/Bm3VUxZK/CAcALetlnsdxnASB3jA RwSvFXiHaE7RJEKKj+DplhmJsQOpdfw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-U5XuV8_tOUWYRd6dFnpBtA-1; Thu, 07 Nov 2019 17:07:34 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4A64477; Thu, 7 Nov 2019 22:07:28 +0000 (UTC) Received: from [10.36.116.80] (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1309E600D3; Thu, 7 Nov 2019 22:07:10 +0000 (UTC) Subject: Re: [PATCH v1 04/10] vfio/type1: Prepare is_invalid_reserved_pfn() for PG_reserved changes To: David Hildenbrand , Dan Williams References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <0eb001e0-bb26-59bb-c514-d2f8a86a7eab@redhat.com> Date: Thu, 7 Nov 2019 23:07:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: U5XuV8_tOUWYRd6dFnpBtA-1 X-Mimecast-Spam-Score: 0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Michal Hocko , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list , Pavel Tatashin , KarimAllah Ahmed , Benjamin Herrenschmidt , Dave Hansen , Alexander Duyck , Michal Hocko , Paul Mackerras , Linux MM , Paul Mackerras , Michael Ellerman , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , Thomas Gleixner , Kees Cook , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , X86 ML , YueHaibing , "Matthew Wilcox \(Oracle\)" , Mike Rapoport , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Anthony Yznaga , Oscar Salvador , "Isaac J. Manjarres" , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Sasha Levin , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , Borislav Petkov , Nicholas Piggin , Andy Lutomirski , xen-devel , Boris Ostrovsky , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Christophe Leroy , Mel Gorman , Cornelia Huck , Pavel Tatashin , Linux Kernel Mailing List , Sean Christopherson , Johannes Weiner , Paolo Bonzini , Andrew Morton , linuxppc-dev Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gMDcuMTEuMTkgMTk6MjIsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOgo+IAo+IAo+PiBBbSAw Ny4xMS4yMDE5IHVtIDE2OjQwIHNjaHJpZWIgRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0Bp bnRlbC5jb20+Ogo+Pgo+PiDvu79PbiBUaHUsIE9jdCAyNCwgMjAxOSBhdCA1OjEyIEFNIERhdmlk IEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQuY29tPiB3cm90ZToKPj4+Cj4+PiBSaWdodCBub3cs IFpPTkVfREVWSUNFIG1lbW9yeSBpcyBhbHdheXMgc2V0IFBHX3Jlc2VydmVkLiBXZSB3YW50IHRv Cj4+PiBjaGFuZ2UgdGhhdC4KPj4+Cj4+PiBLVk0gaGFzIHRoaXMgd2VpcmQgdXNlIGNhc2UgdGhh dCB5b3UgY2FuIG1hcCBhbnl0aGluZyBmcm9tIC9kZXYvbWVtCj4+PiBpbnRvIHRoZSBndWVzdC4g cGZuX3ZhbGlkKCkgaXMgbm90IGEgcmVsaWFibGUgY2hlY2sgd2hldGhlciB0aGUgbWVtbWFwCj4+ PiB3YXMgaW5pdGlhbGl6ZWQgYW5kIGNhbiBiZSB0b3VjaGVkLiBwZm5fdG9fb25saW5lX3BhZ2Uo KSBtYWtlcyBzdXJlCj4+PiB0aGF0IHdlIGhhdmUgYW4gaW5pdGlhbGl6ZWQgbWVtbWFwIChhbmQg ZG9uJ3QgaGF2ZSBaT05FX0RFVklDRSBtZW1vcnkpLgo+Pj4KPj4+IFJld3JpdGUgaXNfaW52YWxp ZF9yZXNlcnZlZF9wZm4oKSBzaW1pbGFyIHRvIGt2bV9pc19yZXNlcnZlZF9wZm4oKSB0byBtYWtl Cj4+PiBzdXJlIHRoZSBmdW5jdGlvbiBwcm9kdWNlcyB0aGUgc2FtZSByZXN1bHQgb25jZSB3ZSBz dG9wIHNldHRpbmcgWk9ORV9ERVZJQ0UKPj4+IHBhZ2VzIFBHX3Jlc2VydmVkLgo+Pj4KPj4+IENj OiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tPgo+Pj4gQ2M6IENv cm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTogRGF2aWQg SGlsZGVuYnJhbmQgPGRhdmlkQHJlZGhhdC5jb20+Cj4+PiAtLS0KPj4+IGRyaXZlcnMvdmZpby92 ZmlvX2lvbW11X3R5cGUxLmMgfCAxMCArKysrKysrKy0tCj4+PiAxIGZpbGUgY2hhbmdlZCwgOCBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIGIvZHJpdmVycy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEu Ywo+Pj4gaW5kZXggMmFkYThlNmNkYjg4Li5mOGNlOGM0MDhiYTggMTAwNjQ0Cj4+PiAtLS0gYS9k cml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jCj4+PiArKysgYi9kcml2ZXJzL3ZmaW8vdmZp b19pb21tdV90eXBlMS5jCj4+PiBAQCAtMjk5LDkgKzI5OSwxNSBAQCBzdGF0aWMgaW50IHZmaW9f bG9ja19hY2N0KHN0cnVjdCB2ZmlvX2RtYSAqZG1hLCBsb25nIG5wYWdlLCBib29sIGFzeW5jKQo+ Pj4gICAqLwo+Pj4gc3RhdGljIGJvb2wgaXNfaW52YWxpZF9yZXNlcnZlZF9wZm4odW5zaWduZWQg bG9uZyBwZm4pCj4+PiB7Cj4+PiAtICAgICAgIGlmIChwZm5fdmFsaWQocGZuKSkKPj4+IC0gICAg ICAgICAgICAgICByZXR1cm4gUGFnZVJlc2VydmVkKHBmbl90b19wYWdlKHBmbikpOwo+Pj4gKyAg ICAgICBzdHJ1Y3QgcGFnZSAqcGFnZSA9IHBmbl90b19vbmxpbmVfcGFnZShwZm4pOwo+Pgo+PiBV Z2gsIEkganVzdCByZWFsaXplZCB0aGlzIGlzIG5vdCBhIHNhZmUgY29udmVyc2lvbiB1bnRpbAo+ PiBwZm5fdG9fb25saW5lX3BhZ2UoKSBpcyBtb3ZlZCBvdmVyIHRvIHN1YnNlY3Rpb24gZ3JhbnVs YXJpdHkuIEFzIGl0Cj4+IHN0YW5kcyBpdCB3aWxsIHJldHVybiB0cnVlIGZvciBhbnkgWk9ORV9E RVZJQ0UgcGFnZXMgdGhhdCBzaGFyZSBhCj4+IHNlY3Rpb24gd2l0aCBib290IG1lbW9yeS4KPiAK PiBUaGF0IHNob3VsZCBub3QgaGFwcGVuIHJpZ2h0IG5vdyBhbmQgSSBjb21tZW50ZWQgYmFjayB3 aGVuIHlvdSBpbnRyb2R1Y2VkIHN1YnNlY3Rpb24gc3VwcG9ydCB0aGF0IEkgZG9u4oCZdCB3YW50 IHRvIGhhdmUgWk9ORV9ERVZJQ0UgbWl4ZWQgd2l0aCBvbmxpbmUgcGFnZXMgaW4gYSBzZWN0aW9u LiBIYXZpbmcgbWVtb3J5IGJsb2NrIGRldmljZXMgdGhhdCBwYXJ0aWFsbHkgc3BhbiBaT05FX0RF VklDRSB3b3VsZCBiZSAuLi4gcmVhbGx5IHdlaXJkLiBXaXRoIHNvbWV0aGluZyBsaWtlIHBmbl9h Y3RpdmUoKSAtIGFzIGRpc2N1c3NlZCAtIHdlIGNvdWxkIGF0IGxlYXN0IG1ha2UgdGhpcyBjaGVj ayB3b3JrIC0gYnV0IEkgYW0gbm90IHN1cmUgaWYgd2UgcmVhbGx5IHdhbnQgdG8gZ28gZG93biB0 aGF0IHBhdGguIEluIHRoZSB3b3JzdCBjYXNlLCBzb21lIE1CIG9mIFJBTSBhcmUgbG9zdCAuLi4g SSBndWVzcyB0aGlzIG5lZWRzIG1vcmUgdGhvdWdodC4KPiAKCkkganVzdCByZWFsaXplZCB0aGUg ImJvb3QgbWVtb3J5IiBwYXJ0LiBJcyB0aGF0IGEgcmVhbCB0aGluZz8gSU9XLCBjYW4gCndlIGhh dmUgWk9ORV9ERVZJQ0UgZmFsbGluZyBpbnRvIGEgbWVtb3J5IGJsb2NrICh3aXRoIGhvbGVzKT8g SSBzb21ld2hhdCAKaGF2ZSBkb3VidHMgdGhhdCB0aGlzIHdvdWxkIHdvcmsgLi4uCgotLSAKClRo YW5rcywKCkRhdmlkIC8gZGhpbGRlbmIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2pl Y3Qub3JnCmh0dHA6Ly9kcml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaXZlcmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874AAC5DF60 for ; Thu, 7 Nov 2019 23:16:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DADA021D6C for ; Thu, 7 Nov 2019 23:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O4bk1MDE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DADA021D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 478K5v4wpCzF6hy for ; Fri, 8 Nov 2019 10:16:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=205.139.110.120; helo=us-smtp-1.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="O4bk1MDE"; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 478HZh10JmzF6b0 for ; Fri, 8 Nov 2019 09:07:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573164456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gIBG5GMIReYQpS3U1ws59fK/jF+FBXDJRRxLPPFv3ms=; b=O4bk1MDEpgKHWlHhe7JtX7kLWXPSF7WJ62tEpK9Wmak16YY4VNiBnj/42oP2uo45STNMTf eRy+IaYO+4ryMlyhgi981EravFdzs+aBUytmiwZ8G5btz/h0he5U3Nhqpcg16w+bGfCxxF w04N5yDrZYQU0ctK5CDjwaBQHZ7gc4E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-U5XuV8_tOUWYRd6dFnpBtA-1; Thu, 07 Nov 2019 17:07:34 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4A64477; Thu, 7 Nov 2019 22:07:28 +0000 (UTC) Received: from [10.36.116.80] (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1309E600D3; Thu, 7 Nov 2019 22:07:10 +0000 (UTC) Subject: Re: [PATCH v1 04/10] vfio/type1: Prepare is_invalid_reserved_pfn() for PG_reserved changes To: David Hildenbrand , Dan Williams References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <0eb001e0-bb26-59bb-c514-d2f8a86a7eab@redhat.com> Date: Thu, 7 Nov 2019 23:07:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: U5XuV8_tOUWYRd6dFnpBtA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 08 Nov 2019 10:14:21 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Michal Hocko , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list , Pavel Tatashin , KarimAllah Ahmed , Dave Hansen , Alexander Duyck , Michal Hocko , Linux MM , Paul Mackerras , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , "K. Y. Srinivasan" , Thomas Gleixner , Kees Cook , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , X86 ML , YueHaibing , "Matthew Wilcox \(Oracle\)" , Mike Rapoport , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Anthony Yznaga , Oscar Salvador , "Isaac J. Manjarres" , Matt Sickler , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Sasha Levin , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , Borislav Petkov , Nicholas Piggin , Andy Lutomirski , xen-devel , Boris Ostrovsky , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Mel Gorman , Cornelia Huck , Pavel Tatashin , Linux Kernel Mailing List , Sean Christopherson , Johannes Weiner , Paolo Bonzini , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 07.11.19 19:22, David Hildenbrand wrote: >=20 >=20 >> Am 07.11.2019 um 16:40 schrieb Dan Williams : >> >> =EF=BB=BFOn Thu, Oct 24, 2019 at 5:12 AM David Hildenbrand wrote: >>> >>> Right now, ZONE_DEVICE memory is always set PG_reserved. We want to >>> change that. >>> >>> KVM has this weird use case that you can map anything from /dev/mem >>> into the guest. pfn_valid() is not a reliable check whether the memmap >>> was initialized and can be touched. pfn_to_online_page() makes sure >>> that we have an initialized memmap (and don't have ZONE_DEVICE memory). >>> >>> Rewrite is_invalid_reserved_pfn() similar to kvm_is_reserved_pfn() to m= ake >>> sure the function produces the same result once we stop setting ZONE_DE= VICE >>> pages PG_reserved. >>> >>> Cc: Alex Williamson >>> Cc: Cornelia Huck >>> Signed-off-by: David Hildenbrand >>> --- >>> drivers/vfio/vfio_iommu_type1.c | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_= type1.c >>> index 2ada8e6cdb88..f8ce8c408ba8 100644 >>> --- a/drivers/vfio/vfio_iommu_type1.c >>> +++ b/drivers/vfio/vfio_iommu_type1.c >>> @@ -299,9 +299,15 @@ static int vfio_lock_acct(struct vfio_dma *dma, lo= ng npage, bool async) >>> */ >>> static bool is_invalid_reserved_pfn(unsigned long pfn) >>> { >>> - if (pfn_valid(pfn)) >>> - return PageReserved(pfn_to_page(pfn)); >>> + struct page *page =3D pfn_to_online_page(pfn); >> >> Ugh, I just realized this is not a safe conversion until >> pfn_to_online_page() is moved over to subsection granularity. As it >> stands it will return true for any ZONE_DEVICE pages that share a >> section with boot memory. >=20 > That should not happen right now and I commented back when you introduced= subsection support that I don=E2=80=99t want to have ZONE_DEVICE mixed wit= h online pages in a section. Having memory block devices that partially spa= n ZONE_DEVICE would be ... really weird. With something like pfn_active() -= as discussed - we could at least make this check work - but I am not sure = if we really want to go down that path. In the worst case, some MB of RAM a= re lost ... I guess this needs more thought. >=20 I just realized the "boot memory" part. Is that a real thing? IOW, can=20 we have ZONE_DEVICE falling into a memory block (with holes)? I somewhat=20 have doubts that this would work ... --=20 Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60879C43331 for ; Thu, 7 Nov 2019 22:08:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28F0920869 for ; Thu, 7 Nov 2019 22:08:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="czSKze3j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28F0920869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSpwJ-0000Ql-DV; Thu, 07 Nov 2019 22:07:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSpwI-0000Qg-Cu for xen-devel@lists.xenproject.org; Thu, 07 Nov 2019 22:07:38 +0000 X-Inumbo-ID: 0161ccd8-01ab-11ea-9631-bc764e2007e4 Received: from us-smtp-1.mimecast.com (unknown [205.139.110.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 0161ccd8-01ab-11ea-9631-bc764e2007e4; Thu, 07 Nov 2019 22:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573164455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gIBG5GMIReYQpS3U1ws59fK/jF+FBXDJRRxLPPFv3ms=; b=czSKze3jDZExFyu7+VF1A9unedZ4AmaM/FPc7XsPpG7zpUhRww3+lN5jSHXIvCScCf4z4u gwPF39FeBkI2RKry2V4WpFv0NRvkqXRUlMI40qBBM/Bm3VUxZK/CAcALetlnsdxnASB3jA RwSvFXiHaE7RJEKKj+DplhmJsQOpdfw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-U5XuV8_tOUWYRd6dFnpBtA-1; Thu, 07 Nov 2019 17:07:34 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4A64477; Thu, 7 Nov 2019 22:07:28 +0000 (UTC) Received: from [10.36.116.80] (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1309E600D3; Thu, 7 Nov 2019 22:07:10 +0000 (UTC) To: David Hildenbrand , Dan Williams References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <0eb001e0-bb26-59bb-c514-d2f8a86a7eab@redhat.com> Date: Thu, 7 Nov 2019 23:07:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: U5XuV8_tOUWYRd6dFnpBtA-1 X-Mimecast-Spam-Score: 0 Subject: Re: [Xen-devel] [PATCH v1 04/10] vfio/type1: Prepare is_invalid_reserved_pfn() for PG_reserved changes X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Michal Hocko , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list , Pavel Tatashin , KarimAllah Ahmed , Benjamin Herrenschmidt , Dave Hansen , Alexander Duyck , Michal Hocko , Paul Mackerras , Linux MM , Paul Mackerras , Michael Ellerman , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , "K. Y. Srinivasan" , Thomas Gleixner , Kees Cook , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , X86 ML , YueHaibing , "Matthew Wilcox \(Oracle\)" , Mike Rapoport , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Anthony Yznaga , Oscar Salvador , "Isaac J. Manjarres" , Matt Sickler , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Sasha Levin , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , Borislav Petkov , Nicholas Piggin , Andy Lutomirski , xen-devel , Boris Ostrovsky , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Christophe Leroy , Mel Gorman , Cornelia Huck , Pavel Tatashin , Linux Kernel Mailing List , Sean Christopherson , Johannes Weiner , Paolo Bonzini , Andrew Morton , linuxppc-dev Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMDcuMTEuMTkgMTk6MjIsIERhdmlkIEhpbGRlbmJyYW5kIHdyb3RlOgo+IAo+IAo+PiBBbSAw Ny4xMS4yMDE5IHVtIDE2OjQwIHNjaHJpZWIgRGFuIFdpbGxpYW1zIDxkYW4uai53aWxsaWFtc0Bp bnRlbC5jb20+Ogo+Pgo+PiDvu79PbiBUaHUsIE9jdCAyNCwgMjAxOSBhdCA1OjEyIEFNIERhdmlk IEhpbGRlbmJyYW5kIDxkYXZpZEByZWRoYXQuY29tPiB3cm90ZToKPj4+Cj4+PiBSaWdodCBub3cs IFpPTkVfREVWSUNFIG1lbW9yeSBpcyBhbHdheXMgc2V0IFBHX3Jlc2VydmVkLiBXZSB3YW50IHRv Cj4+PiBjaGFuZ2UgdGhhdC4KPj4+Cj4+PiBLVk0gaGFzIHRoaXMgd2VpcmQgdXNlIGNhc2UgdGhh dCB5b3UgY2FuIG1hcCBhbnl0aGluZyBmcm9tIC9kZXYvbWVtCj4+PiBpbnRvIHRoZSBndWVzdC4g cGZuX3ZhbGlkKCkgaXMgbm90IGEgcmVsaWFibGUgY2hlY2sgd2hldGhlciB0aGUgbWVtbWFwCj4+ PiB3YXMgaW5pdGlhbGl6ZWQgYW5kIGNhbiBiZSB0b3VjaGVkLiBwZm5fdG9fb25saW5lX3BhZ2Uo KSBtYWtlcyBzdXJlCj4+PiB0aGF0IHdlIGhhdmUgYW4gaW5pdGlhbGl6ZWQgbWVtbWFwIChhbmQg ZG9uJ3QgaGF2ZSBaT05FX0RFVklDRSBtZW1vcnkpLgo+Pj4KPj4+IFJld3JpdGUgaXNfaW52YWxp ZF9yZXNlcnZlZF9wZm4oKSBzaW1pbGFyIHRvIGt2bV9pc19yZXNlcnZlZF9wZm4oKSB0byBtYWtl Cj4+PiBzdXJlIHRoZSBmdW5jdGlvbiBwcm9kdWNlcyB0aGUgc2FtZSByZXN1bHQgb25jZSB3ZSBz dG9wIHNldHRpbmcgWk9ORV9ERVZJQ0UKPj4+IHBhZ2VzIFBHX3Jlc2VydmVkLgo+Pj4KPj4+IENj OiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tPgo+Pj4gQ2M6IENv cm5lbGlhIEh1Y2sgPGNvaHVja0ByZWRoYXQuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTogRGF2aWQg SGlsZGVuYnJhbmQgPGRhdmlkQHJlZGhhdC5jb20+Cj4+PiAtLS0KPj4+IGRyaXZlcnMvdmZpby92 ZmlvX2lvbW11X3R5cGUxLmMgfCAxMCArKysrKysrKy0tCj4+PiAxIGZpbGUgY2hhbmdlZCwgOCBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3ZmaW8vdmZpb19pb21tdV90eXBlMS5jIGIvZHJpdmVycy92ZmlvL3ZmaW9faW9tbXVfdHlwZTEu Ywo+Pj4gaW5kZXggMmFkYThlNmNkYjg4Li5mOGNlOGM0MDhiYTggMTAwNjQ0Cj4+PiAtLS0gYS9k cml2ZXJzL3ZmaW8vdmZpb19pb21tdV90eXBlMS5jCj4+PiArKysgYi9kcml2ZXJzL3ZmaW8vdmZp b19pb21tdV90eXBlMS5jCj4+PiBAQCAtMjk5LDkgKzI5OSwxNSBAQCBzdGF0aWMgaW50IHZmaW9f bG9ja19hY2N0KHN0cnVjdCB2ZmlvX2RtYSAqZG1hLCBsb25nIG5wYWdlLCBib29sIGFzeW5jKQo+ Pj4gICAqLwo+Pj4gc3RhdGljIGJvb2wgaXNfaW52YWxpZF9yZXNlcnZlZF9wZm4odW5zaWduZWQg bG9uZyBwZm4pCj4+PiB7Cj4+PiAtICAgICAgIGlmIChwZm5fdmFsaWQocGZuKSkKPj4+IC0gICAg ICAgICAgICAgICByZXR1cm4gUGFnZVJlc2VydmVkKHBmbl90b19wYWdlKHBmbikpOwo+Pj4gKyAg ICAgICBzdHJ1Y3QgcGFnZSAqcGFnZSA9IHBmbl90b19vbmxpbmVfcGFnZShwZm4pOwo+Pgo+PiBV Z2gsIEkganVzdCByZWFsaXplZCB0aGlzIGlzIG5vdCBhIHNhZmUgY29udmVyc2lvbiB1bnRpbAo+ PiBwZm5fdG9fb25saW5lX3BhZ2UoKSBpcyBtb3ZlZCBvdmVyIHRvIHN1YnNlY3Rpb24gZ3JhbnVs YXJpdHkuIEFzIGl0Cj4+IHN0YW5kcyBpdCB3aWxsIHJldHVybiB0cnVlIGZvciBhbnkgWk9ORV9E RVZJQ0UgcGFnZXMgdGhhdCBzaGFyZSBhCj4+IHNlY3Rpb24gd2l0aCBib290IG1lbW9yeS4KPiAK PiBUaGF0IHNob3VsZCBub3QgaGFwcGVuIHJpZ2h0IG5vdyBhbmQgSSBjb21tZW50ZWQgYmFjayB3 aGVuIHlvdSBpbnRyb2R1Y2VkIHN1YnNlY3Rpb24gc3VwcG9ydCB0aGF0IEkgZG9u4oCZdCB3YW50 IHRvIGhhdmUgWk9ORV9ERVZJQ0UgbWl4ZWQgd2l0aCBvbmxpbmUgcGFnZXMgaW4gYSBzZWN0aW9u LiBIYXZpbmcgbWVtb3J5IGJsb2NrIGRldmljZXMgdGhhdCBwYXJ0aWFsbHkgc3BhbiBaT05FX0RF VklDRSB3b3VsZCBiZSAuLi4gcmVhbGx5IHdlaXJkLiBXaXRoIHNvbWV0aGluZyBsaWtlIHBmbl9h Y3RpdmUoKSAtIGFzIGRpc2N1c3NlZCAtIHdlIGNvdWxkIGF0IGxlYXN0IG1ha2UgdGhpcyBjaGVj ayB3b3JrIC0gYnV0IEkgYW0gbm90IHN1cmUgaWYgd2UgcmVhbGx5IHdhbnQgdG8gZ28gZG93biB0 aGF0IHBhdGguIEluIHRoZSB3b3JzdCBjYXNlLCBzb21lIE1CIG9mIFJBTSBhcmUgbG9zdCAuLi4g SSBndWVzcyB0aGlzIG5lZWRzIG1vcmUgdGhvdWdodC4KPiAKCkkganVzdCByZWFsaXplZCB0aGUg ImJvb3QgbWVtb3J5IiBwYXJ0LiBJcyB0aGF0IGEgcmVhbCB0aGluZz8gSU9XLCBjYW4gCndlIGhh dmUgWk9ORV9ERVZJQ0UgZmFsbGluZyBpbnRvIGEgbWVtb3J5IGJsb2NrICh3aXRoIGhvbGVzKT8g SSBzb21ld2hhdCAKaGF2ZSBkb3VidHMgdGhhdCB0aGlzIHdvdWxkIHdvcmsgLi4uCgotLSAKClRo YW5rcywKCkRhdmlkIC8gZGhpbGRlbmIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGlu Zm8veGVuLWRldmVs