From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Guo, Jia" Subject: Re: [PATCH V10 2/2] eal: add uevent pass and process function Date: Mon, 15 Jan 2018 23:33:50 +0800 Message-ID: <0ebf34d6-aae4-6646-dd72-75d6c18dcb5d@intel.com> References: <1515575544-2141-3-git-send-email-jia.guo@intel.com> <5621685.YHClJoWfgs@xps> <3360990.PGMcgsB7sd@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9D835A48F for ; Mon, 15 Jan 2018 16:33:53 +0100 (CET) In-Reply-To: <3360990.PGMcgsB7sd@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/15/2018 7:29 PM, Thomas Monjalon wrote: > 15/01/2018 11:52, Guo, Jia: >> On 1/15/2018 7:24 AM, Thomas Monjalon wrote: >>> 11/01/2018 15:05, Jeff Guo: >>>> +enum rte_dev_subsystem { >>>> + RTE_DEV_SUBSYSTEM_UIO, >>>> + RTE_DEV_SUBSYSTEM_VFIO, >>>> + RTE_DEV_SUBSYSTEM_PCI, >>>> + RTE_DEV_SUBSYSTEM_MAX >>>> +}; >>> I don't think PCI and UIO/VFIO should be described at the same level. >>> Can you re-use the enum rte_kernel_driver? >> rte_kernel_driver might be not qualify for that use, since that is the event sumsystem, it include pci/uio/vfio, such strings to identify each subsystem. i will modify it to be rte_dev_event_subsystem. >> >> I don't understand this classification. >> A device can be both PCI and VFIO. yes , i think that might be a little strange, but what i saw in the uevent message is that , the item of subsystem info from kernel side is pci sometimes, but some time is uio, i don't know if it is good to defferentiy them by "subsystem " or "driver" or other. let me think about it more.