[PATCH 0/2] ASoC: da7213: Adjustments for two function implementations

[PATCH 0/2] ASoC: da7213: Adjustments for two function implementations

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:28:38 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation in da7213_fw_to_pdata()
  Improve a size determination in da7213_i2c_probe()

 sound/soc/codecs/da7213.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.15.0

[PATCH 0/2] ASoC: da7213: Adjustments for two function implementations

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:28:38 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation in da7213_fw_to_pdata()
  Improve a size determination in da7213_i2c_probe()

 sound/soc/codecs/da7213.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.15.0

[PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 17:56:54 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/soc/codecs/da7213.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index 41d9b1da27c2..d1b77a0e3b74 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1654,10 +1654,8 @@ static struct da7213_platform_data
 	u32 fw_val32;
 
 	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
+	if (!pdata)
 		return NULL;
-	}
 
 	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
 		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
-- 
2.15.0

[PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pda

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 17:56:54 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/soc/codecs/da7213.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index 41d9b1da27c2..d1b77a0e3b74 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1654,10 +1654,8 @@ static struct da7213_platform_data
 	u32 fw_val32;
 
 	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
+	if (!pdata)
 		return NULL;
-	}
 
 	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
 		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
-- 
2.15.0

[PATCH 2/2] ASoC: da7213: Improve a size determination in da7213_i2c_probe()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:15:30 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/soc/codecs/da7213.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index d1b77a0e3b74..b2b4e90fc02a 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
 	struct da7213_priv *da7213;
 	int ret;
 
-	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
-			      GFP_KERNEL);
+	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
 	if (!da7213)
 		return -ENOMEM;
 
-- 
2.15.0

[PATCH 2/2] ASoC: da7213: Improve a size determination in da7213_i2c_probe()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:15:30 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/soc/codecs/da7213.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index d1b77a0e3b74..b2b4e90fc02a 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
 	struct da7213_priv *da7213;
 	int ret;
 
-	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
-			      GFP_KERNEL);
+	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
 	if (!da7213)
 		return -ENOMEM;
 
-- 
2.15.0

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[Adam Thomson]

On 23 November 2017 17:33, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 23 Nov 2017 17:56:54 +0100
> 
> Omit an extra message for a memory allocation failure in this function.

I'm not sure this is an extra message. We don't return -ENOMEM as a result of
this operation and probe won't fail on this. So does devm_kzalloc() print error
messages?

> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  sound/soc/codecs/da7213.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> index 41d9b1da27c2..d1b77a0e3b74 100644
> --- a/sound/soc/codecs/da7213.c
> +++ b/sound/soc/codecs/da7213.c
> @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
>  	u32 fw_val32;
> 
>  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> -	if (!pdata) {
> -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> +	if (!pdata)
>  		return NULL;
> -	}
> 
>  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
>  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> --
> 2.15.0

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to

[Adam Thomson]

T24gMjMgTm92ZW1iZXIgMjAxNyAxNzozMywgU0YgTWFya3VzIEVsZnJpbmcgd3JvdGU6DQoNCj4g
RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiBE
YXRlOiBUaHUsIDIzIE5vdiAyMDE3IDE3OjU2OjU0ICswMTAwDQo+IA0KPiBPbWl0IGFuIGV4dHJh
IG1lc3NhZ2UgZm9yIGEgbWVtb3J5IGFsbG9jYXRpb24gZmFpbHVyZSBpbiB0aGlzIGZ1bmN0aW9u
Lg0KDQpJJ20gbm90IHN1cmUgdGhpcyBpcyBhbiBleHRyYSBtZXNzYWdlLiBXZSBkb24ndCByZXR1
cm4gLUVOT01FTSBhcyBhIHJlc3VsdCBvZg0KdGhpcyBvcGVyYXRpb24gYW5kIHByb2JlIHdvbid0
IGZhaWwgb24gdGhpcy4gU28gZG9lcyBkZXZtX2t6YWxsb2MoKSBwcmludCBlcnJvcg0KbWVzc2Fn
ZXM/DQoNCj4gVGhpcyBpc3N1ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhlIENvY2NpbmVsbGUg
c29mdHdhcmUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1
c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+DQo+IC0tLQ0KPiAgc291bmQvc29jL2NvZGVjcy9kYTcyMTMu
YyB8IDQgKy0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAzIGRlbGV0aW9u
cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9jb2RlY3MvZGE3MjEzLmMgYi9zb3Vu
ZC9zb2MvY29kZWNzL2RhNzIxMy5jDQo+IGluZGV4IDQxZDliMWRhMjdjMi4uZDFiNzdhMGUzYjc0
IDEwMDY0NA0KPiAtLS0gYS9zb3VuZC9zb2MvY29kZWNzL2RhNzIxMy5jDQo+ICsrKyBiL3NvdW5k
L3NvYy9jb2RlY3MvZGE3MjEzLmMNCj4gQEAgLTE2NTQsMTAgKzE2NTQsOCBAQCBzdGF0aWMgc3Ry
dWN0IGRhNzIxM19wbGF0Zm9ybV9kYXRhDQo+ICAJdTMyIGZ3X3ZhbDMyOw0KPiANCj4gIAlwZGF0
YSA9IGRldm1fa3phbGxvYyhjb2RlYy0+ZGV2LCBzaXplb2YoKnBkYXRhKSwgR0ZQX0tFUk5FTCk7
DQo+IC0JaWYgKCFwZGF0YSkgew0KPiAtCQlkZXZfd2Fybihjb2RlYy0+ZGV2LCAiRmFpbGVkIHRv
IGFsbG9jYXRlIG1lbW9yeSBmb3IgcGRhdGFcbiIpOw0KPiArCWlmICghcGRhdGEpDQo+ICAJCXJl
dHVybiBOVUxMOw0KPiAtCX0NCj4gDQo+ICAJaWYgKGRldmljZV9wcm9wZXJ0eV9yZWFkX3UzMihk
ZXYsICJkbGcsbWljYmlhczEtbHZsIiwgJmZ3X3ZhbDMyKSA+PSAwKQ0KPiAgCQlwZGF0YS0+bWlj
YmlhczFfbHZsID0gZGE3MjEzX29mX21pY2JpYXNfbHZsKGNvZGVjLCBmd192YWwzMik7DQo+IC0t
DQo+IDIuMTUuMA0K

Re: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[Adam Thomson]

On 23 November 2017 17:33, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 23 Nov 2017 17:56:54 +0100
> 
> Omit an extra message for a memory allocation failure in this function.

I'm not sure this is an extra message. We don't return -ENOMEM as a result of
this operation and probe won't fail on this. So does devm_kzalloc() print error
messages?

> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  sound/soc/codecs/da7213.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> index 41d9b1da27c2..d1b77a0e3b74 100644
> --- a/sound/soc/codecs/da7213.c
> +++ b/sound/soc/codecs/da7213.c
> @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
>  	u32 fw_val32;
> 
>  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> -	if (!pdata) {
> -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> +	if (!pdata)
>  		return NULL;
> -	}
> 
>  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
>  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> --
> 2.15.0

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]



On Fri, 24 Nov 2017, Adam Thomson wrote:

> On 23 November 2017 17:33, SF Markus Elfring wrote:
>
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 23 Nov 2017 17:56:54 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
>
> I'm not sure this is an extra message. We don't return -ENOMEM as a result of
> this operation and probe won't fail on this. So does devm_kzalloc() print error
> messages?

Unless there is NO WARN, a backtrace will be generated in the out of
memory case.

julia

>
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  sound/soc/codecs/da7213.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> > index 41d9b1da27c2..d1b77a0e3b74 100644
> > --- a/sound/soc/codecs/da7213.c
> > +++ b/sound/soc/codecs/da7213.c
> > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
> >  	u32 fw_val32;
> >
> >  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> > -	if (!pdata) {
> > -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> > +	if (!pdata)
> >  		return NULL;
> > -	}
> >
> >  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
> >  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> > --
> > 2.15.0
> N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*\x1fjg???\x1e?????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G?????\x0f??:+v???w????

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]



On Fri, 24 Nov 2017, Adam Thomson wrote:

> On 23 November 2017 17:33, SF Markus Elfring wrote:
>
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 23 Nov 2017 17:56:54 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
>
> I'm not sure this is an extra message. We don't return -ENOMEM as a result of
> this operation and probe won't fail on this. So does devm_kzalloc() print error
> messages?

Unless there is NO WARN, a backtrace will be generated in the out of
memory case.

julia

>
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  sound/soc/codecs/da7213.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> > index 41d9b1da27c2..d1b77a0e3b74 100644
> > --- a/sound/soc/codecs/da7213.c
> > +++ b/sound/soc/codecs/da7213.c
> > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
> >  	u32 fw_val32;
> >
> >  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> > -	if (!pdata) {
> > -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> > +	if (!pdata)
> >  		return NULL;
> > -	}
> >
> >  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
> >  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> > --
> > 2.15.0
> N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*\x1fjg???\x1e?????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G?????\x0f??:+v???w????

Re: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]



On Fri, 24 Nov 2017, Adam Thomson wrote:

> On 23 November 2017 17:33, SF Markus Elfring wrote:
>
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 23 Nov 2017 17:56:54 +0100
> >
> > Omit an extra message for a memory allocation failure in this function.
>
> I'm not sure this is an extra message. We don't return -ENOMEM as a result of
> this operation and probe won't fail on this. So does devm_kzalloc() print error
> messages?

Unless there is NO WARN, a backtrace will be generated in the out of
memory case.

julia

>
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> >  sound/soc/codecs/da7213.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> > index 41d9b1da27c2..d1b77a0e3b74 100644
> > --- a/sound/soc/codecs/da7213.c
> > +++ b/sound/soc/codecs/da7213.c
> > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
> >  	u32 fw_val32;
> >
> >  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> > -	if (!pdata) {
> > -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> > +	if (!pdata)
> >  		return NULL;
> > -	}
> >
> >  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
> >  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> > --
> > 2.15.0
> N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*\x1fjg???\x1e
?????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G?????\x0f??:+v???w????

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[Adam Thomson]

On 24 November 2017 11:33, Julia Lawall wrote:

> On Fri, 24 Nov 2017, Adam Thomson wrote:
> 
> > On 23 November 2017 17:33, SF Markus Elfring wrote:
> >
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Thu, 23 Nov 2017 17:56:54 +0100
> > >
> > > Omit an extra message for a memory allocation failure in this function.
> >
> > I'm not sure this is an extra message. We don't return -ENOMEM as a result of
> > this operation and probe won't fail on this. So does devm_kzalloc() print error
> > messages?
> 
> Unless there is NO WARN, a backtrace will be generated in the out of
> memory case.
> 
> julia

Ok, fair enough. In which case:

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> 
> >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > > ---
> > >  sound/soc/codecs/da7213.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> > > index 41d9b1da27c2..d1b77a0e3b74 100644
> > > --- a/sound/soc/codecs/da7213.c
> > > +++ b/sound/soc/codecs/da7213.c
> > > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
> > >  	u32 fw_val32;
> > >
> > >  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> > > -	if (!pdata) {
> > > -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> > > +	if (!pdata)
> > >  		return NULL;
> > > -	}
> > >
> > >  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
> > >  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> > > --
> > > 2.15.0
> > N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*¬
> jg??? ?????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G????? ??:+v???w????

RE: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to

[Adam Thomson]

T24gMjQgTm92ZW1iZXIgMjAxNyAxMTozMywgSnVsaWEgTGF3YWxsIHdyb3RlOg0KDQo+IE9uIEZy
aSwgMjQgTm92IDIwMTcsIEFkYW0gVGhvbXNvbiB3cm90ZToNCj4gDQo+ID4gT24gMjMgTm92ZW1i
ZXIgMjAxNyAxNzozMywgU0YgTWFya3VzIEVsZnJpbmcgd3JvdGU6DQo+ID4NCj4gPiA+IEZyb206
IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4NCj4gPiA+IERh
dGU6IFRodSwgMjMgTm92IDIwMTcgMTc6NTY6NTQgKzAxMDANCj4gPiA+DQo+ID4gPiBPbWl0IGFu
IGV4dHJhIG1lc3NhZ2UgZm9yIGEgbWVtb3J5IGFsbG9jYXRpb24gZmFpbHVyZSBpbiB0aGlzIGZ1
bmN0aW9uLg0KPiA+DQo+ID4gSSdtIG5vdCBzdXJlIHRoaXMgaXMgYW4gZXh0cmEgbWVzc2FnZS4g
V2UgZG9uJ3QgcmV0dXJuIC1FTk9NRU0gYXMgYSByZXN1bHQgb2YNCj4gPiB0aGlzIG9wZXJhdGlv
biBhbmQgcHJvYmUgd29uJ3QgZmFpbCBvbiB0aGlzLiBTbyBkb2VzIGRldm1fa3phbGxvYygpIHBy
aW50IGVycm9yDQo+ID4gbWVzc2FnZXM/DQo+IA0KPiBVbmxlc3MgdGhlcmUgaXMgTk8gV0FSTiwg
YSBiYWNrdHJhY2Ugd2lsbCBiZSBnZW5lcmF0ZWQgaW4gdGhlIG91dCBvZg0KPiBtZW1vcnkgY2Fz
ZS4NCj4gDQo+IGp1bGlhDQoNCk9rLCBmYWlyIGVub3VnaC4gSW4gd2hpY2ggY2FzZToNCg0KQWNr
ZWQtYnk6IEFkYW0gVGhvbXNvbiA8QWRhbS5UaG9tc29uLk9wZW5zb3VyY2VAZGlhc2VtaS5jb20+
DQoNCj4gDQo+ID4NCj4gPiA+IFRoaXMgaXNzdWUgd2FzIGRldGVjdGVkIGJ5IHVzaW5nIHRoZSBD
b2NjaW5lbGxlIHNvZnR3YXJlLg0KPiA+ID4NCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hcmt1cyBF
bGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4NCj4gPiA+IC0tLQ0KPiA+ID4g
IHNvdW5kL3NvYy9jb2RlY3MvZGE3MjEzLmMgfCA0ICstLS0NCj4gPiA+ICAxIGZpbGUgY2hhbmdl
ZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pDQo+ID4gPg0KPiA+ID4gZGlmZiAtLWdp
dCBhL3NvdW5kL3NvYy9jb2RlY3MvZGE3MjEzLmMgYi9zb3VuZC9zb2MvY29kZWNzL2RhNzIxMy5j
DQo+ID4gPiBpbmRleCA0MWQ5YjFkYTI3YzIuLmQxYjc3YTBlM2I3NCAxMDA2NDQNCj4gPiA+IC0t
LSBhL3NvdW5kL3NvYy9jb2RlY3MvZGE3MjEzLmMNCj4gPiA+ICsrKyBiL3NvdW5kL3NvYy9jb2Rl
Y3MvZGE3MjEzLmMNCj4gPiA+IEBAIC0xNjU0LDEwICsxNjU0LDggQEAgc3RhdGljIHN0cnVjdCBk
YTcyMTNfcGxhdGZvcm1fZGF0YQ0KPiA+ID4gIAl1MzIgZndfdmFsMzI7DQo+ID4gPg0KPiA+ID4g
IAlwZGF0YSA9IGRldm1fa3phbGxvYyhjb2RlYy0+ZGV2LCBzaXplb2YoKnBkYXRhKSwgR0ZQX0tF
Uk5FTCk7DQo+ID4gPiAtCWlmICghcGRhdGEpIHsNCj4gPiA+IC0JCWRldl93YXJuKGNvZGVjLT5k
ZXYsICJGYWlsZWQgdG8gYWxsb2NhdGUgbWVtb3J5IGZvciBwZGF0YVxuIik7DQo+ID4gPiArCWlm
ICghcGRhdGEpDQo+ID4gPiAgCQlyZXR1cm4gTlVMTDsNCj4gPiA+IC0JfQ0KPiA+ID4NCj4gPiA+
ICAJaWYgKGRldmljZV9wcm9wZXJ0eV9yZWFkX3UzMihkZXYsICJkbGcsbWljYmlhczEtbHZsIiwg
JmZ3X3ZhbDMyKSA+PSAwKQ0KPiA+ID4gIAkJcGRhdGEtPm1pY2JpYXMxX2x2bCA9IGRhNzIxM19v
Zl9taWNiaWFzX2x2bChjb2RlYywgZndfdmFsMzIpOw0KPiA+ID4gLS0NCj4gPiA+IDIuMTUuMA0K
PiA+IE4/Pz8/P3I/P3k/Pz8/Pz9YPz/Hp3Y/Pz8p3rp7Lm4/Pz8/P3o/3pY2Pz8/Pz8pPz8/Pz8q
wqwNCj4gamc/Pz8gPz8/Pz/domovPz8/ej/elj8/Pz/emT8/Pz8mPynfoT9hPz8/Pz8/P0c/Pz8/
PyA/Pzordj8/P3c/Pz8/DQo

Re: [PATCH 1/2] ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

[Adam Thomson]

On 24 November 2017 11:33, Julia Lawall wrote:

> On Fri, 24 Nov 2017, Adam Thomson wrote:
> 
> > On 23 November 2017 17:33, SF Markus Elfring wrote:
> >
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Thu, 23 Nov 2017 17:56:54 +0100
> > >
> > > Omit an extra message for a memory allocation failure in this function.
> >
> > I'm not sure this is an extra message. We don't return -ENOMEM as a result of
> > this operation and probe won't fail on this. So does devm_kzalloc() print error
> > messages?
> 
> Unless there is NO WARN, a backtrace will be generated in the out of
> memory case.
> 
> julia

Ok, fair enough. In which case:

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> 
> >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > > ---
> > >  sound/soc/codecs/da7213.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> > > index 41d9b1da27c2..d1b77a0e3b74 100644
> > > --- a/sound/soc/codecs/da7213.c
> > > +++ b/sound/soc/codecs/da7213.c
> > > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data
> > >  	u32 fw_val32;
> > >
> > >  	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
> > > -	if (!pdata) {
> > > -		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
> > > +	if (!pdata)
> > >  		return NULL;
> > > -	}
> > >
> > >  	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
> > >  		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
> > > --
> > > 2.15.0
> > N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*¬
> jg??? ?????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G????? ??:+v???w????
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

RE: [PATCH 2/2] ASoC: da7213: Improve a size determination in da7213_i2c_probe()

[Adam Thomson]

On 23 November 2017 17:34, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 23 Nov 2017 18:15:30 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
>  sound/soc/codecs/da7213.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> index d1b77a0e3b74..b2b4e90fc02a 100644
> --- a/sound/soc/codecs/da7213.c
> +++ b/sound/soc/codecs/da7213.c
> @@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
>  	struct da7213_priv *da7213;
>  	int ret;
> 
> -	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
> -			      GFP_KERNEL);
> +	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
>  	if (!da7213)
>  		return -ENOMEM;
> 
> --
> 2.15.0

RE: [PATCH 2/2] ASoC: da7213: Improve a size determination in da7213_i2c_probe()

[Adam Thomson]

T24gMjMgTm92ZW1iZXIgMjAxNyAxNzozNCwgU0YgTWFya3VzIEVsZnJpbmcgd3JvdGU6DQoNCj4g
RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiBE
YXRlOiBUaHUsIDIzIE5vdiAyMDE3IDE4OjE1OjMwICswMTAwDQo+IA0KPiBSZXBsYWNlIHRoZSBz
cGVjaWZpY2F0aW9uIG9mIGEgZGF0YSBzdHJ1Y3R1cmUgYnkgYSBwb2ludGVyIGRlcmVmZXJlbmNl
DQo+IGFzIHRoZSBwYXJhbWV0ZXIgZm9yIHRoZSBvcGVyYXRvciAic2l6ZW9mIiB0byBtYWtlIHRo
ZSBjb3JyZXNwb25kaW5nIHNpemUNCj4gZGV0ZXJtaW5hdGlvbiBhIGJpdCBzYWZlciBhY2NvcmRp
bmcgdG8gdGhlIExpbnV4IGNvZGluZyBzdHlsZSBjb252ZW50aW9uLg0KPiANCj4gVGhpcyBpc3N1
ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhlIENvY2NpbmVsbGUgc29mdHdhcmUuDQo+IA0KPiBT
aWduZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5u
ZXQ+DQoNCkFja2VkLWJ5OiBBZGFtIFRob21zb24gPEFkYW0uVGhvbXNvbi5PcGVuc291cmNlQGRp
YXNlbWkuY29tPg0KDQo+IC0tLQ0KPiAgc291bmQvc29jL2NvZGVjcy9kYTcyMTMuYyB8IDMgKy0t
DQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pDQo+IA0K
PiBkaWZmIC0tZ2l0IGEvc291bmQvc29jL2NvZGVjcy9kYTcyMTMuYyBiL3NvdW5kL3NvYy9jb2Rl
Y3MvZGE3MjEzLmMNCj4gaW5kZXggZDFiNzdhMGUzYjc0Li5iMmI0ZTkwZmMwMmEgMTAwNjQ0DQo+
IC0tLSBhL3NvdW5kL3NvYy9jb2RlY3MvZGE3MjEzLmMNCj4gKysrIGIvc291bmQvc29jL2NvZGVj
cy9kYTcyMTMuYw0KPiBAQCAtMTg1Myw4ICsxODUzLDcgQEAgc3RhdGljIGludCBkYTcyMTNfaTJj
X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICppMmMsDQo+ICAJc3RydWN0IGRhNzIxM19wcml2ICpk
YTcyMTM7DQo+ICAJaW50IHJldDsNCj4gDQo+IC0JZGE3MjEzID0gZGV2bV9remFsbG9jKCZpMmMt
PmRldiwgc2l6ZW9mKHN0cnVjdCBkYTcyMTNfcHJpdiksDQo+IC0JCQkgICAgICBHRlBfS0VSTkVM
KTsNCj4gKwlkYTcyMTMgPSBkZXZtX2t6YWxsb2MoJmkyYy0+ZGV2LCBzaXplb2YoKmRhNzIxMyks
IEdGUF9LRVJORUwpOw0KPiAgCWlmICghZGE3MjEzKQ0KPiAgCQlyZXR1cm4gLUVOT01FTTsNCj4g
DQo+IC0tDQo+IDIuMTUuMA0KDQo

Re: [PATCH 2/2] ASoC: da7213: Improve a size determination in da7213_i2c_probe()

[Adam Thomson]

On 23 November 2017 17:34, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 23 Nov 2017 18:15:30 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
>  sound/soc/codecs/da7213.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
> index d1b77a0e3b74..b2b4e90fc02a 100644
> --- a/sound/soc/codecs/da7213.c
> +++ b/sound/soc/codecs/da7213.c
> @@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
>  	struct da7213_priv *da7213;
>  	int ret;
> 
> -	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
> -			      GFP_KERNEL);
> +	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
>  	if (!da7213)
>  		return -ENOMEM;
> 
> --
> 2.15.0

Applied "ASoC: da7213: Improve a size determination in da7213_i2c_probe()" to the asoc tree

[Mark Brown]

The patch

   ASoC: da7213: Improve a size determination in da7213_i2c_probe()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 8080699a3649cb0a0aed2c650a7a3a76c2025b30 Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:15:30 +0100
Subject: [PATCH] ASoC: da7213: Improve a size determination in
 da7213_i2c_probe()

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7213.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index d1b77a0e3b74..b2b4e90fc02a 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
 	struct da7213_priv *da7213;
 	int ret;
 
-	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
-			      GFP_KERNEL);
+	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
 	if (!da7213)
 		return -ENOMEM;
 
-- 
2.15.0

Applied "ASoC: da7213: Improve a size determination in da7213_i2c_probe()" to the asoc tree

[Mark Brown]

The patch

   ASoC: da7213: Improve a size determination in da7213_i2c_probe()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 8080699a3649cb0a0aed2c650a7a3a76c2025b30 Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:15:30 +0100
Subject: [PATCH] ASoC: da7213: Improve a size determination in
 da7213_i2c_probe()

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7213.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index d1b77a0e3b74..b2b4e90fc02a 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
 	struct da7213_priv *da7213;
 	int ret;
 
-	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
-			      GFP_KERNEL);
+	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
 	if (!da7213)
 		return -ENOMEM;
 
-- 
2.15.0

Applied "ASoC: da7213: Improve a size determination in da7213_i2c_probe()" to the asoc tree

[Mark Brown]

The patch

   ASoC: da7213: Improve a size determination in da7213_i2c_probe()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 8080699a3649cb0a0aed2c650a7a3a76c2025b30 Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 18:15:30 +0100
Subject: [PATCH] ASoC: da7213: Improve a size determination in
 da7213_i2c_probe()

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7213.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index d1b77a0e3b74..b2b4e90fc02a 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1853,8 +1853,7 @@ static int da7213_i2c_probe(struct i2c_client *i2c,
 	struct da7213_priv *da7213;
 	int ret;
 
-	da7213 = devm_kzalloc(&i2c->dev, sizeof(struct da7213_priv),
-			      GFP_KERNEL);
+	da7213 = devm_kzalloc(&i2c->dev, sizeof(*da7213), GFP_KERNEL);
 	if (!da7213)
 		return -ENOMEM;
 
-- 
2.15.0

Applied "ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()" to the asoc tree

[Mark Brown]

The patch

   ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 13d5ea5f10b7359cd0f846179fe0b2411e12cfeb Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 17:56:54 +0100
Subject: [PATCH] ASoC: da7213: Delete an error message for a failed memory
 allocation in da7213_fw_to_pdata()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7213.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index 41d9b1da27c2..d1b77a0e3b74 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1654,10 +1654,8 @@ static struct da7213_platform_data
 	u32 fw_val32;
 
 	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
+	if (!pdata)
 		return NULL;
-	}
 
 	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
 		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
-- 
2.15.0

Applied "ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata(

[Mark Brown]

The patch

   ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 13d5ea5f10b7359cd0f846179fe0b2411e12cfeb Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 17:56:54 +0100
Subject: [PATCH] ASoC: da7213: Delete an error message for a failed memory
 allocation in da7213_fw_to_pdata()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7213.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index 41d9b1da27c2..d1b77a0e3b74 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1654,10 +1654,8 @@ static struct da7213_platform_data
 	u32 fw_val32;
 
 	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
+	if (!pdata)
 		return NULL;
-	}
 
 	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
 		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
-- 
2.15.0

Applied "ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()" to the asoc tree

[Mark Brown]

The patch

   ASoC: da7213: Delete an error message for a failed memory allocation in da7213_fw_to_pdata()

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 13d5ea5f10b7359cd0f846179fe0b2411e12cfeb Mon Sep 17 00:00:00 2001
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 23 Nov 2017 17:56:54 +0100
Subject: [PATCH] ASoC: da7213: Delete an error message for a failed memory
 allocation in da7213_fw_to_pdata()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7213.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c
index 41d9b1da27c2..d1b77a0e3b74 100644
--- a/sound/soc/codecs/da7213.c
+++ b/sound/soc/codecs/da7213.c
@@ -1654,10 +1654,8 @@ static struct da7213_platform_data
 	u32 fw_val32;
 
 	pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		dev_warn(codec->dev, "Failed to allocate memory for pdata\n");
+	if (!pdata)
 		return NULL;
-	}
 
 	if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0)
 		pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32);
-- 
2.15.0