From: Thomas Koutcher <thomas.koutcher@online.fr>
To: git@vger.kernel.org
Subject: Re: [PATCH v2] subtree: force merge commit
Date: Thu, 18 Nov 2021 07:06:38 +0100 [thread overview]
Message-ID: <0ef32d3e-7b0c-3458-7edd-1eb6a3067a83@online.fr> (raw)
In-Reply-To: <xmqqpmqy12u0.fsf@gitster.g>
Le 18/11/2021 à 05:53, Junio C Hamano a écrit :
> Reviewed-by: is a bit tricky. If you are sending a corrected
> version after other people just took a look at a previous iteration,
> you cannot generally have them for two reasons. First of all, they
> haven't said that you can have Reviewed-by: under there name (which
> means that they are completely satisfied after giving a thorough
> analysis). Also, the version you are sending is different from what
> they reviewed, so even if they were happy with the previous iteration,
> it does not mean they would be with this version.
Thanks for the clarification and sorry for the confusion I created.
next prev parent reply other threads:[~2021-11-18 6:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 15:07 [PATCH] subtree: ignore merge.ff setting Thomas Koutcher via GitGitGadget
2021-11-14 17:54 ` Ævar Arnfjörð Bjarmason
2021-11-14 18:38 ` Junio C Hamano
2021-11-14 21:45 ` [PATCH v2] subtree: force merge commit Thomas Koutcher via GitGitGadget
2021-11-18 4:53 ` Junio C Hamano
2021-11-18 6:06 ` Thomas Koutcher [this message]
2022-02-01 17:26 ` [PATCH RESEND] " Johannes Altmanninger
2022-02-01 19:19 ` Junio C Hamano
2022-02-01 19:53 ` Johannes Altmanninger
2022-02-01 23:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef32d3e-7b0c-3458-7edd-1eb6a3067a83@online.fr \
--to=thomas.koutcher@online.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.