From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] blk-mq: fix sbitmap ws_active for shared tags
Date: Mon, 25 Mar 2019 10:42:41 -0600 [thread overview]
Message-ID: <0ef38015-d57c-fdbd-6c1e-6cf2ceec3ec4@kernel.dk> (raw)
In-Reply-To: <1553531987.118779.9.camel@acm.org>
On 3/25/19 10:39 AM, Bart Van Assche wrote:
> On Mon, 2019-03-25 at 10:22 -0600, Jens Axboe wrote:
>> We now wrap sbitmap waitqueues in an active counter, so we can avoid
>> iterating wakeups unless we have waiters there. This works as long as
>> everyone that's manipulating the waitqueues use the proper helpers. For
>> the tag wait case for shared tags, however, we add ourselves to the
>> waitqueue without incrementing/decrementing the ->ws_active count. This
>> means that wakeups can take a long time to happen.
>>
>> Fix this by manually doing the inc/dec as needed for the wait queue
>> handling.
>>
>> Fixes: 5d2ee7122c73 ("sbitmap: optimize wakeup check")
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> Hi Jens,
>
> Since commit 5d2ee7122c73 went upstream in kernel v5.0, does this patch need
> a "Cc: stable" tag?
I guess it does, I'll add it.
--
Jens Axboe
next prev parent reply other threads:[~2019-03-25 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 16:22 [PATCH] blk-mq: fix sbitmap ws_active for shared tags Jens Axboe
2019-03-25 16:39 ` Bart Van Assche
2019-03-25 16:42 ` Jens Axboe [this message]
2019-03-25 18:56 ` Omar Sandoval
2019-03-25 18:58 ` Jens Axboe
2019-03-25 19:04 ` Omar Sandoval
2019-03-25 19:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef38015-d57c-fdbd-6c1e-6cf2ceec3ec4@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.