All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliang.tang@suse.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliang.tang@suse.com>
Subject: [PATCH mptcp-next v3 03/15] Squash to "mptcp: add scheduler wrappers"
Date: Tue, 30 May 2023 21:17:23 +0800	[thread overview]
Message-ID: <0ef71dfd3f2a8b4ea06aef816fb2881cff68f1bd.1685452619.git.geliang.tang@suse.com> (raw)
In-Reply-To: <cover.1685452619.git.geliang.tang@suse.com>

Use msk->sched_data instead of the local variable data.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 net/mptcp/sched.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/net/mptcp/sched.c b/net/mptcp/sched.c
index a053a9504dfd..5438a86e897a 100644
--- a/net/mptcp/sched.c
+++ b/net/mptcp/sched.c
@@ -127,7 +127,6 @@ void mptcp_sched_data_set_contexts(const struct mptcp_sock *msk,
 int mptcp_sched_get_send(struct mptcp_sock *msk)
 {
 	struct mptcp_subflow_context *subflow;
-	struct mptcp_sched_data data;
 
 	msk_owned_by_me(msk);
 
@@ -157,15 +156,14 @@ int mptcp_sched_get_send(struct mptcp_sock *msk)
 		return 0;
 	}
 
-	data.reinject = false;
-	msk->sched->data_init(msk, &data);
-	return msk->sched->get_subflow(msk, &data);
+	msk->sched_data->reinject = false;
+	msk->sched->data_init(msk, msk->sched_data);
+	return msk->sched->get_subflow(msk, msk->sched_data);
 }
 
 int mptcp_sched_get_retrans(struct mptcp_sock *msk)
 {
 	struct mptcp_subflow_context *subflow;
-	struct mptcp_sched_data data;
 
 	msk_owned_by_me(msk);
 
@@ -188,7 +186,7 @@ int mptcp_sched_get_retrans(struct mptcp_sock *msk)
 		return 0;
 	}
 
-	data.reinject = true;
-	msk->sched->data_init(msk, &data);
-	return msk->sched->get_subflow(msk, &data);
+	msk->sched_data->reinject = true;
+	msk->sched->data_init(msk, msk->sched_data);
+	return msk->sched->get_subflow(msk, msk->sched_data);
 }
-- 
2.35.3


  parent reply	other threads:[~2023-05-30 13:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 13:17 [PATCH mptcp-next v3 00/15] save sched_data at mptcp_sock Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 01/15] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 02/15] Squash to "mptcp: add sched in mptcp_sock" Geliang Tang
2023-05-30 13:17 ` Geliang Tang [this message]
2023-05-30 13:17 ` [PATCH mptcp-next v3 04/15] mptcp: add last_snd in sched_data Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 05/15] mptcp: add snd_burst " Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 06/15] mptcp: register default scheduler Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 07/15] mptcp: rename __mptcp_set_timeout for bpf_burst Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 08/15] mptcp: add two wrappers " Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 09/15] mptcp: add three helpers " Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 10/15] Squash to "bpf: Add bpf_mptcp_sched_ops" Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 11/15] Squash to "bpf: Add bpf_mptcp_sched_kfunc_set" Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 12/15] Squash to "selftests/bpf: Add mptcp sched structs" Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 13/15] Squash to "selftests/bpf: Add bpf_rr scheduler" Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 14/15] selftests/bpf: Add bpf_burst scheduler Geliang Tang
2023-05-30 13:17 ` [PATCH mptcp-next v3 15/15] selftests/bpf: Add bpf_burst test Geliang Tang
2023-05-30 13:50   ` selftests/bpf: Add bpf_burst test: Build Failure MPTCP CI
2023-05-30 14:46   ` selftests/bpf: Add bpf_burst test: Tests Results MPTCP CI
  -- strict thread matches above, loose matches on Subject: below --
2023-05-30 13:15 [PATCH mptcp-next v3 00/15] save sched_data at mptcp_sock Geliang Tang
2023-05-30 13:15 ` [PATCH mptcp-next v3 03/15] Squash to "mptcp: add scheduler wrappers" Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ef71dfd3f2a8b4ea06aef816fb2881cff68f1bd.1685452619.git.geliang.tang@suse.com \
    --to=geliang.tang@suse.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.