From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jason Wang <jasowang@redhat.com>
Subject: Re: [Patch net-next v3 3/3] net_sched: implement
 ->change_tx_queue_len() for pfifo_fast
Date: Mon, 29 Jan 2018 11:31:42 +0800
Message-ID: <0f00a250-a3d7-47cf-21bd-e893e4b36afa@redhat.com>
References: <20180126022624.20442-1-xiyou.wangcong@gmail.com>
 <20180126022624.20442-4-xiyou.wangcong@gmail.com>
 <eae09f55-072c-1f60-c231-d76455d00f8b@redhat.com>
 <CAM_iQpWLNhm-k_2Ncv2D=K1FCnUJtcqfemu6oKt6DXQk7rQy7g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        "Michael S. Tsirkin" <mst@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:53010 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750808AbeA2Dbs (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 28 Jan 2018 22:31:48 -0500
In-Reply-To: <CAM_iQpWLNhm-k_2Ncv2D=K1FCnUJtcqfemu6oKt6DXQk7rQy7g@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 2018年01月26日 12:01, Cong Wang wrote:
>> Is __skb_array_empty() in pfifo_fast_dequeue() still safe after this change?
> Yes, we sync with dequeue path before calling ->change_tx_queue_len().
> I already mentioned this in patch 2/3.

Aha, ok, I think I get the synchronize_net() trick in dev_deactivate_many().

Thanks