From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
"Tim Deegan" <tim@xen.org>
Subject: Re: [PATCH 4/4] x86/PV: properly set shadow allocation for Dom0
Date: Tue, 31 Aug 2021 14:47:59 +0100 [thread overview]
Message-ID: <0f00a4fd-47c2-8ba0-13b2-2210d8b4e0e2@citrix.com> (raw)
In-Reply-To: <35864b86-ae6c-f8ee-99df-cf78751d275d@suse.com>
On 30/08/2021 14:03, Jan Beulich wrote:
> @@ -933,7 +934,17 @@ int __init dom0_construct_pv(struct doma
> #ifdef CONFIG_SHADOW_PAGING
> if ( opt_dom0_shadow )
> {
> + bool preempted;
> +
> printk("Switching dom0 to using shadow paging\n");
> +
> + do {
> + preempted = false;
> + shadow_set_allocation(d, dom0_paging_pages(d, nr_pages),
> + &preempted);
> + process_pending_softirqs();
> + } while ( preempted );
This isn't correct. The shadow pool is needed even without
opt_dom0_shadow, because some downstreams have elected not to retain
upstream's security vulnerability in default setting of opt_pv_l1tf_hwdom.
Also, dom0_paging_pages() isn't a trivial calculation, so should be
called once and cached.
~Andrew
next prev parent reply other threads:[~2021-08-31 13:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 13:01 [PATCH 0/4] x86/PVH: Dom0 building adjustments Jan Beulich
2021-08-30 13:02 ` [PATCH 1/4] x86/PVH: de-duplicate mappings for first Mb of Dom0 memory Jan Beulich
2021-08-31 13:02 ` Andrew Cooper
2021-08-31 13:14 ` Jan Beulich
2021-08-31 13:19 ` Jan Beulich
2021-08-31 13:27 ` Andrew Cooper
2021-08-31 13:36 ` Jan Beulich
2021-09-01 11:49 ` Andrew Cooper
2021-09-01 8:41 ` Roger Pau Monné
2021-08-30 13:02 ` [PATCH 2/4] x86/P2M: relax guarding of MMIO entries Jan Beulich
2021-08-31 13:16 ` Jan Beulich
2021-08-31 13:16 ` Andrew Cooper
2021-08-31 13:26 ` Jan Beulich
2021-08-31 15:25 ` Andrew Cooper
2021-08-31 15:38 ` Jan Beulich
2021-09-01 8:08 ` Jan Beulich
2021-09-01 8:50 ` Roger Pau Monné
2021-09-01 9:53 ` Jan Beulich
2021-09-01 13:48 ` Roger Pau Monné
2021-09-01 14:05 ` Jan Beulich
2021-09-01 12:47 ` Andrew Cooper
2021-09-01 13:08 ` Jan Beulich
2021-09-06 19:53 ` Andrew Cooper
2021-09-07 6:27 ` Jan Beulich
2021-08-30 13:03 ` [PATCH 3/4] x86/PVH: improve Dom0 memory size calculation Jan Beulich
2021-08-31 14:07 ` Andrew Cooper
2021-08-31 15:30 ` Jan Beulich
2021-08-30 13:03 ` [PATCH 4/4] x86/PV: properly set shadow allocation for Dom0 Jan Beulich
2021-08-31 13:47 ` Andrew Cooper [this message]
2021-08-31 14:25 ` Jan Beulich
2021-08-31 21:08 ` Tim Deegan
2021-08-31 8:53 ` [PATCH 0/4] x86/PVH: Dom0 building adjustments Jan Beulich
2021-09-01 13:56 ` Roger Pau Monné
2021-09-01 14:19 ` Jan Beulich
2021-09-01 14:25 ` Jan Beulich
2021-09-01 16:13 ` Roger Pau Monné
2021-09-02 6:30 ` Jan Beulich
2021-09-01 15:06 ` Jan Beulich
2021-09-01 15:24 ` Juergen Gross
2021-09-01 15:51 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f00a4fd-47c2-8ba0-13b2-2210d8b4e0e2@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.