From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301B8EB64DD for ; Mon, 3 Jul 2023 23:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbjGCXt7 (ORCPT ); Mon, 3 Jul 2023 19:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjGCXt5 (ORCPT ); Mon, 3 Jul 2023 19:49:57 -0400 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB34013D for ; Mon, 3 Jul 2023 16:49:54 -0700 (PDT) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230703234950epoutp046d788479d8a1c7c9331ff519c27aae4b~ugH5p7wNc1245412454epoutp04y for ; Mon, 3 Jul 2023 23:49:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230703234950epoutp046d788479d8a1c7c9331ff519c27aae4b~ugH5p7wNc1245412454epoutp04y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1688428190; bh=M+PRu7t9Av84Uq/Ch0fMWh1O29jRGMDgZGtSzOc9xKM=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=aDmNxbVl5fUOBvMnLppcWNenyJRFVsKnQNTPTHRMwe3LMXrzUVWDdLEboxWO1V1Ki Ebu42x7ZwillKvw55ob+Clsn/yDrxhHYq5yD9gfP7o54OH4jgoow8JT/xTZ6CrB0uy ztw7TrtDKodx8RIX1DYyNzeRCoeEV3SW5OdTKQYM= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230703234950epcas1p396c3d95d3081fdb4cc6a7b662b6d10a0~ugH5HwxpT2621426214epcas1p3v; Mon, 3 Jul 2023 23:49:50 +0000 (GMT) Received: from epsmgec1p1.samsung.com (unknown [182.195.38.232]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4Qw2hs1sJCz4x9Q5; Mon, 3 Jul 2023 23:49:49 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmgec1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 35.2B.57829.D9E53A46; Tue, 4 Jul 2023 08:49:49 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230703234948epcas1p135dbb5248ac8fefbe47651b0f822f4db~ugH3qBiKn3212432124epcas1p1h; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230703234948epsmtrp1ca01f9d5f8bf242bc49208fe9ad72fb8~ugH3pWq-C0142701427epsmtrp1o; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) X-AuditID: b6c32a33-635fe7000001e1e5-96-64a35e9d7c15 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id D6.BD.64355.C9E53A46; Tue, 4 Jul 2023 08:49:48 +0900 (KST) Received: from inkidae001 (unknown [10.113.221.213]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230703234948epsmtip224f17eb1dec36c6ebb221f4bfba05bc9~ugH3aH8S70594605946epsmtip2N; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) From: =?ks_c_5601-1987?B?tOvAzrHiL1RpemVuIFBsYXRmb3JtIExhYihTUikvu++8usD8wNo=?= To: "'Paul Cercueil'" , "'Krzysztof Kozlowski'" , "'Rob Herring'" , "'Conor Dooley'" , "'Alim Akhtar'" , "'Neil Armstrong'" , "'Sam Ravnborg'" Cc: , , , , In-Reply-To: <20230703214715.623447-3-paul@crapouillou.net> Subject: RE: [PATCH 2/3] drm/panel: ld9040: Register a backlight device Date: Tue, 4 Jul 2023 08:49:48 +0900 Message-ID: <0f0c01d9ae09$0d3a17f0$27ae47d0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ks_c_5601-1987" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: ko Thread-Index: AQELXz3jF3oWSYlPLwE5KJCmEnZTHgIJPQsEAjYh06WxI1eC4A== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMJsWRmVeSWpSXmKPExsWy7bCmge7cuMUpBqv+cFg8mLeNzWLN3nNM FvOPnGO1uPL1PZtF34uHzBabHl9jtbi8aw6bxYzz+5gs3u+8xWjRv/gSi0Xr3iPsFit+bmV0 4PFYfamdzWPTqk42jzvX9rB53O8+zuSxeUm9x5JpV9k8+rasYvT4vEkugCMq2yYjNTEltUgh NS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6FolhbLEnFKgUEBicbGS vp1NUX5pSapCRn5xia1SakFKToFpgV5xYm5xaV66Xl5qiZWhgYGRKVBhQnbG1pP+BX0CFT2f WxkbGK/wdjFyckgImEi0PdvA2MXIxSEksINRonHKYVYI5xOjxNvOu4xwzsOL21hhWs5+aYZK 7GSUWHBhGxuE85JRYtmq5ywgVWwCGRJ32xeDzRIR2M8k0fTtDTOIwyywhVHi+pk57CBVnALW Escv72AGsYUF3CVarvQygtgsAioSi9auZgOxeQUsJdas62CGsAUlTs58AraBWcBIYsnq+UwQ trzE9rdzmCHuU5D4+XQZK0RcRGJ2ZxtQnAPoCieJI398QG6QELjAIbFsynxGiHoXiXOXnkP1 Cku8Or6FHcKWknjZ38YO0TCZUeLO9RUsEM4MRonDP69DdRtL7F86mQnCVpTY+XsuI8RmPol3 X3tYQTZLCPBKdLQJQZQoSRy7eAOqVULiwpKJbBMYlWYh+W0Wkt9mIfltFpJ/FjCyrGIUSy0o zk1PTTYsMITHeHJ+7iZGcGrWMt7BeHn+P71DjEwcjIcYJTiYlUR4mx/OTxHiTUmsrEotyo8v Ks1JLT7EaAoM7onMUqLJ+cDskFcSb2hiaWBiZmRsYmFoZqgkzqs4YXaKkEB6YklqdmpqQWoR TB8TB6dUA1OPg3/515WHvtjnf9bxYdgtXyj5kIM3mTU2x2Vq4bm95b+rb7ukCSdIzeFijP4Q yR+5lM8q0O9l5S1GKaMi7o0btyavPOik1n3jwiQOaWtRxj0KK5iS/+5asedU5fY1pzLPpC66 qlPwONZHOmuTt79v6IJVn2b0NGSyhZ/iu668OZpVsFDMPrJ//+n29WcPLNSq95zKFvdOqvbJ ScbliY2t++LYP/M0lrXr/Zv7bdXnnAtPut7wP6uLXjJbPUdJpXPmyRrepEdbtdXVZzH3r2x7 dHZ3h0nj9LOGv55F/ttw55W3iYOB/kUzlW0K7+XcNxaEa6czypSXmsUohb75dWNddW1q4sHp mzeLZOz7qsRSnJFoqMVcVJwIANnp/j9WBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsWy7bCSvO6cuMUpBs2z5SwezNvGZrFm7zkm i/lHzrFaXPn6ns2i78VDZotNj6+xWlzeNYfNYsb5fUwW73feYrToX3yJxaJ17xF2ixU/tzI6 8HisvtTO5rFpVSebx51re9g87ncfZ/LYvKTeY8m0q2wefVtWMXp83iQXwBHFZZOSmpNZllqk b5fAlbH1pH9Bn0BFz+dWxgbGK7xdjJwcEgImEme/NDN2MXJxCAlsZ5SY1nGduYuRAyghIbFl KweEKSxx+HAxRMlzRonbK48xgfSyCaRJTJq7nxUkISJwmEmia9dTJhCHWWAHo8TqU6tZIFp2 M0p8614O1sIpYC1x/PIOZhBbWMBdouVKLyOIzSKgIrFo7Wo2EJtXwFJizboOZghbUOLkzCcs IDYz0KmNh7uhbHmJ7W/nMEO8oCDx8+kyVoi4iMTszjawD0QEnCSO/PGZwCg8C8mkWUgmzUIy aRaS7gWMLKsYRVMLinPTc5MLDPWKE3OLS/PS9ZLzczcxgmNSK2gH47L1f/UOMTJxMB5ilOBg VhLhbX44P0WINyWxsiq1KD++qDQntfgQozQHi5I4r3JOZ4qQQHpiSWp2ampBahFMlomDU6qB SWXqLOHOU2Lrtmb93bdEIMpweeOmx0Kfp8YzqpXlcFy+dZ2plblmT/2h9QdDfl5KlLgrdXVF RIzMtA0qDlmnzdi4xMTPfMpd+Umv5+F0gRl80TNzw/8vkbz18objhtiTp1Y6zW/d7F6/JjFc vK81/NzhO29ORp/vqD2idXj+8f3r6vYciT505MYfjwsqVot3HpggW3bSmmX1DUsRk4lHPz5P nrQk6OKVbVpa4td1nojdi+x0LflRM1ne7OA1zfvfr354mVr/pFSqxOtRuBj33/96bkdfdgfx 5Kcd6ErunHJO4c/PRuGwtd8ZmdUideefyFkXtdAvsMf4kF5X9nFWWcOj+0t+SQR9jeX/y7t9 sZUSS3FGoqEWc1FxIgAYrp9ROAMAAA== X-CMS-MailID: 20230703234948epcas1p135dbb5248ac8fefbe47651b0f822f4db X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230703214744epcas1p1d2763aa96e694d0e1693fabf953e83f6 References: <20230703214715.623447-1-paul@crapouillou.net> <20230703214715.623447-3-paul@crapouillou.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > -----Original Message----- > From: dri-devel On Behalf Of > Paul Cercueil > Sent: Tuesday, July 4, 2023 6:47 AM > To: Krzysztof Kozlowski ; Rob Herring > ; Conor Dooley ; Alim Akhtar > ; Neil Armstrong ; Sam > Ravnborg > Cc: devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Paul Cercueil > ; linux-arm-kernel@lists.infradead.org > Subject: [PATCH 2/3] drm/panel: ld9040: Register a backlight device > > Register a backlight device to be able to switch between all the gamma > levels. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 ++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > index 7fd9444b42c5..b4f87d6244cb 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > @@ -8,6 +8,7 @@ > * Andrzej Hajda > */ > > +#include > #include > #include > #include > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx) > return 0; > } > > +static int ld9040_bl_update_status(struct backlight_device *dev) > +{ > + struct ld9040 *ctx = dev_get_drvdata(&dev->dev); > + > + ctx->brightness = dev->props.brightness; > + ld9040_brightness_set(ctx); > + > + return 0; > +} > + > +static int ld9040_bl_get_intensity(struct backlight_device *dev) > +{ > + if (dev->props.fb_blank == FB_BLANK_UNBLANK && fb_blank member is deprecated according to the description of backlight.h file so you could drop above condition I think. Thanks, Inki Dae From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C87CEB64DC for ; Mon, 3 Jul 2023 23:49:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 081B210E0F5; Mon, 3 Jul 2023 23:49:57 +0000 (UTC) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF5D410E0F5 for ; Mon, 3 Jul 2023 23:49:53 +0000 (UTC) Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230703234950epoutp01578e6d9fa0725dc42621be3659727737~ugH5p_Y_R0593905939epoutp01j for ; Mon, 3 Jul 2023 23:49:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230703234950epoutp01578e6d9fa0725dc42621be3659727737~ugH5p_Y_R0593905939epoutp01j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1688428190; bh=M+PRu7t9Av84Uq/Ch0fMWh1O29jRGMDgZGtSzOc9xKM=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=aDmNxbVl5fUOBvMnLppcWNenyJRFVsKnQNTPTHRMwe3LMXrzUVWDdLEboxWO1V1Ki Ebu42x7ZwillKvw55ob+Clsn/yDrxhHYq5yD9gfP7o54OH4jgoow8JT/xTZ6CrB0uy ztw7TrtDKodx8RIX1DYyNzeRCoeEV3SW5OdTKQYM= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230703234950epcas1p396c3d95d3081fdb4cc6a7b662b6d10a0~ugH5HwxpT2621426214epcas1p3v; Mon, 3 Jul 2023 23:49:50 +0000 (GMT) Received: from epsmgec1p1.samsung.com (unknown [182.195.38.232]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4Qw2hs1sJCz4x9Q5; Mon, 3 Jul 2023 23:49:49 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmgec1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 35.2B.57829.D9E53A46; Tue, 4 Jul 2023 08:49:49 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230703234948epcas1p135dbb5248ac8fefbe47651b0f822f4db~ugH3qBiKn3212432124epcas1p1h; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230703234948epsmtrp1ca01f9d5f8bf242bc49208fe9ad72fb8~ugH3pWq-C0142701427epsmtrp1o; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) X-AuditID: b6c32a33-635fe7000001e1e5-96-64a35e9d7c15 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id D6.BD.64355.C9E53A46; Tue, 4 Jul 2023 08:49:48 +0900 (KST) Received: from inkidae001 (unknown [10.113.221.213]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230703234948epsmtip224f17eb1dec36c6ebb221f4bfba05bc9~ugH3aH8S70594605946epsmtip2N; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) From: =?ks_c_5601-1987?B?tOvAzrHiL1RpemVuIFBsYXRmb3JtIExhYihTUikvu++8usD8wNo=?= To: "'Paul Cercueil'" , "'Krzysztof Kozlowski'" , "'Rob Herring'" , "'Conor Dooley'" , "'Alim Akhtar'" , "'Neil Armstrong'" , "'Sam Ravnborg'" In-Reply-To: <20230703214715.623447-3-paul@crapouillou.net> Subject: RE: [PATCH 2/3] drm/panel: ld9040: Register a backlight device Date: Tue, 4 Jul 2023 08:49:48 +0900 Message-ID: <0f0c01d9ae09$0d3a17f0$27ae47d0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ks_c_5601-1987" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: ko Thread-Index: AQELXz3jF3oWSYlPLwE5KJCmEnZTHgIJPQsEAjYh06WxI1eC4A== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMJsWRmVeSWpSXmKPExsWy7bCmge7cuMUpBqv+cFg8mLeNzWLN3nNM FvOPnGO1uPL1PZtF34uHzBabHl9jtbi8aw6bxYzz+5gs3u+8xWjRv/gSi0Xr3iPsFit+bmV0 4PFYfamdzWPTqk42jzvX9rB53O8+zuSxeUm9x5JpV9k8+rasYvT4vEkugCMq2yYjNTEltUgh NS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6FolhbLEnFKgUEBicbGS vp1NUX5pSapCRn5xia1SakFKToFpgV5xYm5xaV66Xl5qiZWhgYGRKVBhQnbG1pP+BX0CFT2f WxkbGK/wdjFyckgImEi0PdvA2MXIxSEksINRonHKYVYI5xOjxNvOu4xwzsOL21hhWs5+aYZK 7GSUWHBhGxuE85JRYtmq5ywgVWwCGRJ32xeDzRIR2M8k0fTtDTOIwyywhVHi+pk57CBVnALW Escv72AGsYUF3CVarvQygtgsAioSi9auZgOxeQUsJdas62CGsAUlTs58AraBWcBIYsnq+UwQ trzE9rdzmCHuU5D4+XQZK0RcRGJ2ZxtQnAPoCieJI398QG6QELjAIbFsynxGiHoXiXOXnkP1 Cku8Or6FHcKWknjZ38YO0TCZUeLO9RUsEM4MRonDP69DdRtL7F86mQnCVpTY+XsuI8RmPol3 X3tYQTZLCPBKdLQJQZQoSRy7eAOqVULiwpKJbBMYlWYh+W0Wkt9mIfltFpJ/FjCyrGIUSy0o zk1PTTYsMITHeHJ+7iZGcGrWMt7BeHn+P71DjEwcjIcYJTiYlUR4mx/OTxHiTUmsrEotyo8v Ks1JLT7EaAoM7onMUqLJ+cDskFcSb2hiaWBiZmRsYmFoZqgkzqs4YXaKkEB6YklqdmpqQWoR TB8TB6dUA1OPg3/515WHvtjnf9bxYdgtXyj5kIM3mTU2x2Vq4bm95b+rb7ukCSdIzeFijP4Q yR+5lM8q0O9l5S1GKaMi7o0btyavPOik1n3jwiQOaWtRxj0KK5iS/+5asedU5fY1pzLPpC66 qlPwONZHOmuTt79v6IJVn2b0NGSyhZ/iu668OZpVsFDMPrJ//+n29WcPLNSq95zKFvdOqvbJ ScbliY2t++LYP/M0lrXr/Zv7bdXnnAtPut7wP6uLXjJbPUdJpXPmyRrepEdbtdXVZzH3r2x7 dHZ3h0nj9LOGv55F/ttw55W3iYOB/kUzlW0K7+XcNxaEa6czypSXmsUohb75dWNddW1q4sHp mzeLZOz7qsRSnJFoqMVcVJwIANnp/j9WBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsWy7bCSvO6cuMUpBs2z5SwezNvGZrFm7zkm i/lHzrFaXPn6ns2i78VDZotNj6+xWlzeNYfNYsb5fUwW73feYrToX3yJxaJ17xF2ixU/tzI6 8HisvtTO5rFpVSebx51re9g87ncfZ/LYvKTeY8m0q2wefVtWMXp83iQXwBHFZZOSmpNZllqk b5fAlbH1pH9Bn0BFz+dWxgbGK7xdjJwcEgImEme/NDN2MXJxCAlsZ5SY1nGduYuRAyghIbFl KweEKSxx+HAxRMlzRonbK48xgfSyCaRJTJq7nxUkISJwmEmia9dTJhCHWWAHo8TqU6tZIFp2 M0p8614O1sIpYC1x/PIOZhBbWMBdouVKLyOIzSKgIrFo7Wo2EJtXwFJizboOZghbUOLkzCcs IDYz0KmNh7uhbHmJ7W/nMEO8oCDx8+kyVoi4iMTszjawD0QEnCSO/PGZwCg8C8mkWUgmzUIy aRaS7gWMLKsYRVMLinPTc5MLDPWKE3OLS/PS9ZLzczcxgmNSK2gH47L1f/UOMTJxMB5ilOBg VhLhbX44P0WINyWxsiq1KD++qDQntfgQozQHi5I4r3JOZ4qQQHpiSWp2ampBahFMlomDU6qB SWXqLOHOU2Lrtmb93bdEIMpweeOmx0Kfp8YzqpXlcFy+dZ2plblmT/2h9QdDfl5KlLgrdXVF RIzMtA0qDlmnzdi4xMTPfMpd+Umv5+F0gRl80TNzw/8vkbz18objhtiTp1Y6zW/d7F6/JjFc vK81/NzhO29ORp/vqD2idXj+8f3r6vYciT505MYfjwsqVot3HpggW3bSmmX1DUsRk4lHPz5P nrQk6OKVbVpa4td1nojdi+x0LflRM1ne7OA1zfvfr354mVr/pFSqxOtRuBj33/96bkdfdgfx 5Kcd6ErunHJO4c/PRuGwtd8ZmdUideefyFkXtdAvsMf4kF5X9nFWWcOj+0t+SQR9jeX/y7t9 sZUSS3FGoqEWc1FxIgAYrp9ROAMAAA== X-CMS-MailID: 20230703234948epcas1p135dbb5248ac8fefbe47651b0f822f4db X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230703214744epcas1p1d2763aa96e694d0e1693fabf953e83f6 References: <20230703214715.623447-1-paul@crapouillou.net> <20230703214715.623447-3-paul@crapouillou.net> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, > -----Original Message----- > From: dri-devel On Behalf Of > Paul Cercueil > Sent: Tuesday, July 4, 2023 6:47 AM > To: Krzysztof Kozlowski ; Rob Herring > ; Conor Dooley ; Alim Akhtar > ; Neil Armstrong ; Sam > Ravnborg > Cc: devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Paul Cercueil > ; linux-arm-kernel@lists.infradead.org > Subject: [PATCH 2/3] drm/panel: ld9040: Register a backlight device > > Register a backlight device to be able to switch between all the gamma > levels. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 ++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > index 7fd9444b42c5..b4f87d6244cb 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > @@ -8,6 +8,7 @@ > * Andrzej Hajda > */ > > +#include > #include > #include > #include > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx) > return 0; > } > > +static int ld9040_bl_update_status(struct backlight_device *dev) > +{ > + struct ld9040 *ctx = dev_get_drvdata(&dev->dev); > + > + ctx->brightness = dev->props.brightness; > + ld9040_brightness_set(ctx); > + > + return 0; > +} > + > +static int ld9040_bl_get_intensity(struct backlight_device *dev) > +{ > + if (dev->props.fb_blank == FB_BLANK_UNBLANK && fb_blank member is deprecated according to the description of backlight.h file so you could drop above condition I think. Thanks, Inki Dae From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42FF5EB64DC for ; Mon, 3 Jul 2023 23:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z2xs0llD7s0uidE8rhABUNL7k0W5m3IMYfhwkDkGdbs=; b=mxDYDExGpae+zK +QvGBtrvKFQTLpMLSVH5vM3vBPwIrMiYcn/8w3N//tZWVIlTsXH1P4p89BowMzl1fO4+Onhk4a/vV pT2W/41E+WwAgjGP1HsnV4bBT/PmDIELlOcTcI+xb00RgV6salw/SFkg44FOouq22oTT74XYXkA4R nkURDRet49Fw5+PmvnjFhr7HYQ95aA5g1PUAI+VeP8ENUhrXzY/wNXIdPV7uDdmkYkFF5yRpd4abu 0HQ5yICF6bPAJ6lT+ZD9bOWgBCCQTeuxD5AMrF63/29StPtPYiGStAHbu9XZVnm4E4p1LTC3jLue3 DsZDTmVVsIHV4HT8e+UQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGTIx-00Bffl-11; Mon, 03 Jul 2023 23:50:03 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGTIu-00Bfe2-0U for linux-arm-kernel@lists.infradead.org; Mon, 03 Jul 2023 23:50:02 +0000 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20230703234950epoutp0263dceabd47071ff2b1b69ed67e66fe83~ugH5p6GzA1340213402epoutp02C for ; Mon, 3 Jul 2023 23:49:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20230703234950epoutp0263dceabd47071ff2b1b69ed67e66fe83~ugH5p6GzA1340213402epoutp02C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1688428190; bh=M+PRu7t9Av84Uq/Ch0fMWh1O29jRGMDgZGtSzOc9xKM=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=aDmNxbVl5fUOBvMnLppcWNenyJRFVsKnQNTPTHRMwe3LMXrzUVWDdLEboxWO1V1Ki Ebu42x7ZwillKvw55ob+Clsn/yDrxhHYq5yD9gfP7o54OH4jgoow8JT/xTZ6CrB0uy ztw7TrtDKodx8RIX1DYyNzeRCoeEV3SW5OdTKQYM= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230703234950epcas1p396c3d95d3081fdb4cc6a7b662b6d10a0~ugH5HwxpT2621426214epcas1p3v; Mon, 3 Jul 2023 23:49:50 +0000 (GMT) Received: from epsmgec1p1.samsung.com (unknown [182.195.38.232]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4Qw2hs1sJCz4x9Q5; Mon, 3 Jul 2023 23:49:49 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmgec1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 35.2B.57829.D9E53A46; Tue, 4 Jul 2023 08:49:49 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230703234948epcas1p135dbb5248ac8fefbe47651b0f822f4db~ugH3qBiKn3212432124epcas1p1h; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) Received: from epsmgmcp1.samsung.com (unknown [182.195.42.82]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230703234948epsmtrp1ca01f9d5f8bf242bc49208fe9ad72fb8~ugH3pWq-C0142701427epsmtrp1o; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) X-AuditID: b6c32a33-635fe7000001e1e5-96-64a35e9d7c15 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgmcp1.samsung.com (Symantec Messaging Gateway) with SMTP id D6.BD.64355.C9E53A46; Tue, 4 Jul 2023 08:49:48 +0900 (KST) Received: from inkidae001 (unknown [10.113.221.213]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230703234948epsmtip224f17eb1dec36c6ebb221f4bfba05bc9~ugH3aH8S70594605946epsmtip2N; Mon, 3 Jul 2023 23:49:48 +0000 (GMT) From: =?ks_c_5601-1987?B?tOvAzrHiL1RpemVuIFBsYXRmb3JtIExhYihTUikvu++8usD8wNo=?= To: "'Paul Cercueil'" , "'Krzysztof Kozlowski'" , "'Rob Herring'" , "'Conor Dooley'" , "'Alim Akhtar'" , "'Neil Armstrong'" , "'Sam Ravnborg'" Cc: , , , , In-Reply-To: <20230703214715.623447-3-paul@crapouillou.net> Subject: RE: [PATCH 2/3] drm/panel: ld9040: Register a backlight device Date: Tue, 4 Jul 2023 08:49:48 +0900 Message-ID: <0f0c01d9ae09$0d3a17f0$27ae47d0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: ko Thread-Index: AQELXz3jF3oWSYlPLwE5KJCmEnZTHgIJPQsEAjYh06WxI1eC4A== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMJsWRmVeSWpSXmKPExsWy7bCmge7cuMUpBqv+cFg8mLeNzWLN3nNM FvOPnGO1uPL1PZtF34uHzBabHl9jtbi8aw6bxYzz+5gs3u+8xWjRv/gSi0Xr3iPsFit+bmV0 4PFYfamdzWPTqk42jzvX9rB53O8+zuSxeUm9x5JpV9k8+rasYvT4vEkugCMq2yYjNTEltUgh NS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6FolhbLEnFKgUEBicbGS vp1NUX5pSapCRn5xia1SakFKToFpgV5xYm5xaV66Xl5qiZWhgYGRKVBhQnbG1pP+BX0CFT2f WxkbGK/wdjFyckgImEi0PdvA2MXIxSEksINRonHKYVYI5xOjxNvOu4xwzsOL21hhWs5+aYZK 7GSUWHBhGxuE85JRYtmq5ywgVWwCGRJ32xeDzRIR2M8k0fTtDTOIwyywhVHi+pk57CBVnALW Escv72AGsYUF3CVarvQygtgsAioSi9auZgOxeQUsJdas62CGsAUlTs58AraBWcBIYsnq+UwQ trzE9rdzmCHuU5D4+XQZK0RcRGJ2ZxtQnAPoCieJI398QG6QELjAIbFsynxGiHoXiXOXnkP1 Cku8Or6FHcKWknjZ38YO0TCZUeLO9RUsEM4MRonDP69DdRtL7F86mQnCVpTY+XsuI8RmPol3 X3tYQTZLCPBKdLQJQZQoSRy7eAOqVULiwpKJbBMYlWYh+W0Wkt9mIfltFpJ/FjCyrGIUSy0o zk1PTTYsMITHeHJ+7iZGcGrWMt7BeHn+P71DjEwcjIcYJTiYlUR4mx/OTxHiTUmsrEotyo8v Ks1JLT7EaAoM7onMUqLJ+cDskFcSb2hiaWBiZmRsYmFoZqgkzqs4YXaKkEB6YklqdmpqQWoR TB8TB6dUA1OPg3/515WHvtjnf9bxYdgtXyj5kIM3mTU2x2Vq4bm95b+rb7ukCSdIzeFijP4Q yR+5lM8q0O9l5S1GKaMi7o0btyavPOik1n3jwiQOaWtRxj0KK5iS/+5asedU5fY1pzLPpC66 qlPwONZHOmuTt79v6IJVn2b0NGSyhZ/iu668OZpVsFDMPrJ//+n29WcPLNSq95zKFvdOqvbJ ScbliY2t++LYP/M0lrXr/Zv7bdXnnAtPut7wP6uLXjJbPUdJpXPmyRrepEdbtdXVZzH3r2x7 dHZ3h0nj9LOGv55F/ttw55W3iYOB/kUzlW0K7+XcNxaEa6czypSXmsUohb75dWNddW1q4sHp mzeLZOz7qsRSnJFoqMVcVJwIANnp/j9WBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsWy7bCSvO6cuMUpBs2z5SwezNvGZrFm7zkm i/lHzrFaXPn6ns2i78VDZotNj6+xWlzeNYfNYsb5fUwW73feYrToX3yJxaJ17xF2ixU/tzI6 8HisvtTO5rFpVSebx51re9g87ncfZ/LYvKTeY8m0q2wefVtWMXp83iQXwBHFZZOSmpNZllqk b5fAlbH1pH9Bn0BFz+dWxgbGK7xdjJwcEgImEme/NDN2MXJxCAlsZ5SY1nGduYuRAyghIbFl KweEKSxx+HAxRMlzRonbK48xgfSyCaRJTJq7nxUkISJwmEmia9dTJhCHWWAHo8TqU6tZIFp2 M0p8614O1sIpYC1x/PIOZhBbWMBdouVKLyOIzSKgIrFo7Wo2EJtXwFJizboOZghbUOLkzCcs IDYz0KmNh7uhbHmJ7W/nMEO8oCDx8+kyVoi4iMTszjawD0QEnCSO/PGZwCg8C8mkWUgmzUIy aRaS7gWMLKsYRVMLinPTc5MLDPWKE3OLS/PS9ZLzczcxgmNSK2gH47L1f/UOMTJxMB5ilOBg VhLhbX44P0WINyWxsiq1KD++qDQntfgQozQHi5I4r3JOZ4qQQHpiSWp2ampBahFMlomDU6qB SWXqLOHOU2Lrtmb93bdEIMpweeOmx0Kfp8YzqpXlcFy+dZ2plblmT/2h9QdDfl5KlLgrdXVF RIzMtA0qDlmnzdi4xMTPfMpd+Umv5+F0gRl80TNzw/8vkbz18objhtiTp1Y6zW/d7F6/JjFc vK81/NzhO29ORp/vqD2idXj+8f3r6vYciT505MYfjwsqVot3HpggW3bSmmX1DUsRk4lHPz5P nrQk6OKVbVpa4td1nojdi+x0LflRM1ne7OA1zfvfr354mVr/pFSqxOtRuBj33/96bkdfdgfx 5Kcd6ErunHJO4c/PRuGwtd8ZmdUideefyFkXtdAvsMf4kF5X9nFWWcOj+0t+SQR9jeX/y7t9 sZUSS3FGoqEWc1FxIgAYrp9ROAMAAA== X-CMS-MailID: 20230703234948epcas1p135dbb5248ac8fefbe47651b0f822f4db X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230703214744epcas1p1d2763aa96e694d0e1693fabf953e83f6 References: <20230703214715.623447-1-paul@crapouillou.net> <20230703214715.623447-3-paul@crapouillou.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230703_165000_666182_E5E841FD X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, > -----Original Message----- > From: dri-devel On Behalf Of > Paul Cercueil > Sent: Tuesday, July 4, 2023 6:47 AM > To: Krzysztof Kozlowski ; Rob Herring > ; Conor Dooley ; Alim Akhtar > ; Neil Armstrong ; Sam > Ravnborg > Cc: devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Paul Cercueil > ; linux-arm-kernel@lists.infradead.org > Subject: [PATCH 2/3] drm/panel: ld9040: Register a backlight device > > Register a backlight device to be able to switch between all the gamma > levels. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 ++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > index 7fd9444b42c5..b4f87d6244cb 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c > @@ -8,6 +8,7 @@ > * Andrzej Hajda > */ > > +#include > #include > #include > #include > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx) > return 0; > } > > +static int ld9040_bl_update_status(struct backlight_device *dev) > +{ > + struct ld9040 *ctx = dev_get_drvdata(&dev->dev); > + > + ctx->brightness = dev->props.brightness; > + ld9040_brightness_set(ctx); > + > + return 0; > +} > + > +static int ld9040_bl_get_intensity(struct backlight_device *dev) > +{ > + if (dev->props.fb_blank == FB_BLANK_UNBLANK && fb_blank member is deprecated according to the description of backlight.h file so you could drop above condition I think. Thanks, Inki Dae _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel