From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D9EC433F5 for ; Thu, 21 Oct 2021 08:03:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABC1F61186 for ; Thu, 21 Oct 2021 08:03:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ABC1F61186 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9172583405; Thu, 21 Oct 2021 10:03:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634803387; bh=Z/hu9sZdJqCYFev8bUB7cdBHTE0lGfOymMZXJbfQhzU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ty7BuBBqow7hGkqbcYMNXYXacyb3Rn4JPNMmi73C7AmcJat4Hq+FopvvX7j2sqy+8 ApxdfrLyCsK6b5s2hgt3jelAg3GlLImVmkGnavxhInptA1ZAsNk6qy0fMUZrDNUkuE lwgS1B5K28nomirpostW9FSDSynP7rHSVI9dQVf4T1lFu/i8Jfl5Y2i2LnICXrO5sz jYjXvrFCxWwAZHryFLB34I63EQ0DFjh7/xdmtfyfieCW5xu1z/YiLGb26kZOuHxtpg 1B8JyZNCPW32/K+B9Cv32TvLvXhCuwbxT17C8EdgH2TkOn9acLeltP6C/zrOWL6ZRo olsb5w3aqd1HA== Received: from [IPv6:2001:a61:603e:fa01:c5ff:9de3:9099:9c5e] (unknown [IPv6:2001:a61:603e:fa01:c5ff:9de3:9099:9c5e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbabic@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 408308326F; Thu, 21 Oct 2021 10:03:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634803385; bh=Z/hu9sZdJqCYFev8bUB7cdBHTE0lGfOymMZXJbfQhzU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=mPn/mlkeUklkzW9aY9IILYKA0MvEaMDjY7YEsD2P8DQTDFPEhLoHeVfk6mv8lWMu+ L/IR4WLeGfJXy24FBigQecGauIbl3pFvB6yTRJSnSdgxJZsFlLB0K6mJHvNs4DgCeo 2YYEGUjfEG5m65Z90rxdMnGpa0kACZetJEl8lu3nXjRDP3V7fpDtWR81k3pckvi0Cd Pv3XRxMD6VJPfkkNDlQkM68RtT6qqgZuo0/0TywqS5FOwFSFwimwbE2tS72iENrgMM sAS3y/zfK/4OPVgaAp8b2aSka5PxFG1aXBJa0dqAwORdZJO57y3QwzQVvrTFFEoiI+ L2IKj549NKQqA== Subject: Re: [PATCH] arm: dts: imx8mp: Delete default clocks for clock controller node To: "Peng Fan (OSS)" , Ye Li , "sbabic@denx.de" , "u-boot@lists.denx.de" , "festevam@gmail.com" , Peng Fan Cc: dl-uboot-imx References: <1629181924-56410-1-git-send-email-ye.li@nxp.com> <05ec034e-39fd-b6c5-4012-e5264155602b@oss.nxp.com> From: Stefano Babic Message-ID: <0f1057b4-4f19-596b-2ea3-07ac05c75076@denx.de> Date: Thu, 21 Oct 2021 10:03:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <05ec034e-39fd-b6c5-4012-e5264155602b@oss.nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Peng, On 15.09.21 05:01, Peng Fan (OSS) wrote: > > > On 2021/8/17 14:32, Ye Li wrote: >> Since SPL has initialized clocks for bus and core. We don't need to >> set the default clocks for clock controller node. >> >> Signed-off-by: Ye Li >> --- >>   arch/arm/dts/imx8mp-u-boot.dtsi | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi >> b/arch/arm/dts/imx8mp-u-boot.dtsi >> index d61346d..a6ede2e 100644 >> --- a/arch/arm/dts/imx8mp-u-boot.dtsi >> +++ b/arch/arm/dts/imx8mp-u-boot.dtsi >> @@ -18,6 +18,9 @@ >>   &clk { >>       u-boot,dm-spl; >>       u-boot,dm-pre-reloc; >> +    /delete-property/ assigned-clocks; >> +    /delete-property/ assigned-clock-parents; >> +    /delete-property/ assigned-clock-rates; >>   }; >>   &osc_32k { >> > > For a release fix, this is ok. > Acked-by: Peng Fan > > But for distro boot, we need think Linux Kernel will > use the device tree exported by U-Boot. Removing > this property may cause issue. > But let's think this is not the only use case. The other use case is kernel has its own DT and not the one from U-Boot. In products in field, if kernel has a strong dependency from U-Boot, a kernel update can be done only if it is together a bootloader update. > I think other vendors may has similar issue > that U-Boot modify dtb and corrupt distribution > kernel booting. We should also think about if thsi is a good thing. There could not be a kernel update without a u-boot update. And just a few devices have support for a powercut safe bootloader update. I do not want to be very OT, I apply the patch, sorry for delay. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================