From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: ale@rev.ng, bcain@quicinc.com, philmd@redhat.com
Subject: Re: [PATCH v2 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions
Date: Tue, 1 Jun 2021 16:49:00 -0700 [thread overview]
Message-ID: <0f158963-3426-14c9-5ebd-8f0c96db712f@linaro.org> (raw)
In-Reply-To: <1622589584-22571-4-git-send-email-tsimpson@quicinc.com>
On 6/1/21 4:19 PM, Taylor Simpson wrote:
> Previously the store-conditional code was writing to hex_pred[prednum].
> Then, the fGEN_TCG override was reading from there to the destination
> variable so that the packet commit logic would handle it properly.
>
> The correct implementation is to write to the destination variable
> and don't have the extra read in the override.
>
> Remove the unused arguments from gen_store_conditional[48]
>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 4 ++--
> target/hexagon/macros.h | 2 +-
> target/hexagon/genptr.c | 10 ++++------
> 3 files changed, 7 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-06-01 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 23:19 [PATCH v2 0/4] Hexagon (target/hexagon) bug fixes and cleanup Taylor Simpson
2021-06-01 23:19 ` [PATCH v2 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW* Taylor Simpson
2021-06-01 23:41 ` Richard Henderson
2021-06-01 23:19 ` [PATCH v2 2/4] Hexagon (target/hexagon) fix l2fetch instructions Taylor Simpson
2021-06-01 23:43 ` Richard Henderson
2021-06-01 23:19 ` [PATCH v2 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions Taylor Simpson
2021-06-01 23:49 ` Richard Henderson [this message]
2021-06-01 23:19 ` [PATCH v2 4/4] Hexagon (target/hexagon) remove unused TCG variables Taylor Simpson
2021-06-01 23:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f158963-3426-14c9-5ebd-8f0c96db712f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.