All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Juha-Pekka Heikkilä" <juhapekka.heikkila@gmail.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Skip the Y<->X tile test on pre-skl
Date: Thu, 21 Jan 2021 23:38:05 +0200	[thread overview]
Message-ID: <0f1bc159-e48e-d372-c200-de36c4814afe@gmail.com> (raw)
In-Reply-To: <20210111161658.3476-1-ville.syrjala@linux.intel.com>

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

Ville Syrjala kirjoitti 11.1.2021 klo 18.16:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Pre-skl display engine does not support Y-tiling so the
> addfb will fail. Skip the test on such platforms.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   tests/kms_async_flips.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index dea23cf9ef15..e397a54b874f 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -335,6 +335,9 @@ static void test_invalid(data_t *data)
>   	width = data->connector->modes[0].hdisplay;
>   	height = data->connector->modes[0].vdisplay;
>   
> +	igt_require(igt_display_has_format_mod(&data->display, DRM_FORMAT_XRGB8888,
> +					       LOCAL_I915_FORMAT_MOD_Y_TILED));
> +
>   	igt_create_fb(data->drm_fd, width, height, DRM_FORMAT_XRGB8888,
>   		      LOCAL_I915_FORMAT_MOD_Y_TILED, &fb);
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2021-01-21 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 16:16 [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Skip the Y<->X tile test on pre-skl Ville Syrjala
2021-01-11 16:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-11 18:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-21 21:38 ` Juha-Pekka Heikkilä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f1bc159-e48e-d372-c200-de36c4814afe@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.