From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts
Date: Mon, 17 Dec 2018 08:07:44 -0800
Message-ID: <0f1fa411-8fe5-cfdb-f846-87dca51c69c8@gmail.com>
References: <20181214224007.54813-1-cpaasch@apple.com>
 <20181214224007.54813-2-cpaasch@apple.com>
 <4f327eec-ce46-c871-0ca5-26d6939b9faf@gmail.com>
 <20181217154958.GU41383@MacBook-Pro-19.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Yuchung Cheng <ycheng@google.com>,
        David Miller <davem@davemloft.net>
To: Christoph Paasch <cpaasch@apple.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f65.google.com ([209.85.221.65]:33981 "EHLO
        mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727279AbeLQQHt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 17 Dec 2018 11:07:49 -0500
Received: by mail-wr1-f65.google.com with SMTP id j2so12880947wrw.1
        for <netdev@vger.kernel.org>; Mon, 17 Dec 2018 08:07:47 -0800 (PST)
In-Reply-To: <20181217154958.GU41383@MacBook-Pro-19.local>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 12/17/2018 07:49 AM, Christoph Paasch wrote:

> It gets called from tcp_fastopen_destroy_cipher() though (to destroy the
> socket's TFO-keys when the socket gets closed). There it has to destroy the
> whole list.
> 
> Same when going through exit_batch for the namespace.
> 
> 
> We could of course split it in tcp_fastopen_ctx_free_one() and
> tcp_fastopen_ctx_free_all(). But maybe that's overkill as it's a rare thing
> to do?


No, this is fine, please see my second review of this first patch.

Thanks.