From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 112ADC433DB for ; Tue, 23 Mar 2021 12:41:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C41CB619BA for ; Tue, 23 Mar 2021 12:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbhCWMlK (ORCPT ); Tue, 23 Mar 2021 08:41:10 -0400 Received: from linux.microsoft.com ([13.77.154.182]:51466 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231305AbhCWMkx (ORCPT ); Tue, 23 Mar 2021 08:40:53 -0400 Received: from [192.168.254.32] (unknown [47.187.194.202]) by linux.microsoft.com (Postfix) with ESMTPSA id 4C00420B5680; Tue, 23 Mar 2021 05:40:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4C00420B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616503250; bh=fyO5OQ1MPXrJo3wHhJyQvWPjoGtn/RSEVDvabSJsv1k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=eiXkMmyle2ssvKgeEoUiPU29JsoyuIylPUXLLhxvpY3DsrgqhiH49PZPnjyEGHbtt suPb+C2C9SInJGPRNnxQYiliZnWzcazkH3c+xb8Bud67JLzr6z7DnIh3rLFjFLJruy KPPCyciXJhEjcj9KMlIHIsuyIcgzUlTYZrmUj2Kw= Subject: Re: [RFC PATCH v2 3/8] arm64: Terminate the stack trace at TASK_FRAME and EL0_FRAME To: Mark Rutland Cc: Mark Brown , jpoimboe@redhat.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <5997dfe8d261a3a543667b83c902883c1e4bd270> <20210315165800.5948-1-madvenka@linux.microsoft.com> <20210315165800.5948-4-madvenka@linux.microsoft.com> <20210318182607.GO5469@sirena.org.uk> <20210323103644.GC95840@C02TD0UTHF1T.local> From: "Madhavan T. Venkataraman" Message-ID: <0f36fe36-c435-f12a-661b-7075f899e4fb@linux.microsoft.com> Date: Tue, 23 Mar 2021 07:40:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210323103644.GC95840@C02TD0UTHF1T.local> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/21 5:36 AM, Mark Rutland wrote: > On Thu, Mar 18, 2021 at 03:29:19PM -0500, Madhavan T. Venkataraman wrote: >> >> >> On 3/18/21 1:26 PM, Mark Brown wrote: >>> On Mon, Mar 15, 2021 at 11:57:55AM -0500, madvenka@linux.microsoft.com wrote: >>> >>>> + /* Terminal record, nothing to unwind */ >>>> + if (fp == (unsigned long) regs->stackframe) { >>>> + if (regs->frame_type == TASK_FRAME || >>>> + regs->frame_type == EL0_FRAME) >>>> + return -ENOENT; >>>> return -EINVAL; >>>> + } >>> >>> This is conflating the reliable stacktrace checks (which your series >>> will later flag up with frame->reliable) with verifying that we found >>> the bottom of the stack by looking for this terminal stack frame record. >>> For the purposes of determining if the unwinder got to the bottom of the >>> stack we don't care what stack type we're looking at, we just care if it >>> managed to walk to this defined final record. >>> >>> At the minute nothing except reliable stack trace has any intention of >>> checking the specific return code but it's clearer to be consistent. >>> >> >> So, you are saying that the type check is redundant. OK. I will remove it >> and just return -ENOENT on reaching the final record. > > Yes please; and please fold that into the same patch that adds the final > records. > Will do. Thanks. Madhavan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E1CEC433DB for ; Tue, 23 Mar 2021 12:42:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D52F3619AB for ; Tue, 23 Mar 2021 12:42:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D52F3619AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kSGDBvPB2W2KKK6OpwKFI8+/cfJ8WI8IOarK1/Dgrcw=; b=jQJ74SUuuUPtj1e01h6xyO7Ex oG3MG+DsNdG7FZRZq9tfDXtnKu+fSxgERs7Ylo4Lb2akNJCc3Jv3xrzCij6Xc4P3T/mKqN4ixKWsc zwrFGXZHZRtI8G1QmPNluUlhwMNOukvLyBR534TQLPaZX6i810iyudrM+USHjFBaHWtIoJRmwla0m CeCIy4kdqAD7FmWb/AYtWz+GTtcboAT+aN/hs07FpNoDw8uPgGtFuTUhAA5XICiPBPOwl0Ctu0z+Z GPZG7UgZMoXKTVLsnoOLqbLcs7px+47UFTYlVQXvjSOZcYVsXj1r5gDYb1oIkFzFat+Q4zW0NIi8E GOo5fukAw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOgL9-00EyXF-Sa; Tue, 23 Mar 2021 12:40:56 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOgL6-00EyWX-4t for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 12:40:54 +0000 Received: from [192.168.254.32] (unknown [47.187.194.202]) by linux.microsoft.com (Postfix) with ESMTPSA id 4C00420B5680; Tue, 23 Mar 2021 05:40:50 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4C00420B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1616503250; bh=fyO5OQ1MPXrJo3wHhJyQvWPjoGtn/RSEVDvabSJsv1k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=eiXkMmyle2ssvKgeEoUiPU29JsoyuIylPUXLLhxvpY3DsrgqhiH49PZPnjyEGHbtt suPb+C2C9SInJGPRNnxQYiliZnWzcazkH3c+xb8Bud67JLzr6z7DnIh3rLFjFLJruy KPPCyciXJhEjcj9KMlIHIsuyIcgzUlTYZrmUj2Kw= Subject: Re: [RFC PATCH v2 3/8] arm64: Terminate the stack trace at TASK_FRAME and EL0_FRAME To: Mark Rutland Cc: Mark Brown , jpoimboe@redhat.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <5997dfe8d261a3a543667b83c902883c1e4bd270> <20210315165800.5948-1-madvenka@linux.microsoft.com> <20210315165800.5948-4-madvenka@linux.microsoft.com> <20210318182607.GO5469@sirena.org.uk> <20210323103644.GC95840@C02TD0UTHF1T.local> From: "Madhavan T. Venkataraman" Message-ID: <0f36fe36-c435-f12a-661b-7075f899e4fb@linux.microsoft.com> Date: Tue, 23 Mar 2021 07:40:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210323103644.GC95840@C02TD0UTHF1T.local> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_124052_458085_C100E775 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/23/21 5:36 AM, Mark Rutland wrote: > On Thu, Mar 18, 2021 at 03:29:19PM -0500, Madhavan T. Venkataraman wrote: >> >> >> On 3/18/21 1:26 PM, Mark Brown wrote: >>> On Mon, Mar 15, 2021 at 11:57:55AM -0500, madvenka@linux.microsoft.com wrote: >>> >>>> + /* Terminal record, nothing to unwind */ >>>> + if (fp == (unsigned long) regs->stackframe) { >>>> + if (regs->frame_type == TASK_FRAME || >>>> + regs->frame_type == EL0_FRAME) >>>> + return -ENOENT; >>>> return -EINVAL; >>>> + } >>> >>> This is conflating the reliable stacktrace checks (which your series >>> will later flag up with frame->reliable) with verifying that we found >>> the bottom of the stack by looking for this terminal stack frame record. >>> For the purposes of determining if the unwinder got to the bottom of the >>> stack we don't care what stack type we're looking at, we just care if it >>> managed to walk to this defined final record. >>> >>> At the minute nothing except reliable stack trace has any intention of >>> checking the specific return code but it's clearer to be consistent. >>> >> >> So, you are saying that the type check is redundant. OK. I will remove it >> and just return -ENOENT on reaching the final record. > > Yes please; and please fold that into the same patch that adds the final > records. > Will do. Thanks. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel