From: Dmitry Osipenko <digetx@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Stefan Hansson <newbyte@disroot.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [PATCH v2] brcmfmac: firmware: Fix firmware loading
Date: Thu, 5 Aug 2021 04:44:43 +0300 [thread overview]
Message-ID: <0f439074-83ea-087d-7eec-aa6d4d3d4689@gmail.com> (raw)
In-Reply-To: <20210804153434.3429348-1-linus.walleij@linaro.org>
04.08.2021 18:34, Linus Walleij пишет:
> + fwctx->tested_board_variant = false;
This shouldn't be really needed, isn't it?
> ret = request_firmware_nowait(THIS_MODULE, true, alt_path,
> fwctx->dev, GFP_KERNEL, fwctx,
> - brcmf_fw_request_done);
> + brcmf_fw_request_done_first);
> kfree(alt_path);
> - }
> - /* Else try canonical path */
> - if (ret) {
> + } else {
> + fwctx->tested_board_variant = true;
> ret = request_firmware_nowait(THIS_MODULE, true, first->path,
> fwctx->dev, GFP_KERNEL, fwctx,
> - brcmf_fw_request_done);
> + brcmf_fw_request_done_first);
> }
> if (ret < 0)
> - brcmf_fw_request_done(NULL, fwctx);
> + brcmf_fw_request_done_first(NULL, fwctx);
This "else" can be replaced with:
if (!alt_path || ret < 0)
brcmf_fw_request_done(NULL, fwctx);
next prev parent reply other threads:[~2021-08-05 1:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 15:34 [PATCH v2] brcmfmac: firmware: Fix firmware loading Linus Walleij
2021-08-05 1:22 ` Dmitry Osipenko
2021-08-05 9:14 ` Linus Walleij
2021-08-05 10:01 ` Dmitry Osipenko
2021-08-05 1:35 ` Dmitry Osipenko
2021-08-05 9:17 ` Linus Walleij
2021-08-05 10:06 ` Dmitry Osipenko
2021-08-05 1:44 ` Dmitry Osipenko [this message]
2021-08-05 9:27 ` Linus Walleij
2021-08-05 10:10 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f439074-83ea-087d-7eec-aa6d4d3d4689@gmail.com \
--to=digetx@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=newbyte@disroot.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.