From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 7 Nov 2019 18:46:14 +0100
Subject: [U-Boot] [PATCH V2 1/3] watchdog: designware: Migrate
 CONFIG_DESIGNWARE_WATCHDOG to Kconfig
In-Reply-To: <CAFiDJ58vgBpYr3VDn+1SjQCBTcNOU8o0U4gkq26UqGKMTF_gzg@mail.gmail.com>
References: <20191003125942.14826-1-marex@denx.de>
 <CAFiDJ5_iC+qFoTxinG-AW9XfKEHQ-20zUPkOkZ028wzSUQrJZg@mail.gmail.com>
 <ff157cc5-94b0-87f5-47f4-0e875b29d068@denx.de>
 <CAFiDJ58KwoZmFTrsDzVNXeiTyrPoQt-DgA7et7eHnrUBXHC3QQ@mail.gmail.com>
 <03f22b8a-af1c-bc8a-423f-18ad89699b1f@denx.de>
 <CAFiDJ58vgBpYr3VDn+1SjQCBTcNOU8o0U4gkq26UqGKMTF_gzg@mail.gmail.com>
Message-ID: <0f4665b4-1052-f62e-e623-b7e5c91d1113@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/11/19 11:51 AM, Ley Foon Tan wrote:
> On Thu, Oct 10, 2019 at 3:47 PM Marek Vasut wrote:
>>
>> On 10/10/19 8:28 AM, Ley Foon Tan wrote:
>>> On Fri, Oct 4, 2019 at 7:04 PM Marek Vasut wrote:
>>>>
>>>> On 10/4/19 10:59 AM, Ley Foon Tan wrote:
>>>>> On Thu, Oct 3, 2019 at 9:00 PM Marek Vasut wrote:
>>>>>>
>>>>>> Migrate CONFIG_DESIGNWARE_WATCHDOG to Kconfig and update the headers
>>>>>> accordingly, no functional change. The S10 enables the WDT only in
>>>>>> SPL, but does not enable it in U-Boot itself, hence disable it in
>>>>>> the config again.
>>>>>> ---
>>>>>> V2: Use non-DM watchdog in SPL on S10
>>>>>> ---
>>>>>>  configs/socfpga_stratix10_defconfig       | 1 +
>>>>>>  configs/socfpga_vining_fpga_defconfig     | 1 +
>>>>>
>>>>> All socfpga deconfig files need to add CONFIG_DESIGNWARE_WATCHDOG too.
>>>>> socfpga_common.h is used by Gen5 and A10 platform.
>>>>
>>>> Only those which defined CONFIG_HW_WATCHDOG need to enable the
>>>> CONFIG_DESIGNWARE_WATCHDOG, right ? (see below)
>>>
>>> $ git grep socfpga_common.h
>>> include/configs/socfpga_arria10_socdk.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_arria5_socdk.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_cyclone5_socdk.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_dbm_soc1.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_de0_nano_soc.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_de10_nano.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_de1_soc.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_is1.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_mcvevk.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_sockit.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_socrates.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_sr1500.h:#include <configs/socfpga_common.h>
>>> include/configs/socfpga_vining_fpga.h:#include <configs/socfpga_common.h>
>>>
>>> These platforms include socfpga_common.h file, so their _defconfig
>>> need to update too.
>>
>> They don't enable HW_WATCHDOG, so it doesn't ... or ?
> Sorry, I see wrongly. I thought HW_WATCHDOG is defined in socfpga_common.h.
> Then no problem now.

Sorry for the late reply.

Are we OK with this patch then ?