All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Benoit Parrot <bparrot@ti.com>, Rob Herring <robh+dt@kernel.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Patch 00/19] media: ti-vpe: cal: maintenance
Date: Mon, 21 Oct 2019 12:50:02 +0200	[thread overview]
Message-ID: <0f48c5a0-4c30-8c1c-928a-96af0321ed00@xs4all.nl> (raw)
In-Reply-To: <20191018153437.20614-1-bparrot@ti.com>

Hi Benoit,

This series looks good to me. I had just one small comment on patch 7
and a comment on patch 19.

Just post a v2 for just patch 7/19 and post a patch 20/19 for the requested
MAINTAINERS change.

Once I have Rob's Acks I can merge this.

Regards,

	Hans

On 10/18/19 5:34 PM, Benoit Parrot wrote:
> This a collection of backlog patches I have been carrying for the CAL
> driver.
> 
> - Add support for SoC variants.
> 
> - Switches to syscon/regmap to access a system controller register for
> the DPHY configuration. This register has different bit layout depending
> on the SoC version.
> 
> - It adds supports for pre ES2.0 silicon errata.
> 
> - Reworked the DPHY initialization sequence to match the technical
> reference manual and provide a more robust restartability.
> 
> - Adds the missing ability to power subdevice.
> 
> - Update the devicetree binding and then converts it to dt-schema 
> 
> Benoit Parrot (18):
>   dt-bindings: media: cal: update binding to use syscon
>   dt-bindings: media: cal: update binding example
>   media: ti-vpe: cal: Add per platform data support
>   media: ti-vpe: cal: Enable DMABUF export
>   dt-bindings: media: cal: update binding to add PHY LDO errata support
>   media: ti-vpe: cal: add CSI2 PHY LDO errata support
>   media: ti-vpe: cal: Fix ths_term/ths_settle parameters
>   media: ti-vpe: cal: Fix pixel processing parameters
>   media: ti-vpe: cal: Align DPHY init sequence with docs
>   dt-bindings: media: cal: update binding to add DRA76x support
>   media: ti-vpe: cal: Add DRA76x support
>   dt-bindings: media: cal: update binding to add AM654 support
>   media: ti-vpe: cal: Add AM654 support
>   media: ti-vpe: cal: Add subdev s_power hooks
>   media: ti-vpe: cal: Properly calculate max resolution boundary
>   media: ti-vpe: cal: Fix a WARN issued when start streaming fails
>   media: ti-vpe: cal: fix enum_mbus_code/frame_size subdev arguments
>   dt-bindings: media: cal: convert binding to yaml
> 
> Nikhil Devshatwar (1):
>   media: ti-vpe: cal: Restrict DMA to avoid memory corruption
> 
>  .../devicetree/bindings/media/ti,cal.yaml     | 186 +++++
>  .../devicetree/bindings/media/ti-cal.txt      |  72 --
>  drivers/media/platform/Kconfig                |   2 +-
>  drivers/media/platform/ti-vpe/cal.c           | 775 ++++++++++++++----
>  drivers/media/platform/ti-vpe/cal_regs.h      |  27 +
>  5 files changed, 830 insertions(+), 232 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/ti,cal.yaml
>  delete mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
> 


  parent reply	other threads:[~2019-10-21 10:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 15:34 [Patch 00/19] media: ti-vpe: cal: maintenance Benoit Parrot
2019-10-18 15:34 ` [Patch 01/19] dt-bindings: media: cal: update binding to use syscon Benoit Parrot
2019-10-29 13:20   ` Rob Herring
2019-10-30 13:39     ` Benoit Parrot
2019-10-18 15:34 ` [Patch 02/19] dt-bindings: media: cal: update binding example Benoit Parrot
2019-10-29 13:21   ` Rob Herring
2019-10-30 13:41     ` Benoit Parrot
2019-10-18 15:34 ` [Patch 03/19] media: ti-vpe: cal: Add per platform data support Benoit Parrot
2019-10-29 13:18   ` Rob Herring
2019-10-30 13:34     ` Benoit Parrot
2019-10-18 15:34 ` [Patch 04/19] media: ti-vpe: cal: Enable DMABUF export Benoit Parrot
2019-10-18 15:34 ` [Patch 05/19] media: ti-vpe: cal: Restrict DMA to avoid memory corruption Benoit Parrot
2019-10-18 15:34 ` [Patch 06/19] dt-bindings: media: cal: update binding to add PHY LDO errata support Benoit Parrot
2019-10-29 13:23   ` Rob Herring
2019-10-18 15:34 ` [Patch 07/19] media: ti-vpe: cal: add CSI2 " Benoit Parrot
2019-10-21 10:38   ` Hans Verkuil
2019-10-23 16:03     ` Benoit Parrot
2019-10-18 15:34 ` [Patch 08/19] media: ti-vpe: cal: Fix ths_term/ths_settle parameters Benoit Parrot
2019-10-18 15:34 ` [Patch 09/19] media: ti-vpe: cal: Fix pixel processing parameters Benoit Parrot
2019-10-18 15:34 ` [Patch 10/19] media: ti-vpe: cal: Align DPHY init sequence with docs Benoit Parrot
2019-10-18 15:34 ` [Patch 11/19] dt-bindings: media: cal: update binding to add DRA76x support Benoit Parrot
2019-10-29 13:24   ` Rob Herring
2019-10-18 15:34 ` [Patch 12/19] media: ti-vpe: cal: Add " Benoit Parrot
2019-10-18 15:34 ` [Patch 13/19] dt-bindings: media: cal: update binding to add AM654 support Benoit Parrot
2019-10-29 13:24   ` Rob Herring
2019-10-18 15:34 ` [Patch 14/19] media: ti-vpe: cal: Add " Benoit Parrot
2019-10-18 15:34 ` [Patch 15/19] media: ti-vpe: cal: Add subdev s_power hooks Benoit Parrot
2019-10-18 15:34 ` [Patch 16/19] media: ti-vpe: cal: Properly calculate max resolution boundary Benoit Parrot
2019-10-18 15:34 ` [Patch 17/19] media: ti-vpe: cal: Fix a WARN issued when start streaming fails Benoit Parrot
2019-10-18 15:34 ` [Patch 18/19] media: ti-vpe: cal: fix enum_mbus_code/frame_size subdev arguments Benoit Parrot
2019-10-18 15:34 ` [Patch 19/19] dt-bindings: media: cal: convert binding to yaml Benoit Parrot
2019-10-21 10:49   ` Hans Verkuil
2019-10-23 16:06     ` Benoit Parrot
2019-10-22  7:46   ` Sakari Ailus
2019-10-23 16:18     ` Benoit Parrot
2019-10-24  6:13       ` Sakari Ailus
2019-10-29 14:22   ` Rob Herring
2019-10-30 13:54     ` Benoit Parrot
2019-10-21 10:50 ` Hans Verkuil [this message]
2019-10-23 16:05   ` [Patch 00/19] media: ti-vpe: cal: maintenance Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f48c5a0-4c30-8c1c-928a-96af0321ed00@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.