From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1EEC07E96 for ; Thu, 15 Jul 2021 08:38:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FF6D60231 for ; Thu, 15 Jul 2021 08:38:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FF6D60231 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B48982BD2; Thu, 15 Jul 2021 10:38:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626338323; bh=ULGSHSf27rvkGQrnpRsYZL8PGj/ZdOdEyUyKc+cC5vY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Y/i4w5SAmRp7AzD3gl43XtZGBeU4U+/PF5mi6/oFr+euoPILjab2VdL2j3CLVdLlk sz6w3aVs+tqGNvTitE2lOEn1/Ben10oaygkqXFKoO18rNrEOZc0P32k7tHKwKeJMZ9 2n4HRqExVuXP+y49twD6hqXwE28Pcm6nApl+MR3lpCtKl7gDbKbgB2Et+nhlfQrdXD hVvW8EjC5AVqNOiMnHXzcjPOQxOJBZTF/tFSV50WPHUGsjXj0ecMVfAYTe83FwiZyD e4krKnWGLSQp4KoWGf6Zjw20PdFQkzf6dIFBXOU4vd3baw3pkU/IpWD3XB9tNZSiBF WSqetthwCr2Wg== Received: by phobos.denx.de (Postfix, from userid 109) id BBFB582BFA; Thu, 15 Jul 2021 10:38:40 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0115282BD2 for ; Thu, 15 Jul 2021 10:38:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4GQSSs6GC9zQjVH; Thu, 15 Jul 2021 10:38:37 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id V-78xu_UP2KA; Thu, 15 Jul 2021 10:38:33 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu 11/31] tools: kwboot: Fix wrong parameter passed to read() To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dirk Eibach , Chris Packham Cc: Dennis Gilmore , Mario Six , Jon Nettleton , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210708173032.27999-1-marek.behun@nic.cz> <20210708173032.27999-12-marek.behun@nic.cz> From: Stefan Roese Message-ID: <0f4ed317-9827-a51d-0b2e-4ab19c41f803@denx.de> Date: Thu, 15 Jul 2021 10:38:32 +0200 MIME-Version: 1.0 In-Reply-To: <20210708173032.27999-12-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.06 / 15.00 / 15.00 X-Rspamd-Queue-Id: D4DCD1841 X-Rspamd-UID: 648df4 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 08.07.21 19:30, Marek Behún wrote: > From: Pali Rohár > > The 'buf' is a pointer and '_buf' is the array itself. > Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read(). > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > tools/kwboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kwboot.c b/tools/kwboot.c > index 4be094c9c8..2edeb5a371 100644 > --- a/tools/kwboot.c > +++ b/tools/kwboot.c > @@ -471,7 +471,7 @@ kwboot_term_pipe(int in, int out, char *quit, int *s) > ssize_t nin, nout; > char _buf[128], *buf = _buf; > > - nin = read(in, buf, sizeof(buf)); > + nin = read(in, buf, sizeof(_buf)); > if (nin <= 0) > return -1; > > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de