From: Saeed Mahameed <saeed@kernel.org>
To: Leon Romanovsky <leon@kernel.org>, Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups
Date: Tue, 05 Jan 2021 13:04:10 -0800 [thread overview]
Message-ID: <0f5be5508fd3110e01823d03b3188f5ceef3a5d1.camel@kernel.org> (raw)
In-Reply-To: <20201227083302.GD4457@unreal>
On Sun, 2020-12-27 at 10:33 +0200, Leon Romanovsky wrote:
> On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote:
> > When mlx5_create_flow_group() fails, ft->g should be
> > freed just like when kvzalloc() fails. The caller of
> > mlx5e_create_l2_table_groups() does not catch this
> > issue on failure, which leads to memleak.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Fixes: 33cfaaa8f36f ("net/mlx5e: Split the main flow steering table")
>
Added
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Applied to net-mlx5
Thanks
prev parent reply other threads:[~2021-01-05 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 11:27 [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups Dinghao Liu
2020-12-27 8:33 ` Leon Romanovsky
2021-01-05 21:04 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5be5508fd3110e01823d03b3188f5ceef3a5d1.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.