Re: [Qemu-devel] [PATCH 18/26] hw: acpi: Initial hardware-reduced support

From: Paolo Bonzini <pbonzini@redhat.com>
To: Samuel Ortiz <sameo@linux.intel.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 18/26] hw: acpi: Initial hardware-reduced support
Date: Wed, 24 Oct 2018 00:09:18 +0200	[thread overview]
Message-ID: <0f69efce-a104-00ae-ef8a-899aea0a801c@redhat.com> (raw)
In-Reply-To: <20181022183656.4902-19-sameo@linux.intel.com>

On 22/10/2018 20:36, Samuel Ortiz wrote:
> We build a minimal set of ACPI hardware-reduced tables: XSDT,
> FADT, MADT and a DSDT pointed by a RSDP.
> The DSDT only contains one PCI host bridge for now.
> 
> This API will be consumed by new x86 machine type but also potentially
> by the ARM virt one.
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

Do not include patches that essentially add dead code.  It is nice to
have hardware-reduced support, but if you want to contribute it you need
to add a user as well, for example the ARM virt machine type.

In fact, using it in the ARM virt machine type is a no-brainer, so doing
that change (even if it's not yet part of NEMU) would be an excellent
way to reduce your delta, without going through the processing of
convincing QEMU maintainers of the advantages of your new x86 machine type.

Paolo