From: David Christensen <drc@linux.vnet.ibm.com>
To: Omkar Maslekar <omkar.maslekar@intel.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com, ciara.loftus@intel.com,
jerinj@marvell.com, ruifeng.wang@arm.com,
honnappa.nagarahalli@arm.com
Subject: Re: [dpdk-dev] [PATCH v6] eal: add cache-line demote support
Date: Mon, 12 Oct 2020 12:31:59 -0700 [thread overview]
Message-ID: <0f6c65bd-901b-cc0f-1510-0fd08227f8c4@linux.vnet.ibm.com> (raw)
In-Reply-To: <1602497980-20680-2-git-send-email-omkar.maslekar@intel.com>
On 10/12/20 3:19 AM, Omkar Maslekar wrote:
> rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr)
> enables software to hint to hardware that line is likely to be shared.
> Useful in core-to-core communications where cache-line is likely to be
> shared. ARM and PPC implementation is provided with NOP and can be added
> if any equivalent instructions could be used for implementation on those
> architectures.
>
> Signed-off-by: Omkar Maslekar <omkar.maslekar@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> ---
> v6: marked rte_cldemote as experimental
> added rte_cldemote call in existing app/test_prefetch.c
>
> v5: documentation updated
> fixed formatting issue in release notes
> added Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> *
> v4: updated bold text for title and fixed margin in release notes
> *
> v3: fixed warning regarding whitespace
> *
> v2: documentation updated
> ---
> ---
> app/test/test_prefetch.c | 4 ++++
> doc/guides/rel_notes/release_20_11.rst | 7 +++++++
> lib/librte_eal/arm/include/rte_prefetch_32.h | 8 ++++++++
> lib/librte_eal/arm/include/rte_prefetch_64.h | 8 ++++++++
> lib/librte_eal/include/generic/rte_prefetch.h | 16 ++++++++++++++++
> lib/librte_eal/ppc/include/rte_prefetch.h | 8 ++++++++
> lib/librte_eal/x86/include/rte_prefetch.h | 12 ++++++++++++
> 7 files changed, 63 insertions(+)
...snip...
> diff --git a/lib/librte_eal/ppc/include/rte_prefetch.h b/lib/librte_eal/ppc/include/rte_prefetch.h
> index 9ba07c8..9630227 100644
> --- a/lib/librte_eal/ppc/include/rte_prefetch.h
> +++ b/lib/librte_eal/ppc/include/rte_prefetch.h
> @@ -11,6 +11,7 @@
> #endif
>
> #include <rte_common.h>
> +#include <rte_compat.h>
> #include "generic/rte_prefetch.h"
>
> static inline void rte_prefetch0(const volatile void *p)
> @@ -34,6 +35,13 @@ static inline void rte_prefetch_non_temporal(const volatile void *p)
> rte_prefetch0(p);
> }
>
> +static inline void
> +__rte_experimental
> +rte_cldemote(const volatile void *p)
> +{
> + RTE_SET_USED(p);
> +}
> +
> #ifdef __cplusplus
> }
> #endif
Don't see an equivalent operation in the 3.1 ISA for POWER processors,
so NOP is the right implementation.
Acked-by: David Christensen <drc@linux.vnet.ibm.com>
next prev parent reply other threads:[~2020-10-12 19:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:16 [dpdk-dev] [PATCH] EAL: An addition of cache line demote (CLDEMOTE) in rte_prefetch.h Omkar Maslekar
2020-09-10 1:16 ` Omkar Maslekar
2020-09-10 8:55 ` Bruce Richardson
2020-09-10 23:30 ` Maslekar, Omkar
2020-09-10 22:04 ` David Christensen
2020-09-11 16:51 ` [dpdk-dev] [PATCH v2] " Omkar Maslekar
2020-09-11 16:51 ` Omkar Maslekar
2020-09-11 21:22 ` [dpdk-dev] [PATCH v3] " Omkar Maslekar
2020-09-11 21:22 ` Omkar Maslekar
2020-09-22 1:59 ` [dpdk-dev] [PATCH v4] eal: add cache-line demote support Omkar Maslekar
2020-09-22 1:59 ` Omkar Maslekar
2020-09-22 8:28 ` Bruce Richardson
2020-09-22 21:53 ` Maslekar, Omkar
2020-10-01 0:28 ` [dpdk-dev] [PATCH v5] " Omkar Maslekar
2020-10-01 0:28 ` Omkar Maslekar
2020-10-08 7:09 ` David Marchand
2020-10-08 9:02 ` Bruce Richardson
2020-10-12 9:41 ` David Marchand
2020-10-08 13:12 ` Jerin Jacob
2020-10-12 10:19 ` [dpdk-dev] [PATCH v6] " Omkar Maslekar
2020-10-12 10:19 ` Omkar Maslekar
2020-10-12 19:31 ` David Christensen [this message]
2020-10-13 2:59 ` Ruifeng Wang
2020-10-13 16:20 ` Bruce Richardson
2020-10-14 1:55 ` Ruifeng Wang
2020-10-14 7:14 ` David Marchand
2020-10-14 7:51 ` Ruifeng Wang
2020-10-13 9:43 ` [dpdk-dev] [PATCH v7] " Omkar Maslekar
2020-10-13 9:43 ` Omkar Maslekar
2020-10-14 7:24 ` Ruifeng Wang
2020-10-15 8:01 ` David Marchand
2020-10-15 14:41 ` Maslekar, Omkar
2020-10-15 20:32 ` David Marchand
2020-10-15 15:18 ` [dpdk-dev] [PATCH v8] " Omkar Maslekar
2020-10-15 15:18 ` Omkar Maslekar
2020-10-15 23:20 ` [dpdk-dev] [PATCH v9] " Omkar Maslekar
2020-10-15 23:20 ` Omkar Maslekar
2020-10-16 12:14 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f6c65bd-901b-cc0f-1510-0fd08227f8c4@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=omkar.maslekar@intel.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.