From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 269BF6E173 for ; Tue, 18 Sep 2018 22:52:26 +0000 (UTC) From: "Pandiyan, Dhinakaran" Date: Tue, 18 Sep 2018 22:52:24 +0000 Message-ID: <0f7da9ecb8fee45822bb9b973071292aa35fb3de.camel@intel.com> References: <20180918221531.18233-1-jose.souza@intel.com> <20180918221531.18233-3-jose.souza@intel.com> In-Reply-To: <20180918221531.18233-3-jose.souza@intel.com> Content-Language: en-US Content-ID: <052CA4400F33654B85D12E8DA39992A7@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/3] test/kms_fbcon_fbt: Give a explicit parameter name to functions that expect debugfs fd List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Souza, Jose" List-ID: T24gVHVlLCAyMDE4LTA5LTE4IGF0IDE1OjE1IC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXph IHdyb3RlOg0KPiBMZXQncyByZW5hbWUgdG8gZGVidWdmc19mZCBhbGwgdGhlIHBhcmFtZXRlcnMg b2YgdGhlIGZ1bmN0aW9ucyB0aGF0DQo+IGV4cGVjdCBkZWJ1Z2ZzIGZkIHRvIGF2b2lkIGNhbGwg b25lIHRob3NlIGZ1bmN0aW9ucyB3aXRoIHRoZSB3cm9uZw0KPiBmaWxlIGRlc2NyaXB0b3IuDQo+ IA0KU2VyaWVzIFJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBh bmRpeWFuQGludGVsLmNvbT4NCg0KDQo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWth cmFuLnBhbmRpeWFuQGludGVsLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+DQo+IC0tLQ0KPiAgdGVzdHMva21zX2ZiY29u X2ZidC5jIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEx IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rlc3Rz L2ttc19mYmNvbl9mYnQuYyBiL3Rlc3RzL2ttc19mYmNvbl9mYnQuYw0KPiBpbmRleCAxMzhlZGE5 Yi4uOTg2OWFhMTQgMTAwNjQ0DQo+IC0tLSBhL3Rlc3RzL2ttc19mYmNvbl9mYnQuYw0KPiArKysg Yi90ZXN0cy9rbXNfZmJjb25fZmJ0LmMNCj4gQEAgLTIwMywzNCArMjAzLDM0IEBAIHN0YXRpYyBi b29sIHBzcl9pc19lbmFibGVkKGludCBkZWJ1Z2ZzX2ZkKQ0KPiAgCXJldHVybiBzdHJzdHIoYnVm LCAiXG5IVyBFbmFibGVkICYgQWN0aXZlIGJpdDogeWVzXG4iKTsNCj4gIH0NCj4gIA0KPiAtc3Rh dGljIGJvb2wgcHNyX3dhaXRfdW50aWxfZW5hYmxlZChpbnQgZmQpDQo+ICtzdGF0aWMgYm9vbCBw c3Jfd2FpdF91bnRpbF9lbmFibGVkKGludCBkZWJ1Z2ZzX2ZkKQ0KPiAgew0KPiAtCWJvb2wgciA9 IGlndF93YWl0KHBzcl9pc19lbmFibGVkKGZkKSwgNTAwMCwgMSk7DQo+IC0JcHNyX3ByaW50X3N0 YXR1cyhmZCk7DQo+ICsJYm9vbCByID0gaWd0X3dhaXQocHNyX2lzX2VuYWJsZWQoZGVidWdmc19m ZCksIDUwMDAsIDEpOw0KPiArCXBzcl9wcmludF9zdGF0dXMoZGVidWdmc19mZCk7DQo+ICAJcmV0 dXJuIHI7DQo+ICB9DQo+ICANCj4gLXN0YXRpYyB2b2lkIGRpc2FibGVfZmVhdHVyZXMoaW50IGZk KQ0KPiArc3RhdGljIHZvaWQgZGlzYWJsZV9mZWF0dXJlcyhpbnQgZGVidWdmc19mZCkNCj4gIHsN Cj4gIAlpZ3Rfc2V0X21vZHVsZV9wYXJhbV9pbnQoImVuYWJsZV9mYmMiLCAwKTsNCj4gLQlwc3Jf ZGlzYWJsZShmZCk7DQo+ICsJcHNyX2Rpc2FibGUoZGVidWdmc19mZCk7DQo+ICB9DQo+ICANCj4g LXN0YXRpYyBpbmxpbmUgdm9pZCBmYmNfbW9kcGFyYW1fZW5hYmxlKGludCBmZCkNCj4gK3N0YXRp YyBpbmxpbmUgdm9pZCBmYmNfbW9kcGFyYW1fZW5hYmxlKGludCBkZWJ1Z2ZzX2ZkKQ0KPiAgew0K PiAgCWlndF9zZXRfbW9kdWxlX3BhcmFtX2ludCgiZW5hYmxlX2ZiYyIsIDEpOw0KPiAgfQ0KPiAg DQo+IC1zdGF0aWMgaW5saW5lIHZvaWQgcHNyX2RlYnVnZnNfZW5hYmxlKGludCBmZCkNCj4gK3N0 YXRpYyBpbmxpbmUgdm9pZCBwc3JfZGVidWdmc19lbmFibGUoaW50IGRlYnVnZnNfZmQpDQo+ICB7 DQo+IC0JcHNyX2VuYWJsZShmZCk7DQo+ICsJcHNyX2VuYWJsZShkZWJ1Z2ZzX2ZkKTsNCj4gIH0N Cj4gIA0KPiAgc3RydWN0IGZlYXR1cmUgew0KPiAtCWJvb2wgKCpzdXBwb3J0ZWRfb25fY2hpcHNl dCkoaW50IGZkKTsNCj4gLQlib29sICgqd2FpdF91bnRpbF9lbmFibGVkKShpbnQgZmQpOw0KPiAr CWJvb2wgKCpzdXBwb3J0ZWRfb25fY2hpcHNldCkoaW50IGRlYnVnZnNfZmQpOw0KPiArCWJvb2wg KCp3YWl0X3VudGlsX2VuYWJsZWQpKGludCBkZWJ1Z2ZzX2ZkKTsNCj4gIAlib29sICgqY29ubmVj dG9yX3Bvc3NpYmxlX2ZuKShkcm1Nb2RlQ29ubmVjdG9yUHRyDQo+IGNvbm5lY3Rvcik7DQo+IC0J dm9pZCAoKmVuYWJsZSkoaW50IGZkKTsNCj4gKwl2b2lkICgqZW5hYmxlKShpbnQgZGVidWdmc19m ZCk7DQo+ICB9IGZiYyA9IHsNCj4gIAkuc3VwcG9ydGVkX29uX2NoaXBzZXQgPSBmYmNfc3VwcG9y dGVkX29uX2NoaXBzZXQsDQo+ICAJLndhaXRfdW50aWxfZW5hYmxlZCA9IGZiY193YWl0X3VudGls X2VuYWJsZWQsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=