Re: [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
	benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
	groug@kaod.org, clg@kaod.org, christophe.jaillet@wanadoo.fr,
	tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type
Date: Mon, 28 Oct 2019 23:17:10 -0500	[thread overview]
Message-ID: <0f9297fc-a18e-d382-c7fc-a7e2600efc5e@embeddedor.com> (raw)
In-Reply-To: <20191029034027.GA7226@saurav>

This is not actually a 'fix'

I suggest you to rephrase the subject in a different way and
remove the word 'fix' from it.

On 10/28/19 22:40, Saurav Girepunje wrote:
> Use true/false for bool return type in xive_spapr_cleanup_queue
> function.
> 

How do you find this?

If you used a tool to find this, please mention it.

Thanks
--
Gustavo

> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  arch/powerpc/sysdev/xive/spapr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c
> index 33c10749edec..74e3ffae0be6 100644
> --- a/arch/powerpc/sysdev/xive/spapr.c
> +++ b/arch/powerpc/sysdev/xive/spapr.c
> @@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc,
>  static bool xive_spapr_match(struct device_node *node)
>  {
>  	/* Ignore cascaded controllers for the moment */
> -	return 1;
> +	return true;
>  }
>  
>  #ifdef CONFIG_SMP
> 