All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vineeth Pillai <viremana@linux.microsoft.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized
Date: Mon, 26 Jul 2021 20:41:35 -0400	[thread overview]
Message-ID: <0f9db300-d5ec-becb-ff30-ac8ddbb62e15@linux.microsoft.com> (raw)
In-Reply-To: <20210726165843.1441132-1-pbonzini@redhat.com>

Hi Paulo,

Thanks a lot for fixing this.

>   
> diff --git a/arch/x86/kvm/svm/svm_onhyperv.h b/arch/x86/kvm/svm/svm_onhyperv.h
> index 9b9a55abc29f..c53b8bf8d013 100644
> --- a/arch/x86/kvm/svm/svm_onhyperv.h
> +++ b/arch/x86/kvm/svm/svm_onhyperv.h
> @@ -89,7 +89,7 @@ static inline void svm_hv_vmcb_dirty_nested_enlightenments(
>   	 * as we mark it dirty unconditionally towards end of vcpu
>   	 * init phase.
>   	 */
> -	if (vmcb && vmcb_is_clean(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS) &&
> +	if (vmcb_is_clean(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS) &&
>   	    hve->hv_enlightenments_control.msr_bitmap)
>   		vmcb_mark_dirty(vmcb, VMCB_HV_NESTED_ENLIGHTENMENTS);
>   }
The changes looks good to me. Could you please remove the above comment
as well while you are at it.

Many Thanks,
Vineeth

  reply	other threads:[~2021-07-27  0:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 16:58 [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized Paolo Bonzini
2021-07-27  0:41 ` Vineeth Pillai [this message]
2021-07-27 15:23 ` Vitaly Kuznetsov
2021-07-28 20:18   ` Vineeth Pillai
2021-07-29 16:30     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2021-07-26 16:49 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f9db300-d5ec-becb-ff30-ac8ddbb62e15@linux.microsoft.com \
    --to=viremana@linux.microsoft.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.