From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4117BC433F5 for ; Tue, 5 Oct 2021 18:58:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DB6A61371 for ; Tue, 5 Oct 2021 18:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5DB6A61371 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F32482D7C; Tue, 5 Oct 2021 20:58:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OLFApffd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BEAD182D78; Tue, 5 Oct 2021 20:58:17 +0200 (CEST) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A38882D78 for ; Tue, 5 Oct 2021 20:58:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-ot1-x335.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so111749ota.6 for ; Tue, 05 Oct 2021 11:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZoG/AHbx7JmPBWYe6h8pSNcrjLPZSW4mllSCOeKME+Q=; b=OLFApffdcaC923VxJHn8u4D3ua6gLwTkH9fHC0arAGVyW+8Q0qfGpQlWqbG/wmTXMf I8Vecegk47g53k2Fk3gMGfJVl2cxRJKDbSQlTslrqIjML8UqHhSBtvOMbh/w3E64bDJA 0JOv6VjZJVASeRq4ub9oHwE+AckDGoDdX17/WY2vYQrYPkhA9m3F/ptwi4EaPwpGpE4A KxUMaZ+kop7FNSXyJ0lGqazTQ8ZsG8sWVUgZjPMjbq3V2CxOP2rlNTZl3puPyTSZ2rK9 h1hazinVHpMXgnafgBopc/OC9fWDtvemRGYxPvmGXhbq4Z/4ntZD4nqEmXzwljg/MDc0 X4Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZoG/AHbx7JmPBWYe6h8pSNcrjLPZSW4mllSCOeKME+Q=; b=vsm385z+nNMtH9pfMf643Z119SXXYM6L8alkbf45kPCT7Is+aWWvk1EaGNt1hn26XY aZEPdrEHxTxGx0x7lBNfGPoAQhpr9IvkNr8N1bhl9fBcAzH1fOs5dWGxBL3lXQ63W4Ae c+1lH1kzQ/PnI7UTzH4irzxhs10uVGQil447lJpwbLl+gnS0dsmhVZmlmNlNS4S8Csiq Ruu853mfK7Bb4xSC0wt8IABEeFOpfdpT1zQgw3BVFAqOZL4gDwpzYS+xnN0coI02XY78 y9ocQVYZr6KAQ7k1XGTa238H4ER3AYW+2by4Byi8e2nhN9ZkNpm6KmvHKulWmg/2HguQ xFRg== X-Gm-Message-State: AOAM530qBRiizLjJlOGjUh3dL9Qhue5eIIn3JirTjxdPdeSXQCMPkt+J gW8CsQVuw6lnE7BDph0TLaY= X-Google-Smtp-Source: ABdhPJyQKA8rh9lc+geFGsNs+dPJlvHW6V/E7LIk9OvswkGGmsIX86iFfsl9REgka2QlDTOsKfYmzA== X-Received: by 2002:a05:6830:204d:: with SMTP id f13mr15490758otp.123.1633460293199; Tue, 05 Oct 2021 11:58:13 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id o8sm3566886oiw.39.2021.10.05.11.58.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 11:58:12 -0700 (PDT) Subject: Re: [PATCH v5 14/29] image: Drop IMAGE_OF_SYSTEM_SETUP To: Simon Glass , U-Boot Mailing List Cc: Andre Przywara , Rasmus Villemoes , Robert Marko , Masahiro Yamada , Tom Rini , Joe Hershberger , Marek Vasut References: <20210926014342.127913-1-sjg@chromium.org> <20210926014342.127913-8-sjg@chromium.org> From: "Alex G." Message-ID: <0f9de135-c7cd-993c-6f6d-a3f18e35769e@gmail.com> Date: Tue, 5 Oct 2021 13:58:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210926014342.127913-8-sjg@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/25/21 8:43 PM, Simon Glass wrote: > This is not needed with Kconfig, since we can use IS_ENABLED() easily > enough. Drop it. > > Signed-off-by: Simon Glass Reviewed-by: Alexandru Gagniuc > --- > > (no changes since v1) > > common/image-fdt.c | 2 +- > include/image.h | 6 ------ > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/common/image-fdt.c b/common/image-fdt.c > index cd664649e2c..cf87e455230 100644 > --- a/common/image-fdt.c > +++ b/common/image-fdt.c > @@ -597,7 +597,7 @@ int image_setup_libfdt(bootm_headers_t *images, void *blob, > } > } > } > - if (IMAGE_OF_SYSTEM_SETUP) { > + if (IS_ENABLED(CONFIG_OF_SYSTEM_SETUP)) { > fdt_ret = ft_system_setup(blob, gd->bd); > if (fdt_ret) { > printf("ERROR: system-specific fdt fixup failed: %s\n", > diff --git a/include/image.h b/include/image.h > index e1e4148e4c8..e190f59232d 100644 > --- a/include/image.h > +++ b/include/image.h > @@ -49,12 +49,6 @@ struct fdt_region; > #include > #endif /* FIT */ > > -#ifdef CONFIG_OF_SYSTEM_SETUP > -# define IMAGE_OF_SYSTEM_SETUP 1 > -#else > -# define IMAGE_OF_SYSTEM_SETUP 0 > -#endif > - > extern ulong image_load_addr; /* Default Load Address */ > extern ulong image_save_addr; /* Default Save Address */ > extern ulong image_save_size; /* Default Save Size */ >