From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbdILNVx (ORCPT ); Tue, 12 Sep 2017 09:21:53 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:20402 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdILNVt (ORCPT ); Tue, 12 Sep 2017 09:21:49 -0400 X-AuditID: b6c32a48-f79a16d00000362a-45-59b7df6accde Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions To: SF Markus Elfring Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Andrzej Hajda , Jeongtae Park , Kamil Debski , Kyungmin Park , Marek Szyprowski , Mauro Carvalho Chehab , kernel-janitors@vger.kernel.org, LKML From: Sylwester Nawrocki Message-id: <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> Date: Tue, 12 Sep 2017 15:21:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsWy7bCmmW7W/e2RBkd3SFrcWneO1eJ853Jm iyNrrzJZzDzRzmqx9Za0xdmmN+wWmx5fY7W4vGsOm0XPhq2sFmuP3GW3WLbpD5MDt8emVZ1s HpuX1Hv0bVnF6NF0qp3V4/MmOY8rRxrZA9iiuGxSUnMyy1KL9O0SuDLO7PctOMVe0X+th7WB 8R9rFyMnh4SAicSDZ7vZIGwxiQv31gPZXBxCAjsYJaZuXMAO4XxnlPj35BELTMeqSQegEhsY JTZPaWWFcO4DOb8fsINUCQt4S9zZMJ+xi5GDQ0TAVOLPiRCQGmaBFmaJgz1PmUFq2AQMJXqP 9jGC2LwCdhLTPtwAi7MIqEp8fTSBCcQWFYiQ2PZ9BhtEjaDEj8n3WEBmcgp4Siy7JA8SZhaw knj2r5UVwhaXOHb/JiOELS+xec1bZoijX7NJvF0gDGG7SDQeucwIYQtLvDq+hR3ClpZ4tmoj I8idEgL9jBIn1jRDOTMYJe60QxwkIWAtcfj4RahtfBIdh/+ygxwkIcAr0dEmBFHiIXHkxGFW iLCjxPHfKiBhIYHzTBK7noVOYJSfheSbWUhemIXkhVlIXljAyLKKUSy1oDg3PbXYqMBErzgx t7g0L10vOT93EyM4LWl57GA8cM7nEKMAB6MSD2/Are2RQqyJZcWVuYcYJTiYlUR4Wy4DhXhT EiurUovy44tKc1KLDzFKc7AoifPWbbsWISSQnliSmp2aWpBaBJNl4uCUamBUSLhxj9026Zaw 9QeuOrPaJ9NsbzHuyhYyFlvxy8/Iz2uFvYGfVsgLC4f1LwqeLd8rv17Z/SD/FgmDsw+ZZ7qc lTqUmBbtJdR+h6vMV//BNP2luv8VDrVlP+b2TxawCgmOudixd92peeqv7fRf/70Q/mFnVlnm WsWvcb2mKluf6UboNt66ukiJpTgj0VCLuag4EQCuvJOWRwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e+xoG7m/e2RBgueslrcWneO1eJ853Jm iyNrrzJZzDzRzmqx9Za0xdmmN+wWmx5fY7W4vGsOm0XPhq2sFmuP3GW3WLbpD5MDt8emVZ1s HpuX1Hv0bVnF6NF0qp3V4/MmOY8rRxrZA9iiuGxSUnMyy1KL9O0SuDLO7PctOMVe0X+th7WB 8R9rFyMnh4SAicSqSQfYQWwhgXWMEqfuF3UxcgHZDxklbj3rAysSFvCWuLNhPmMXIweHiICp xJ8TISBhZoEWZokFTXwQ9eeZJM5PeAJWzyZgKNF7tI8RxOYVsJOY9uEGM4jNIqAq8fXRBCYQ W1QgQqLv7WV2iBpBiR+T77GAzOcU8JRYdkkeYr6ZxJeXh1khbHGJY/dvMkLY8hKb17xlnsAo MAtJ9ywkLbOQtMxC0rKAkWUVo2RqQXFuem6xUYFRXmq5XnFibnFpXrpecn7uJkZgvGw7rNW/ g/HxkvhDjAIcjEo8vCvubI8UYk0sK67MPcQowcGsJMLbchkoxJuSWFmVWpQfX1Sak1p8iFGa g0VJnDezb0akkEB6YklqdmpqQWoRTJaJg1OqgTFq1RMVrkfPHPcecfqwRjzjqIX3TDtNi4AP SjKt5y3OftDsfbE+tk2Ro/W97fwceYV3xQ8VPga4VAqLVER3Hu0unOAU+4FN2O/1w/c/sg/M OeC3ImeJm9Quc5UwvRmFRutT1UylXrra8tzdq34lxEDSsHezQV7lvu3TP5bqZSxn9rx7/EZJ kxJLcUaioRZzUXEiAKHv1TeTAgAA X-CMS-MailID: 20170912132145epcas2p2edb4282dacf8e54bbf60844246f0c705 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170911092134epcas2p1a1b11c056b52d68c3b0e4ea2e1e8f758 X-RootMTR: 20170911092134epcas2p1a1b11c056b52d68c3b0e4ea2e1e8f758 References: <482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net> <6c2d20b3-4437-0473-73d4-73c049ba52a9@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2017 09:21 PM, SF Markus Elfring wrote: >>> Date: Fri, 8 Sep 2017 22:37:00 +0200 >>> MIME-Version: 1.0 >>> Content-Type: text/plain; charset=UTF-8 >>> Content-Transfer-Encoding: 8bit >> >> Can you resend with that 4 lines removed? > > * Do you care to preserve an information like the author date? In this case not, but actually the Date line is not an issue. Anyway the patch is malformed, please try to save your posted patch and apply with git am and see how finally the commit message looks like. > * Would you like to support special characters in the commit message? I can't see any need for special characters in the patch itself. Please submit the patch in a way that it can be applied properly with patchwork client (or git am). >> Are you using git send-email for sending patches? > > Not so far. I would suggest switching to git send-email, then issues like above could be easily avoided. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Date: Tue, 12 Sep 2017 13:21:38 +0000 Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions Message-Id: <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> List-Id: References: <482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net> <6c2d20b3-4437-0473-73d4-73c049ba52a9@samsung.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 09/11/2017 09:21 PM, SF Markus Elfring wrote: >>> Date: Fri, 8 Sep 2017 22:37:00 +0200 >>> MIME-Version: 1.0 >>> Content-Type: text/plain; charset=UTF-8 >>> Content-Transfer-Encoding: 8bit >> >> Can you resend with that 4 lines removed? > > * Do you care to preserve an information like the author date? In this case not, but actually the Date line is not an issue. Anyway the patch is malformed, please try to save your posted patch and apply with git am and see how finally the commit message looks like. > * Would you like to support special characters in the commit message? I can't see any need for special characters in the patch itself. Please submit the patch in a way that it can be applied properly with patchwork client (or git am). >> Are you using git send-email for sending patches? > > Not so far. I would suggest switching to git send-email, then issues like above could be easily avoided. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Tue, 12 Sep 2017 15:21:38 +0200 Subject: [media] s5p-mfc: Adjust a null pointer check in four functions In-Reply-To: References: <482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net> <6c2d20b3-4437-0473-73d4-73c049ba52a9@samsung.com> Message-ID: <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/11/2017 09:21 PM, SF Markus Elfring wrote: >>> Date: Fri, 8 Sep 2017 22:37:00 +0200 >>> MIME-Version: 1.0 >>> Content-Type: text/plain; charset=UTF-8 >>> Content-Transfer-Encoding: 8bit >> >> Can you resend with that 4 lines removed? > > * Do you care to preserve an information like the author date? In this case not, but actually the Date line is not an issue. Anyway the patch is malformed, please try to save your posted patch and apply with git am and see how finally the commit message looks like. > * Would you like to support special characters in the commit message? I can't see any need for special characters in the patch itself. Please submit the patch in a way that it can be applied properly with patchwork client (or git am). >> Are you using git send-email for sending patches? > > Not so far. I would suggest switching to git send-email, then issues like above could be easily avoided. -- Regards, Sylwester