All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sarah Newman <srn@prgmr.com>
To: Tariq Toukan <tariqt@mellanox.com>, Yishai Hadas <yishaih@mellanox.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page
Date: Tue, 6 Mar 2018 12:16:53 -0800	[thread overview]
Message-ID: <0fb43444-964a-3751-bc2a-1c61e469cc81@prgmr.com> (raw)
In-Reply-To: <0b28d134-eec4-4e81-1b26-e05e38fe5605@mellanox.com>

On 03/06/2018 08:13 AM, Tariq Toukan wrote:

> I have a general question about the process.
> I don't totally get what branch this patch is targeted to.
> It touches critical areas in datapath and should go through regression tests before it is accepted to any branch.
> 

This one is against 4.9 -
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/?h=linux-4.9.y

I assume you'd be interested in applying a fix to all currently maintained stable branches between 3.6 to 4.11, per
https://www.kernel.org/category/releases.html .

I know of at least one other person whose workaround has been to disable GRO, but I don't understand the networking code well enough to guarantee that
disabling GRO means the problem will never occur under all possible error conditions. If it's guaranteed that disabling GRO will definitely mitigate
the bug, probably it's better to stop supporting GRO for these versions of the driver instead of trying to implement some other fix.

--Sarah

  reply	other threads:[~2018-03-06 20:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05  4:20 [PATCH] net/mlx4_en: fix potential use-after-free with dma_unmap_page Sarah Newman
2018-03-05 10:09 ` Tariq Toukan
2018-03-05 21:10   ` Sarah Newman
2018-03-06 16:13     ` Tariq Toukan
2018-03-06 20:16       ` Sarah Newman [this message]
2018-03-11 15:15         ` Tariq Toukan
2018-04-26  4:00           ` [PATCH v2] " Sarah Newman
2018-04-27 23:48             ` David Miller
2018-05-02 13:50               ` Tariq Toukan
2018-05-02 14:26                 ` David Miller
2018-05-31  1:04                   ` [PATCH v3] " Sarah Newman
2018-05-31  5:36                     ` Greg KH
2018-05-31 17:15                       ` Sarah Newman
2018-06-02 13:33                         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fb43444-964a-3751-bc2a-1c61e469cc81@prgmr.com \
    --to=srn@prgmr.com \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@mellanox.com \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.