From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Tom Anderson <thomasanderson@google.com>,
Hans Verkuil <hansverk@cisco.com>,
Manasi Navare <manasi.d.navare@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Error building v5.5-git on PowerPC32 - bisected to commit 7befe621ff81
Date: Thu, 6 Feb 2020 16:46:52 -0600 [thread overview]
Message-ID: <0fb64c98-57c2-b988-051c-6ba0e460ad37@lwfinger.net> (raw)
When building post V5.5 on my PowerBook G4 Aluminum, the build failed with the
following error:
drivers/gpu/drm/drm_edid.c: In function ‘cea_mode_alternate_timings’:
drivers/gpu/drm/drm_edid.c:3275:2: error: call to ‘__compiletime_assert_3282’
declared with attribute error: BUILD_BUG_ON failed: cea_mode_for_vic(8)->vtotal
!= 262 || cea_mode_for_vic(9)->vtotal != 262 || cea_mode_for_vic(12)->vtotal !=
262 || cea_mode_for_vic(13)->vtotal != 262 || cea_mode_for_vic(23)->vtotal !=
312 || cea_mode_for_vic(24)->vtotal != 312 || cea_mode_for_vic(27)->vtotal !=
312 || cea_mode_for_vic(28)->vtotal != 312
This error was bisected to commit 7befe621ff81 ("drm/edid: Abstract away
cea_edid_modes[]").
This problem is clearly a problem with the gcc compiler on the box, namely gcc
(Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3. I had no success finding why the
attributes were wrong, and finally settled on the following hack:
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 99769d6c9f84..062bbe2b254a 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -3272,6 +3272,7 @@ cea_mode_alternate_timings(u8 vic, struct drm_display_mode
*mode)
* get the other variants by simply increasing the
* vertical front porch length.
*/
+#ifndef CONFIG_PPC32
BUILD_BUG_ON(cea_mode_for_vic(8)->vtotal != 262 ||
cea_mode_for_vic(9)->vtotal != 262 ||
cea_mode_for_vic(12)->vtotal != 262 ||
@@ -3280,6 +3281,7 @@ cea_mode_alternate_timings(u8 vic, struct drm_display_mode
*mode)
cea_mode_for_vic(24)->vtotal != 312 ||
cea_mode_for_vic(27)->vtotal != 312 ||
cea_mode_for_vic(28)->vtotal != 312);
+#endif
if (((vic == 8 || vic == 9 ||
vic == 12 || vic == 13) && mode->vtotal < 263) ||
Disabling the build check allows me to build and test the post v5.5 versions.
Larry
next reply other threads:[~2020-02-06 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 22:46 Larry Finger [this message]
2020-02-06 23:12 ` Error building v5.5-git on PowerPC32 - bisected to commit 7befe621ff81 Arvind Sankar
2020-02-06 23:33 ` Arvind Sankar
2020-02-07 0:29 ` Larry Finger
2020-02-07 4:18 ` Arvind Sankar
2020-02-07 13:12 ` Ville Syrjälä
2020-02-07 16:22 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb64c98-57c2-b988-051c-6ba0e460ad37@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=hansverk@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manasi.d.navare@intel.com \
--cc=thomasanderson@google.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.